From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sean Christopherson Date: Tue, 16 Nov 2021 18:43:53 +0000 Subject: [PATCH 6/7] KVM: powerpc: Use Makefile.kvm for common files In-Reply-To: <20211116115051.119956-6-dwmw2@infradead.org> References: <5047c2591310e503491850ef683f251395247d50.camel@infradead.org> <20211116115051.119956-1-dwmw2@infradead.org> <20211116115051.119956-6-dwmw2@infradead.org> Message-ID: List-Id: To: kvm-riscv@lists.infradead.org MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Tue, Nov 16, 2021, David Woodhouse wrote: > From: David Woodhouse > > It's all fairly baroque but in the end, I don't think there's any reason > for $(KVM)/irqchip.o to have been handled differently, as they all end > up in $(kvm-y) in the end anyway, regardless of whether they get there > via $(common-objs-y) and the CPU-specific object lists. > > The generic Makefile.kvm uses HAVE_KVM_IRQCHIP for irqchip.o instead of > HAVE_KVM_IRQ_ROUTING. That change is fine (and arguably correct) because > they are both set together for KVM_MPIC, or neither is set. Nope. Symbol: HAVE_KVM_IRQCHIP [=y] Type : bool Defined at virt/kvm/Kconfig:7 Selected by [m]: - KVM_XICS [=y] && VIRTUALIZATION [=y] && KVM_BOOK3S_64 [=m] && !KVM_MPIC [=n] Selected by [n]: - KVM_MPIC [=n] && VIRTUALIZATION [=y] && KVM [=y] && E500 [=n] leads to this and a whole pile of other errors arch/powerpc/kvm/../../../virt/kvm/irqchip.c: In function ?kvm_irq_map_gsi?: arch/powerpc/kvm/../../../virt/kvm/irqchip.c:31:35: error: invalid use of undefined type ?struct kvm_irq_routing_table? 31 | if (irq_rt && gsi < irq_rt->nr_rt_entries) { | ^~ Side topic, please don't post a new version/series in-reply-to a different series. b4 also gets confused in this case, e.g. it tried to grab the original patch. b4 has also made me really lazy, heaven forbid I actually had to manually grab these from mutt :-) From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4A0F2C433F5 for ; Tue, 16 Nov 2021 18:44:03 +0000 (UTC) Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by mail.kernel.org (Postfix) with ESMTP id C060C61872 for ; Tue, 16 Nov 2021 18:44:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org C060C61872 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.cs.columbia.edu Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 4EA9E4B0BE; Tue, 16 Nov 2021 13:44:02 -0500 (EST) X-Virus-Scanned: at lists.cs.columbia.edu Authentication-Results: mm01.cs.columbia.edu (amavisd-new); dkim=softfail (fail, message has been altered) header.i=@google.com Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 5I5aiz4NjONz; Tue, 16 Nov 2021 13:44:01 -0500 (EST) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 01B3E4B0CE; Tue, 16 Nov 2021 13:44:01 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 649FD4B0BD for ; Tue, 16 Nov 2021 13:44:00 -0500 (EST) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Wowuu3Zi7ieU for ; Tue, 16 Nov 2021 13:43:58 -0500 (EST) Received: from mail-pj1-f44.google.com (mail-pj1-f44.google.com [209.85.216.44]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id A4BFC4A19A for ; Tue, 16 Nov 2021 13:43:58 -0500 (EST) Received: by mail-pj1-f44.google.com with SMTP id nh10-20020a17090b364a00b001a69adad5ebso231486pjb.2 for ; Tue, 16 Nov 2021 10:43:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=GcGOJgSWz7oEIbfl5QNUvPpuAyaNetXEQN0oWs9ap2w=; b=NfWEHKgpp9hvAVj4IrdvyWcutj+oRm5oA4DhrzE5j01yRw6SEr+OqI8zdgqPehlHuc lvLy/whsET41Ju6UmVvOInCo7Ww6t6yLH5qUrncwy6VAmxauCnt99O3r1yirLCVccCfN 0Gay6uTBhe2zfp68q3FXHdSVfO1Z/lBlR6uw3b9mZM9XbPEBfKBoCa/a9sEvB1P9oZqk 5YTcHvsnOOA5rsa3JP9041e/6BOvKA/Xr3X/sbaLIuC63lGrovFZ7b1eudI5InxTZkUr CdOzfVuUVUCDHbMPcWrZAb1YNJexcHENRayQEJiryVfwYQQPdJtpV9LDoK9LoF2MR12X 8enQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=GcGOJgSWz7oEIbfl5QNUvPpuAyaNetXEQN0oWs9ap2w=; b=nt764L3lP31tAb2cfYxr5eVZ35uMRu5aWLxpnZHPH+DPS6pUKJyXxtFfMiWy0VWnue VgCW1Oj5+7hfIjmsBYIc9rJ9raHTLP23hUgLSn8jWRC9nspzpKVo3DHsans9Rj7YgVWm 1NZUmP4BwKQA1UGDHvYulr+6Kndj+NtwRTSrqPaGUi4tGfFPipdEBwBqXrgBs8+f6CBR owB4ArN/tb2psmtMLcRgYAtM8CcGo/vcL2YwViX9kJJYPM1WX18w8MB10SNS611LLdBY kkM90VLkHgJaUJ1o7HUymj3hLeeyzRsjU1qEH0SK9OH35UOPO902Of9LJMIh1O6ab0/f RCig== X-Gm-Message-State: AOAM533zZQGrBg5AF4mSqsfp5cjzA5TPh6sDS+sahd9LlbXGA8mBBi4k ejkSmh5ibgHL4GJPDwBR25e6vQ== X-Google-Smtp-Source: ABdhPJy95F12FbARJJuG3RP+KItNypekR2/l+xifaD1kKSsYtJFW/+wQ/332xG0BY0Bxhx2ISOUtlQ== X-Received: by 2002:a17:90b:4b46:: with SMTP id mi6mr1449604pjb.188.1637088237573; Tue, 16 Nov 2021 10:43:57 -0800 (PST) Received: from google.com (157.214.185.35.bc.googleusercontent.com. [35.185.214.157]) by smtp.gmail.com with ESMTPSA id r8sm15237754pgp.30.2021.11.16.10.43.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Nov 2021 10:43:56 -0800 (PST) Date: Tue, 16 Nov 2021 18:43:53 +0000 From: Sean Christopherson To: David Woodhouse Subject: Re: [PATCH 6/7] KVM: powerpc: Use Makefile.kvm for common files Message-ID: References: <5047c2591310e503491850ef683f251395247d50.camel@infradead.org> <20211116115051.119956-1-dwmw2@infradead.org> <20211116115051.119956-6-dwmw2@infradead.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20211116115051.119956-6-dwmw2@infradead.org> Cc: Anup Patel , "wanpengli @ tencent . com" , kvm , Benjamin Herrenschmidt , Joao Martins , Will Deacon , kvmarm@lists.cs.columbia.edu, linux-s390@vger.kernel.org, Michael Ellerman , "joro @ 8bytes . org" , Huacai Chen , Christian Borntraeger , Aleksandar Markovic , karahmed@amazon.com, Catalin Marinas , Boris Ostrovsky , linux-arm-kernel , "jmattson @ google . com" , "mtosatti @ redhat . com" , linux-mips@vger.kernel.org, kvm-riscv@lists.infradead.org, Marc Zyngier , Paolo Bonzini , "vkuznets @ redhat . com" , linuxppc-dev@lists.ozlabs.org X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu T24gVHVlLCBOb3YgMTYsIDIwMjEsIERhdmlkIFdvb2Rob3VzZSB3cm90ZToKPiBGcm9tOiBEYXZp ZCBXb29kaG91c2UgPGR3bXdAYW1hem9uLmNvLnVrPgo+IAo+IEl0J3MgYWxsIGZhaXJseSBiYXJv cXVlIGJ1dCBpbiB0aGUgZW5kLCBJIGRvbid0IHRoaW5rIHRoZXJlJ3MgYW55IHJlYXNvbgo+IGZv ciAkKEtWTSkvaXJxY2hpcC5vIHRvIGhhdmUgYmVlbiBoYW5kbGVkIGRpZmZlcmVudGx5LCBhcyB0 aGV5IGFsbCBlbmQKPiB1cCBpbiAkKGt2bS15KSBpbiB0aGUgZW5kIGFueXdheSwgcmVnYXJkbGVz cyBvZiB3aGV0aGVyIHRoZXkgZ2V0IHRoZXJlCj4gdmlhICQoY29tbW9uLW9ianMteSkgYW5kIHRo ZSBDUFUtc3BlY2lmaWMgb2JqZWN0IGxpc3RzLgo+IAo+IFRoZSBnZW5lcmljIE1ha2VmaWxlLmt2 bSB1c2VzIEhBVkVfS1ZNX0lSUUNISVAgZm9yIGlycWNoaXAubyBpbnN0ZWFkIG9mCj4gSEFWRV9L Vk1fSVJRX1JPVVRJTkcuIFRoYXQgY2hhbmdlIGlzIGZpbmUgKGFuZCBhcmd1YWJseSBjb3JyZWN0 KSBiZWNhdXNlCj4gdGhleSBhcmUgYm90aCBzZXQgdG9nZXRoZXIgZm9yIEtWTV9NUElDLCBvciBu ZWl0aGVyIGlzIHNldC4KCk5vcGUuCgogIFN5bWJvbDogSEFWRV9LVk1fSVJRQ0hJUCBbPXldCiAg VHlwZSAgOiBib29sCiAgRGVmaW5lZCBhdCB2aXJ0L2t2bS9LY29uZmlnOjcKICBTZWxlY3RlZCBi eSBbbV06CiAgICAtIEtWTV9YSUNTIFs9eV0gJiYgVklSVFVBTElaQVRJT04gWz15XSAmJiBLVk1f Qk9PSzNTXzY0IFs9bV0gJiYgIUtWTV9NUElDIFs9bl0KICBTZWxlY3RlZCBieSBbbl06CiAgICAt IEtWTV9NUElDIFs9bl0gJiYgVklSVFVBTElaQVRJT04gWz15XSAmJiBLVk0gWz15XSAmJiBFNTAw IFs9bl0KCmxlYWRzIHRvIHRoaXMgYW5kIGEgd2hvbGUgcGlsZSBvZiBvdGhlciBlcnJvcnMKCmFy Y2gvcG93ZXJwYy9rdm0vLi4vLi4vLi4vdmlydC9rdm0vaXJxY2hpcC5jOiBJbiBmdW5jdGlvbiDi gJhrdm1faXJxX21hcF9nc2nigJk6CmFyY2gvcG93ZXJwYy9rdm0vLi4vLi4vLi4vdmlydC9rdm0v aXJxY2hpcC5jOjMxOjM1OiBlcnJvcjogaW52YWxpZCB1c2Ugb2YgdW5kZWZpbmVkIHR5cGUg4oCY c3RydWN0IGt2bV9pcnFfcm91dGluZ190YWJsZeKAmQogICAzMSB8ICAgICAgICAgaWYgKGlycV9y dCAmJiBnc2kgPCBpcnFfcnQtPm5yX3J0X2VudHJpZXMpIHsKICAgICAgfCAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgXn4KCgpTaWRlIHRvcGljLCBwbGVhc2UgZG9uJ3QgcG9zdCBh IG5ldyB2ZXJzaW9uL3NlcmllcyBpbi1yZXBseS10byBhIGRpZmZlcmVudCBzZXJpZXMuCmI0IGFs c28gZ2V0cyBjb25mdXNlZCBpbiB0aGlzIGNhc2UsIGUuZy4gaXQgdHJpZWQgdG8gZ3JhYiB0aGUg b3JpZ2luYWwgcGF0Y2guICBiNApoYXMgYWxzbyBtYWRlIG1lIHJlYWxseSBsYXp5LCBoZWF2ZW4g Zm9yYmlkIEkgYWN0dWFsbHkgaGFkIHRvIG1hbnVhbGx5IGdyYWIgdGhlc2UKZnJvbSBtdXR0IDot KQpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwprdm1hcm0g bWFpbGluZyBsaXN0Cmt2bWFybUBsaXN0cy5jcy5jb2x1bWJpYS5lZHUKaHR0cHM6Ly9saXN0cy5j cy5jb2x1bWJpYS5lZHUvbWFpbG1hbi9saXN0aW5mby9rdm1hcm0K From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 833FEC433EF for ; Tue, 16 Nov 2021 18:44:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 69E5361872 for ; Tue, 16 Nov 2021 18:44:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239611AbhKPSq5 (ORCPT ); Tue, 16 Nov 2021 13:46:57 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42462 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239604AbhKPSqz (ORCPT ); Tue, 16 Nov 2021 13:46:55 -0500 Received: from mail-pj1-x102b.google.com (mail-pj1-x102b.google.com [IPv6:2607:f8b0:4864:20::102b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4A04AC061764 for ; Tue, 16 Nov 2021 10:43:58 -0800 (PST) Received: by mail-pj1-x102b.google.com with SMTP id fv9-20020a17090b0e8900b001a6a5ab1392so237605pjb.1 for ; Tue, 16 Nov 2021 10:43:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=GcGOJgSWz7oEIbfl5QNUvPpuAyaNetXEQN0oWs9ap2w=; b=NfWEHKgpp9hvAVj4IrdvyWcutj+oRm5oA4DhrzE5j01yRw6SEr+OqI8zdgqPehlHuc lvLy/whsET41Ju6UmVvOInCo7Ww6t6yLH5qUrncwy6VAmxauCnt99O3r1yirLCVccCfN 0Gay6uTBhe2zfp68q3FXHdSVfO1Z/lBlR6uw3b9mZM9XbPEBfKBoCa/a9sEvB1P9oZqk 5YTcHvsnOOA5rsa3JP9041e/6BOvKA/Xr3X/sbaLIuC63lGrovFZ7b1eudI5InxTZkUr CdOzfVuUVUCDHbMPcWrZAb1YNJexcHENRayQEJiryVfwYQQPdJtpV9LDoK9LoF2MR12X 8enQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=GcGOJgSWz7oEIbfl5QNUvPpuAyaNetXEQN0oWs9ap2w=; b=GsZ9B1l29kpHjFz1LZNz1dKUO3JTH7wwTBTIrwQl6R4B8tsTm/7B+d1SGw7b5mCWp9 EqdH+bR1D7dzlY15rUPjuDijTPt7a23R7U+v/L0zuElu1guN1UXtsI9D+0JKEp7hiIQF d79lxmZRfotpfAwcnQsN1KL4kRk45Mv6/fvlzIeiO0vhPnDz/d0sBZxGDX83QL/YtAq2 SYdrIHr9fERRf70tDaU1S/1rRG4gtuO2T1slMIU2m2YcjUSyLCZXBbjQnafvMJ96YufM wvukgg4IaWwLDILktq5GHKcSiJ2+MnEJI0m/k68ojLpEOiiaNcX+dvQAMqueFIeAwcoU rerg== X-Gm-Message-State: AOAM533gn5BmaWzYFJ8DWJZ4u8r8ynvaSNTBopMajZTkMTbpvE0paHBy 86PApE9H609SYWhUC2mKi8WvYg== X-Google-Smtp-Source: ABdhPJy95F12FbARJJuG3RP+KItNypekR2/l+xifaD1kKSsYtJFW/+wQ/332xG0BY0Bxhx2ISOUtlQ== X-Received: by 2002:a17:90b:4b46:: with SMTP id mi6mr1449604pjb.188.1637088237573; Tue, 16 Nov 2021 10:43:57 -0800 (PST) Received: from google.com (157.214.185.35.bc.googleusercontent.com. [35.185.214.157]) by smtp.gmail.com with ESMTPSA id r8sm15237754pgp.30.2021.11.16.10.43.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Nov 2021 10:43:56 -0800 (PST) Date: Tue, 16 Nov 2021 18:43:53 +0000 From: Sean Christopherson To: David Woodhouse Cc: Paolo Bonzini , kvm , Boris Ostrovsky , Joao Martins , "jmattson @ google . com" , "wanpengli @ tencent . com" , "vkuznets @ redhat . com" , "mtosatti @ redhat . com" , "joro @ 8bytes . org" , karahmed@amazon.com, Marc Zyngier , James Morse , Alexandru Elisei , Suzuki K Poulose , Catalin Marinas , Will Deacon , Huacai Chen , Aleksandar Markovic , Michael Ellerman , Benjamin Herrenschmidt , Anup Patel , Christian Borntraeger , kvmarm@lists.cs.columbia.edu, linux-arm-kernel , linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm-riscv@lists.infradead.org, linux-s390@vger.kernel.org Subject: Re: [PATCH 6/7] KVM: powerpc: Use Makefile.kvm for common files Message-ID: References: <5047c2591310e503491850ef683f251395247d50.camel@infradead.org> <20211116115051.119956-1-dwmw2@infradead.org> <20211116115051.119956-6-dwmw2@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20211116115051.119956-6-dwmw2@infradead.org> Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org On Tue, Nov 16, 2021, David Woodhouse wrote: > From: David Woodhouse > > It's all fairly baroque but in the end, I don't think there's any reason > for $(KVM)/irqchip.o to have been handled differently, as they all end > up in $(kvm-y) in the end anyway, regardless of whether they get there > via $(common-objs-y) and the CPU-specific object lists. > > The generic Makefile.kvm uses HAVE_KVM_IRQCHIP for irqchip.o instead of > HAVE_KVM_IRQ_ROUTING. That change is fine (and arguably correct) because > they are both set together for KVM_MPIC, or neither is set. Nope. Symbol: HAVE_KVM_IRQCHIP [=y] Type : bool Defined at virt/kvm/Kconfig:7 Selected by [m]: - KVM_XICS [=y] && VIRTUALIZATION [=y] && KVM_BOOK3S_64 [=m] && !KVM_MPIC [=n] Selected by [n]: - KVM_MPIC [=n] && VIRTUALIZATION [=y] && KVM [=y] && E500 [=n] leads to this and a whole pile of other errors arch/powerpc/kvm/../../../virt/kvm/irqchip.c: In function ‘kvm_irq_map_gsi’: arch/powerpc/kvm/../../../virt/kvm/irqchip.c:31:35: error: invalid use of undefined type ‘struct kvm_irq_routing_table’ 31 | if (irq_rt && gsi < irq_rt->nr_rt_entries) { | ^~ Side topic, please don't post a new version/series in-reply-to a different series. b4 also gets confused in this case, e.g. it tried to grab the original patch. b4 has also made me really lazy, heaven forbid I actually had to manually grab these from mutt :-) From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5DD52C433FE for ; Tue, 16 Nov 2021 18:44:46 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A0E0B61ABD for ; Tue, 16 Nov 2021 18:44:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org A0E0B61ABD Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.ozlabs.org Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4Htw2z6Qgcz3058 for ; Wed, 17 Nov 2021 05:44:43 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20210112 header.b=NfWEHKgp; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=google.com (client-ip=2607:f8b0:4864:20::630; helo=mail-pl1-x630.google.com; envelope-from=seanjc@google.com; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20210112 header.b=NfWEHKgp; dkim-atps=neutral Received: from mail-pl1-x630.google.com (mail-pl1-x630.google.com [IPv6:2607:f8b0:4864:20::630]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4Htw2B6n5yz2xT9 for ; Wed, 17 Nov 2021 05:44:00 +1100 (AEDT) Received: by mail-pl1-x630.google.com with SMTP id t21so18199519plr.6 for ; Tue, 16 Nov 2021 10:44:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=GcGOJgSWz7oEIbfl5QNUvPpuAyaNetXEQN0oWs9ap2w=; b=NfWEHKgpp9hvAVj4IrdvyWcutj+oRm5oA4DhrzE5j01yRw6SEr+OqI8zdgqPehlHuc lvLy/whsET41Ju6UmVvOInCo7Ww6t6yLH5qUrncwy6VAmxauCnt99O3r1yirLCVccCfN 0Gay6uTBhe2zfp68q3FXHdSVfO1Z/lBlR6uw3b9mZM9XbPEBfKBoCa/a9sEvB1P9oZqk 5YTcHvsnOOA5rsa3JP9041e/6BOvKA/Xr3X/sbaLIuC63lGrovFZ7b1eudI5InxTZkUr CdOzfVuUVUCDHbMPcWrZAb1YNJexcHENRayQEJiryVfwYQQPdJtpV9LDoK9LoF2MR12X 8enQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=GcGOJgSWz7oEIbfl5QNUvPpuAyaNetXEQN0oWs9ap2w=; b=v50IbyINhE676Bxe5dVs/HaY16RzhAKl6b9YOQBEoKeQ0u9ACpkcDzgvIhJV1xz1gK +KTb39mi+ouDzLU1iYCisnQjC/ep2ba8qxlJirczBDQX8DdLUWkbUE06NUFAnd7tVAjx a6t/HfTSegCIpLgs33xgISeerwGFanOGPcHV2BEdp6jkJmw5lymGWxHKz02V7PT5urug GXV7ecicHKOeWd6rb5l4jHq28S6C+/m/ogCpgwvSjM3gSrntofpEC9vXlBk4ftfSYxlA UGX+lkKhj6k1v9M5xINobdQ6WPO/ahhYP9DyLDVxu21mSELGBLhsvU5SLRQ0qwWqimni MULw== X-Gm-Message-State: AOAM5316xfoPjsrz6gv/uuIkHFBWONEoVEL2U+tGBHvl0fqOM0o6Oy9v H7oBtZOtV4O37vpnh356WHjY3Q== X-Google-Smtp-Source: ABdhPJy95F12FbARJJuG3RP+KItNypekR2/l+xifaD1kKSsYtJFW/+wQ/332xG0BY0Bxhx2ISOUtlQ== X-Received: by 2002:a17:90b:4b46:: with SMTP id mi6mr1449604pjb.188.1637088237573; Tue, 16 Nov 2021 10:43:57 -0800 (PST) Received: from google.com (157.214.185.35.bc.googleusercontent.com. [35.185.214.157]) by smtp.gmail.com with ESMTPSA id r8sm15237754pgp.30.2021.11.16.10.43.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Nov 2021 10:43:56 -0800 (PST) Date: Tue, 16 Nov 2021 18:43:53 +0000 From: Sean Christopherson To: David Woodhouse Subject: Re: [PATCH 6/7] KVM: powerpc: Use Makefile.kvm for common files Message-ID: References: <5047c2591310e503491850ef683f251395247d50.camel@infradead.org> <20211116115051.119956-1-dwmw2@infradead.org> <20211116115051.119956-6-dwmw2@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20211116115051.119956-6-dwmw2@infradead.org> X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Anup Patel , "wanpengli @ tencent . com" , kvm , Joao Martins , Will Deacon , kvmarm@lists.cs.columbia.edu, linux-s390@vger.kernel.org, "joro @ 8bytes . org" , Huacai Chen , Christian Borntraeger , Aleksandar Markovic , karahmed@amazon.com, Catalin Marinas , Suzuki K Poulose , Boris Ostrovsky , Alexandru Elisei , linux-arm-kernel , "jmattson @ google . com" , "mtosatti @ redhat . com" , linux-mips@vger.kernel.org, James Morse , kvm-riscv@lists.infradead.org, Marc Zyngier , Paolo Bonzini , "vkuznets @ redhat . com" , linuxppc-dev@lists.ozlabs.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Tue, Nov 16, 2021, David Woodhouse wrote: > From: David Woodhouse > > It's all fairly baroque but in the end, I don't think there's any reason > for $(KVM)/irqchip.o to have been handled differently, as they all end > up in $(kvm-y) in the end anyway, regardless of whether they get there > via $(common-objs-y) and the CPU-specific object lists. > > The generic Makefile.kvm uses HAVE_KVM_IRQCHIP for irqchip.o instead of > HAVE_KVM_IRQ_ROUTING. That change is fine (and arguably correct) because > they are both set together for KVM_MPIC, or neither is set. Nope. Symbol: HAVE_KVM_IRQCHIP [=y] Type : bool Defined at virt/kvm/Kconfig:7 Selected by [m]: - KVM_XICS [=y] && VIRTUALIZATION [=y] && KVM_BOOK3S_64 [=m] && !KVM_MPIC [=n] Selected by [n]: - KVM_MPIC [=n] && VIRTUALIZATION [=y] && KVM [=y] && E500 [=n] leads to this and a whole pile of other errors arch/powerpc/kvm/../../../virt/kvm/irqchip.c: In function ‘kvm_irq_map_gsi’: arch/powerpc/kvm/../../../virt/kvm/irqchip.c:31:35: error: invalid use of undefined type ‘struct kvm_irq_routing_table’ 31 | if (irq_rt && gsi < irq_rt->nr_rt_entries) { | ^~ Side topic, please don't post a new version/series in-reply-to a different series. b4 also gets confused in this case, e.g. it tried to grab the original patch. b4 has also made me really lazy, heaven forbid I actually had to manually grab these from mutt :-) From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83EA0C433EF for ; Tue, 16 Nov 2021 18:45:30 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4EAA460EBD for ; Tue, 16 Nov 2021 18:45:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 4EAA460EBD Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=iLsYUlZydVWFf9y1sRCENvpEJWHMbg6ybmCt5v6UV2g=; b=DnEAkleqBhOXrN WvPtPKFBPjbtIgmABuKUR20RW0Nb001U8IInDZCbh7pHQoztYWY5ArB7AzNE3xfwdUPkgmhaSmVhk RFX/kieax2Tht/jYtpGSTPDEezbJOrW6mUt9silqDm+BWFytXm7FrhcKGmepI/qGrlWipoCavnOro x+clmzfKZ+fqtyv7kmPdMf43R2YnMgDXaiaW6EtxMc62M1LaU+7nAYuylGVbAvHa239jm53OCcEF0 CtCACuXvUbLkAstPPYi0ctOaloLxQ5M2DA3kiySOyBNm4zPbeDHb0iCasW0IQiF4Pz4fDKanqTwgS VgVoz/EsnI7utj9H88EA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mn3R4-002ahR-O4; Tue, 16 Nov 2021 18:44:03 +0000 Received: from mail-pj1-x1036.google.com ([2607:f8b0:4864:20::1036]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mn3R0-002ag2-TL for linux-arm-kernel@lists.infradead.org; Tue, 16 Nov 2021 18:44:00 +0000 Received: by mail-pj1-x1036.google.com with SMTP id fv9-20020a17090b0e8900b001a6a5ab1392so237604pjb.1 for ; Tue, 16 Nov 2021 10:43:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=GcGOJgSWz7oEIbfl5QNUvPpuAyaNetXEQN0oWs9ap2w=; b=NfWEHKgpp9hvAVj4IrdvyWcutj+oRm5oA4DhrzE5j01yRw6SEr+OqI8zdgqPehlHuc lvLy/whsET41Ju6UmVvOInCo7Ww6t6yLH5qUrncwy6VAmxauCnt99O3r1yirLCVccCfN 0Gay6uTBhe2zfp68q3FXHdSVfO1Z/lBlR6uw3b9mZM9XbPEBfKBoCa/a9sEvB1P9oZqk 5YTcHvsnOOA5rsa3JP9041e/6BOvKA/Xr3X/sbaLIuC63lGrovFZ7b1eudI5InxTZkUr CdOzfVuUVUCDHbMPcWrZAb1YNJexcHENRayQEJiryVfwYQQPdJtpV9LDoK9LoF2MR12X 8enQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=GcGOJgSWz7oEIbfl5QNUvPpuAyaNetXEQN0oWs9ap2w=; b=lGdZT/cppxfRDFcRZkAgyoyYBPZliCK3aQXVrtlvcuWXUd5JSPzbjq0SbVI6zXHDDz a/1fUqo9mukKFJ8yJk8z4/zEV1HPaaQilBTQ0ZMd5cJwZhNWh/4cruJT/69y+q7fGalE Xo87c2qfNIwwUzRywMIAeKtYPBWK5I72Fl7kgraSYtwC9MytmLwMCCeG/cj1Uy1RRHUW lvOUScSVte2KWVE1qFsY88e8e+VTggPO8ka+DYBbdSjpvTbGReHRZjWjN3htdA6Txd4g Q15kelqXjr5qoFY5J6AC/pmGtvbDVTXscBIF20yDaeiVDUaSpWU8exKBpmblNPMhR0vg BHtQ== X-Gm-Message-State: AOAM532Ohc3iQAtrR79SX7lO6upUA8esUVusP+5b8dCEd6/DfTM6ukjB cSPXXDJ4hqzuN/H6+g/QgKbyxA== X-Google-Smtp-Source: ABdhPJy95F12FbARJJuG3RP+KItNypekR2/l+xifaD1kKSsYtJFW/+wQ/332xG0BY0Bxhx2ISOUtlQ== X-Received: by 2002:a17:90b:4b46:: with SMTP id mi6mr1449604pjb.188.1637088237573; Tue, 16 Nov 2021 10:43:57 -0800 (PST) Received: from google.com (157.214.185.35.bc.googleusercontent.com. [35.185.214.157]) by smtp.gmail.com with ESMTPSA id r8sm15237754pgp.30.2021.11.16.10.43.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Nov 2021 10:43:56 -0800 (PST) Date: Tue, 16 Nov 2021 18:43:53 +0000 From: Sean Christopherson To: David Woodhouse Cc: Paolo Bonzini , kvm , Boris Ostrovsky , Joao Martins , "jmattson @ google . com" , "wanpengli @ tencent . com" , "vkuznets @ redhat . com" , "mtosatti @ redhat . com" , "joro @ 8bytes . org" , karahmed@amazon.com, Marc Zyngier , James Morse , Alexandru Elisei , Suzuki K Poulose , Catalin Marinas , Will Deacon , Huacai Chen , Aleksandar Markovic , Michael Ellerman , Benjamin Herrenschmidt , Anup Patel , Christian Borntraeger , kvmarm@lists.cs.columbia.edu, linux-arm-kernel , linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm-riscv@lists.infradead.org, linux-s390@vger.kernel.org Subject: Re: [PATCH 6/7] KVM: powerpc: Use Makefile.kvm for common files Message-ID: References: <5047c2591310e503491850ef683f251395247d50.camel@infradead.org> <20211116115051.119956-1-dwmw2@infradead.org> <20211116115051.119956-6-dwmw2@infradead.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20211116115051.119956-6-dwmw2@infradead.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211116_104358_958879_92C6F9C6 X-CRM114-Status: GOOD ( 16.27 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVHVlLCBOb3YgMTYsIDIwMjEsIERhdmlkIFdvb2Rob3VzZSB3cm90ZToKPiBGcm9tOiBEYXZp ZCBXb29kaG91c2UgPGR3bXdAYW1hem9uLmNvLnVrPgo+IAo+IEl0J3MgYWxsIGZhaXJseSBiYXJv cXVlIGJ1dCBpbiB0aGUgZW5kLCBJIGRvbid0IHRoaW5rIHRoZXJlJ3MgYW55IHJlYXNvbgo+IGZv ciAkKEtWTSkvaXJxY2hpcC5vIHRvIGhhdmUgYmVlbiBoYW5kbGVkIGRpZmZlcmVudGx5LCBhcyB0 aGV5IGFsbCBlbmQKPiB1cCBpbiAkKGt2bS15KSBpbiB0aGUgZW5kIGFueXdheSwgcmVnYXJkbGVz cyBvZiB3aGV0aGVyIHRoZXkgZ2V0IHRoZXJlCj4gdmlhICQoY29tbW9uLW9ianMteSkgYW5kIHRo ZSBDUFUtc3BlY2lmaWMgb2JqZWN0IGxpc3RzLgo+IAo+IFRoZSBnZW5lcmljIE1ha2VmaWxlLmt2 bSB1c2VzIEhBVkVfS1ZNX0lSUUNISVAgZm9yIGlycWNoaXAubyBpbnN0ZWFkIG9mCj4gSEFWRV9L Vk1fSVJRX1JPVVRJTkcuIFRoYXQgY2hhbmdlIGlzIGZpbmUgKGFuZCBhcmd1YWJseSBjb3JyZWN0 KSBiZWNhdXNlCj4gdGhleSBhcmUgYm90aCBzZXQgdG9nZXRoZXIgZm9yIEtWTV9NUElDLCBvciBu ZWl0aGVyIGlzIHNldC4KCk5vcGUuCgogIFN5bWJvbDogSEFWRV9LVk1fSVJRQ0hJUCBbPXldCiAg VHlwZSAgOiBib29sCiAgRGVmaW5lZCBhdCB2aXJ0L2t2bS9LY29uZmlnOjcKICBTZWxlY3RlZCBi eSBbbV06CiAgICAtIEtWTV9YSUNTIFs9eV0gJiYgVklSVFVBTElaQVRJT04gWz15XSAmJiBLVk1f Qk9PSzNTXzY0IFs9bV0gJiYgIUtWTV9NUElDIFs9bl0KICBTZWxlY3RlZCBieSBbbl06CiAgICAt IEtWTV9NUElDIFs9bl0gJiYgVklSVFVBTElaQVRJT04gWz15XSAmJiBLVk0gWz15XSAmJiBFNTAw IFs9bl0KCmxlYWRzIHRvIHRoaXMgYW5kIGEgd2hvbGUgcGlsZSBvZiBvdGhlciBlcnJvcnMKCmFy Y2gvcG93ZXJwYy9rdm0vLi4vLi4vLi4vdmlydC9rdm0vaXJxY2hpcC5jOiBJbiBmdW5jdGlvbiDi gJhrdm1faXJxX21hcF9nc2nigJk6CmFyY2gvcG93ZXJwYy9rdm0vLi4vLi4vLi4vdmlydC9rdm0v aXJxY2hpcC5jOjMxOjM1OiBlcnJvcjogaW52YWxpZCB1c2Ugb2YgdW5kZWZpbmVkIHR5cGUg4oCY c3RydWN0IGt2bV9pcnFfcm91dGluZ190YWJsZeKAmQogICAzMSB8ICAgICAgICAgaWYgKGlycV9y dCAmJiBnc2kgPCBpcnFfcnQtPm5yX3J0X2VudHJpZXMpIHsKICAgICAgfCAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgXn4KCgpTaWRlIHRvcGljLCBwbGVhc2UgZG9uJ3QgcG9zdCBh IG5ldyB2ZXJzaW9uL3NlcmllcyBpbi1yZXBseS10byBhIGRpZmZlcmVudCBzZXJpZXMuCmI0IGFs c28gZ2V0cyBjb25mdXNlZCBpbiB0aGlzIGNhc2UsIGUuZy4gaXQgdHJpZWQgdG8gZ3JhYiB0aGUg b3JpZ2luYWwgcGF0Y2guICBiNApoYXMgYWxzbyBtYWRlIG1lIHJlYWxseSBsYXp5LCBoZWF2ZW4g Zm9yYmlkIEkgYWN0dWFsbHkgaGFkIHRvIG1hbnVhbGx5IGdyYWIgdGhlc2UKZnJvbSBtdXR0IDot KQoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgt YXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQu b3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJt LWtlcm5lbAo=