From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41DC5C4332F for ; Tue, 16 Nov 2021 15:43:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 290EE60EE0 for ; Tue, 16 Nov 2021 15:43:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238524AbhKPPp7 (ORCPT ); Tue, 16 Nov 2021 10:45:59 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56792 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238554AbhKPPpT (ORCPT ); Tue, 16 Nov 2021 10:45:19 -0500 Received: from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com [IPv6:2a00:1450:4864:20::42a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 834E0C06120E for ; Tue, 16 Nov 2021 07:42:19 -0800 (PST) Received: by mail-wr1-x42a.google.com with SMTP id r8so38352107wra.7 for ; Tue, 16 Nov 2021 07:42:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=MaOSO/5HtReWKBBksqBOQJDhfTRE2n/pBGJORKYgmI8=; b=dpMihBVSiTIhJ8gwEIK/0RaxfyXs2DtvxfMOWHwvsfqgQpUny0lQtED0wIphEPCb6v AEzTzY5KUWh+ZBUlwhm1MKOSsfEKvWzAZN6hA0iVz1ZkNSHET0GNQ7X4qOZ4ru7PoXmg a/08/a6OGQp4ufg1hfyxfYLxOjuSPoP4Iv2indtDuuY25uHOzB4zY/j/Htu2gPPN48F8 +FDsCnukvP5bxxuyqV5df/R9Dld2m5MFGmv/6quqjj8jagtwmzBL49QLLLkaiJPMV3TB utBJFccrrLjAw31i2P+rtb2jHXojpAt5V88ehKxTw8pEyulGHnLBAJQgM7JuB/O0nT8J yzQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=MaOSO/5HtReWKBBksqBOQJDhfTRE2n/pBGJORKYgmI8=; b=j+7rDwA4J2bw/xKLcsvDcfRKQa7iLE551KTNxQxd6DE6JdNW5V43WVkT8r4+g4zZiZ 8huCVY5fc5I55fP9mumUu6AZCU1aFxFEJwUgN87GF8mL8RcIpnRC5sxkFsU2jqEsVPs7 YIJGP0PrlMMTAeZmO8CKsyEqL6btrYWSUY0O+bFdIfuo0KThmBOB3StEVDFlZmztMQZz CXC05G02qqCgVbiLiP+Z1fnYeGsmRno9ryTQzWQzR0B9FvAQCXPTisiNivNffRlQOsVF Y91QemrOUKrzUqTiSHOOnVJKz+3AuyZpdT3ChwIZKNYnmcqCPz3hExpxPt70LwGYQJ2P eouw== X-Gm-Message-State: AOAM532X0w6LlNQm7nbt66CXI6eP3JhloXSoC23kKXwHzDhR3vGSTWRB UitQPQ8wU4Jn/pBt6VDw+85Mxg== X-Google-Smtp-Source: ABdhPJwGazAeHXqWI2KmcXg8HN2YudpmutPJQ1rdklClDDMa6uJ9nc+mW3BEpIrYrJ5e6pEnv6kpCA== X-Received: by 2002:a5d:5303:: with SMTP id e3mr10447721wrv.73.1637077337983; Tue, 16 Nov 2021 07:42:17 -0800 (PST) Received: from google.com ([95.148.6.231]) by smtp.gmail.com with ESMTPSA id q4sm17892469wrs.56.2021.11.16.07.42.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Nov 2021 07:42:17 -0800 (PST) Date: Tue, 16 Nov 2021 15:42:15 +0000 From: Lee Jones To: Daniel Thompson Cc: phone-devel@vger.kernel.org, Andy Gross , Bjorn Andersson , Rob Herring , Marijn Suijten , Jingoo Han , ~postmarketos/upstreaming@lists.sr.ht, AngeloGioacchino Del Regno , Konrad Dybcio , Martin Botka , Jami Kettunen , Pavel Dubrova , Kiran Gunda , Bryan Wu , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org Subject: Re: [PATCH v3 0/9] backlight: qcom-wled: fix and solidify handling of enabled-strings Message-ID: References: <20211115203459.1634079-1-marijn.suijten@somainline.org> <20211116120213.n7qxqfi62lrxhyl7@maple.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20211116120213.n7qxqfi62lrxhyl7@maple.lan> Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Tue, 16 Nov 2021, Daniel Thompson wrote: > Hi Lee > > On Mon, Nov 15, 2021 at 09:34:50PM +0100, Marijn Suijten wrote: > > This patchset fixes WLED's handling of enabled-strings: besides some > > cleanup it is now actually possible to specify a non-contiguous array of > > enabled strings (not necessarily starting at zero) and the values from > > DT are now validated to prevent possible unexpected out-of-bounds > > register and array element accesses. > > Off-by-one mistakes in the maximum number of strings, also causing > > out-of-bounds access, have been addressed as well. > > They have arrived piecemeal (during v1, v2 and v3) but all patches on > the set should now have my R-b: attached to them. I can see that. Nothing for you to worry about. I'll apply these when I conduct my next sweep, thanks. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35B06C433F5 for ; Tue, 16 Nov 2021 15:42:22 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EFE3361502 for ; Tue, 16 Nov 2021 15:42:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org EFE3361502 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D37956E4C9; Tue, 16 Nov 2021 15:42:20 +0000 (UTC) Received: from mail-wr1-x433.google.com (mail-wr1-x433.google.com [IPv6:2a00:1450:4864:20::433]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8066E6E4C9 for ; Tue, 16 Nov 2021 15:42:19 +0000 (UTC) Received: by mail-wr1-x433.google.com with SMTP id s13so38492097wrb.3 for ; Tue, 16 Nov 2021 07:42:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=MaOSO/5HtReWKBBksqBOQJDhfTRE2n/pBGJORKYgmI8=; b=dpMihBVSiTIhJ8gwEIK/0RaxfyXs2DtvxfMOWHwvsfqgQpUny0lQtED0wIphEPCb6v AEzTzY5KUWh+ZBUlwhm1MKOSsfEKvWzAZN6hA0iVz1ZkNSHET0GNQ7X4qOZ4ru7PoXmg a/08/a6OGQp4ufg1hfyxfYLxOjuSPoP4Iv2indtDuuY25uHOzB4zY/j/Htu2gPPN48F8 +FDsCnukvP5bxxuyqV5df/R9Dld2m5MFGmv/6quqjj8jagtwmzBL49QLLLkaiJPMV3TB utBJFccrrLjAw31i2P+rtb2jHXojpAt5V88ehKxTw8pEyulGHnLBAJQgM7JuB/O0nT8J yzQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=MaOSO/5HtReWKBBksqBOQJDhfTRE2n/pBGJORKYgmI8=; b=lmD70lJrCeorFcJza2bWnWcKxqkqtQvFMx+ACSVTYssAPrUUYpRQatINtBbMoRpAUK wNwICIYnDwniVeUbW3czANP4WQClh8OZ7HyR2Nv+dfbjNrVu4hOyWMFanq/iK3mb4mKN s2v9IHf2hsXkhDMLFwnG6gZkiofpBNUez9Qu8AM8vaOejC+YTaavUVrmXQIo1tuADMaL xnAVqgscnMq76zekmi3gw8JI42T3xD9topM0UNMCn1wdljpkxo+0XmJyBnqJgwFBkuIA MLb+CHEj+WLJPFFSaoMA4+mB0/JlBt+kw9KHgZ6pzRfy+/bat9R8lDjI95vaH5B8xRCM F/Dg== X-Gm-Message-State: AOAM530B1LUAzgMwvYmUA6KTE5nyOLk82tba1emPblKcO0xfjRY6MP74 w2l+P+bQGtjszdRIDKvHiH+NDA== X-Google-Smtp-Source: ABdhPJwGazAeHXqWI2KmcXg8HN2YudpmutPJQ1rdklClDDMa6uJ9nc+mW3BEpIrYrJ5e6pEnv6kpCA== X-Received: by 2002:a5d:5303:: with SMTP id e3mr10447721wrv.73.1637077337983; Tue, 16 Nov 2021 07:42:17 -0800 (PST) Received: from google.com ([95.148.6.231]) by smtp.gmail.com with ESMTPSA id q4sm17892469wrs.56.2021.11.16.07.42.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Nov 2021 07:42:17 -0800 (PST) Date: Tue, 16 Nov 2021 15:42:15 +0000 From: Lee Jones To: Daniel Thompson Subject: Re: [PATCH v3 0/9] backlight: qcom-wled: fix and solidify handling of enabled-strings Message-ID: References: <20211115203459.1634079-1-marijn.suijten@somainline.org> <20211116120213.n7qxqfi62lrxhyl7@maple.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20211116120213.n7qxqfi62lrxhyl7@maple.lan> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-fbdev@vger.kernel.org, Kiran Gunda , Pavel Dubrova , Jami Kettunen , Jingoo Han , linux-arm-msm@vger.kernel.org, Bryan Wu , Konrad Dybcio , linux-kernel@vger.kernel.org, Rob Herring , Bjorn Andersson , Andy Gross , Martin Botka , ~postmarketos/upstreaming@lists.sr.ht, AngeloGioacchino Del Regno , Marijn Suijten , phone-devel@vger.kernel.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Tue, 16 Nov 2021, Daniel Thompson wrote: > Hi Lee > > On Mon, Nov 15, 2021 at 09:34:50PM +0100, Marijn Suijten wrote: > > This patchset fixes WLED's handling of enabled-strings: besides some > > cleanup it is now actually possible to specify a non-contiguous array of > > enabled strings (not necessarily starting at zero) and the values from > > DT are now validated to prevent possible unexpected out-of-bounds > > register and array element accesses. > > Off-by-one mistakes in the maximum number of strings, also causing > > out-of-bounds access, have been addressed as well. > > They have arrived piecemeal (during v1, v2 and v3) but all patches on > the set should now have my R-b: attached to them. I can see that. Nothing for you to worry about. I'll apply these when I conduct my next sweep, thanks. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog