From: Mark Brown <broonie@kernel.org>
To: Vinod Koul <vkoul@kernel.org>
Cc: Doug Anderson <dianders@chromium.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
linux-arm-msm@vger.kernel.org, Andy Gross <agross@kernel.org>,
Sumit Semwal <sumit.semwal@linaro.org>,
Matthias Kaehlcke <mka@chromium.org>,
linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5] spi: spi-geni-qcom: Add support for GPI dma
Date: Tue, 16 Nov 2021 16:41:10 +0000 [thread overview]
Message-ID: <YZPfJtkvo3bsfaCg@sirena.org.uk> (raw)
In-Reply-To: <YZPVB84Eq9Dn3Znv@matsya>
[-- Attachment #1: Type: text/plain, Size: 400 bytes --]
On Tue, Nov 16, 2021 at 09:27:59PM +0530, Vinod Koul wrote:
> On 03-11-21, 14:17, Doug Anderson wrote:
> > if (result->residue) {
> > dev_err(...);
> > return;
> > }
> > spi_finalize_current_transfer(...);
> Should we always call spi_finalize_current_transfer() ? This way we
> timeout... What is the way to signal error has occurred..?
Yes, set an error in the transfer and then finalize it.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2021-11-16 16:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-20 6:09 [PATCH v5] spi: spi-geni-qcom: Add support for GPI dma Vinod Koul
2021-10-29 21:01 ` Mark Brown
2021-11-03 21:17 ` Doug Anderson
2021-11-16 15:57 ` Vinod Koul
2021-11-16 16:41 ` Mark Brown [this message]
2021-11-17 4:34 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YZPfJtkvo3bsfaCg@sirena.org.uk \
--to=broonie@kernel.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=dianders@chromium.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=mka@chromium.org \
--cc=sumit.semwal@linaro.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.