From: Daniel Vetter <daniel@ffwll.ch>
To: Jani Nikula <jani.nikula@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH 5/5] drm/i915: drop intel_display.h include from intel_display_power.h
Date: Tue, 16 Nov 2021 18:56:05 +0100 [thread overview]
Message-ID: <YZPwtXx7o8jsB2N1@phenom.ffwll.local> (raw)
In-Reply-To: <20211116171434.20516-5-jani.nikula@intel.com>
On Tue, Nov 16, 2021 at 07:14:34PM +0200, Jani Nikula wrote:
> Use forward declarations instead.
>
> Cc: Imre Deak <imre.deak@intel.com>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
On the series: Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
I'm assuming you've copypaste stuff correctly, at a glance it looks like
it :-)
Also I think that's a solid direction for untangling our include mess!
-Daniel
> ---
> drivers/gpu/drm/i915/display/intel_display_power.h | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_display_power.h b/drivers/gpu/drm/i915/display/intel_display_power.h
> index 2777af09c711..686d18eaa24c 100644
> --- a/drivers/gpu/drm/i915/display/intel_display_power.h
> +++ b/drivers/gpu/drm/i915/display/intel_display_power.h
> @@ -6,10 +6,11 @@
> #ifndef __INTEL_DISPLAY_POWER_H__
> #define __INTEL_DISPLAY_POWER_H__
>
> -#include "intel_display.h"
> #include "intel_runtime_pm.h"
> #include "i915_reg.h"
>
> +enum dpio_channel;
> +enum dpio_phy;
> struct drm_i915_private;
> struct i915_power_well;
> struct intel_encoder;
> --
> 2.30.2
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
next prev parent reply other threads:[~2021-11-16 17:56 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-16 17:14 [Intel-gfx] [PATCH 1/5] drm/i915: drop intel_display.h include from intel_ddi.h Jani Nikula
2021-11-16 17:14 ` [Intel-gfx] [PATCH 2/5] drm/i915: drop intel_display.h include from intel_dpll_mgr.h Jani Nikula
2021-11-16 17:14 ` [Intel-gfx] [PATCH 3/5] drm/i915/debugfs: move debug printing to intel_display_power.c Jani Nikula
2021-11-16 17:14 ` [Intel-gfx] [PATCH 4/5] drm/i915: move structs from intel_display_power.h to .c Jani Nikula
2021-11-16 17:14 ` [Intel-gfx] [PATCH 5/5] drm/i915: drop intel_display.h include from intel_display_power.h Jani Nikula
2021-11-16 17:56 ` Daniel Vetter [this message]
2021-11-19 13:52 ` Jani Nikula
2021-11-16 19:34 ` [Intel-gfx] [PATCH 1/5] drm/i915: drop intel_display.h include from intel_ddi.h Imre Deak
2021-11-17 0:43 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/5] " Patchwork
2021-11-17 1:14 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2021-11-17 12:03 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/5] drm/i915: drop intel_display.h include from intel_ddi.h (rev2) Patchwork
2021-11-17 12:29 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2021-11-18 16:41 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/5] drm/i915: drop intel_display.h include from intel_ddi.h (rev4) Patchwork
2021-11-18 17:09 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2021-11-19 7:18 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YZPwtXx7o8jsB2N1@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.