From: Andrew Lunn <andrew@lunn.ch>
To: Gerhard Engleder <gerhard@engleder-embedded.com>
Cc: David Miller <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next v5 3/3] tsnep: Add TSN endpoint Ethernet MAC driver
Date: Wed, 17 Nov 2021 00:41:04 +0100 [thread overview]
Message-ID: <YZRBkMsOhKB7nFW1@lunn.ch> (raw)
In-Reply-To: <CANr-f5y339dz5Q2Qazw_6-q81dXma=fEPQMm2Qfk78AjvhG=7Q@mail.gmail.com>
> > > diff --git a/drivers/net/ethernet/engleder/tsnep_test.c b/drivers/net/ethernet/engleder/tsnep_test.c
> >
> > You have quite a lot of code in this file. Could it either be
> >
> > 1) A loadable module which extends the base driver?
> > 2) A build time configuration option?
> >
> > What percentage of the overall driver binary does this test code take
> > up?
>
> Driver is 484kB with test code and 396kB without. So test code is roughly
> 20% currently. In my opinion a configuration option makes more sense,
Yes, that is good, please add one.
Andrew
next prev parent reply other threads:[~2021-11-16 23:41 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-15 20:50 [PATCH net-next v5 0/3] TSN endpoint Ethernet MAC driver Gerhard Engleder
2021-11-15 20:50 ` [PATCH net-next v5 1/3] dt-bindings: Add vendor prefix for Engleder Gerhard Engleder
2021-11-15 22:24 ` Andrew Lunn
2021-11-15 20:50 ` [PATCH net-next v5 2/3] dt-bindings: net: Add tsnep Ethernet controller Gerhard Engleder
2021-11-15 22:25 ` Andrew Lunn
2021-11-15 20:50 ` [PATCH net-next v5 3/3] tsnep: Add TSN endpoint Ethernet MAC driver Gerhard Engleder
2021-11-15 22:21 ` Heiner Kallweit
2021-11-16 21:47 ` Gerhard Engleder
2021-11-15 23:04 ` Andrew Lunn
2021-11-16 22:16 ` Gerhard Engleder
2021-11-16 23:41 ` Andrew Lunn [this message]
2021-11-18 17:31 ` kernel test robot
2021-11-18 17:31 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YZRBkMsOhKB7nFW1@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=gerhard@engleder-embedded.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.