From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B6328C433EF for ; Wed, 17 Nov 2021 08:36:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 960266321B for ; Wed, 17 Nov 2021 08:36:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232453AbhKQIjQ (ORCPT ); Wed, 17 Nov 2021 03:39:16 -0500 Received: from muru.com ([72.249.23.125]:57144 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232473AbhKQIjM (ORCPT ); Wed, 17 Nov 2021 03:39:12 -0500 Received: from localhost (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 76A3680F0; Wed, 17 Nov 2021 08:36:51 +0000 (UTC) Date: Wed, 17 Nov 2021 10:36:12 +0200 From: Tony Lindgren To: Ard Biesheuvel Cc: "Russell King (Oracle)" , Guillaume Tucker , linux-omap , Linux ARM , Nicolas Pitre , Arnd Bergmann , Kees Cook , Keith Packard , Linus Walleij , Nick Desaulniers , "kernelci@groups.io" Subject: Re: [PATCH v3 7/7] ARM: implement support for vmap'ed stacks Message-ID: References: <20211115111816.3911213-1-ardb@kernel.org> <20211115111816.3911213-8-ardb@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org * Ard Biesheuvel [211117 08:29]: > On Wed, 17 Nov 2021 at 08:59, Tony Lindgren wrote: > > > > * Ard Biesheuvel [211116 22:03]: > > > Of course, I may have missed something, but I wouldn't expect a > > > fundamental flaw in this logic to affect only OMAP3/4 based platforms > > > in such a weird way. Perhaps there is something I missed in terms of > > > TLB maintenance, although I would expect the existing fault handler to > > > take care of that. > > > > Looks like disabling the deeper idle states for cpuidle where the CPUSs > > get shut down and restored seems to work around the issue at least for > > omap4. The assembly code is in arch/arm/mach-omap2/sleep44xx.S, and in > > sleep34xx.S for omap3. No idea so far what might be causing this.. > > > > Thanks Tony, that is very helpful. I have a Beaglebone white somewhere > so I'll try and reproduce it locally as well. I think with Beaglebone you may hit this only with suspend/resume if at all. On am335x cpuidle is not shutting down the CPU. And only some models will suspend to deeper idle states as it depends on the PMIC. If you have some test patch to try, just let me know. Regards, Tony From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9D8CBC433EF for ; Wed, 17 Nov 2021 08:37:40 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5FA9261BF9 for ; Wed, 17 Nov 2021 08:37:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 5FA9261BF9 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=atomide.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=HxF2tDHH4waFMoL4UoLULxdSndLkAWAVq0xThNejvXA=; b=q/UR7w9cU02WJr yfWut8oFiSEJHK4RqmAWgq55R0j+qUnEhuRbfsW6jELYOYNNlSr2tekHUAiGwD6LzBcntdDZqPrLr hHJ0eArlNBdTT3CGxVoNWRSg4yEkpNe+LY7mPAPSUrgZVLinl3FxEP7fV+zxhk4NQEszBM19krDaU fg35nc42uIDmDyW//dAiVmLVBkT4MXBps7k7nt9Mbm8M5IqF2V5JPNpDad6ANGqh55VWDnyUPnp0R pKjiIEYhJhueqiUJ4ID5UGVX7b0O68yUdZCYiofqsgtSuWSi21RKmwj4PCuS3b9wW5JnGFw374A5c yKpTUAFMsWbqU+WnO/cw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mnGQU-003y8K-6W; Wed, 17 Nov 2021 08:36:18 +0000 Received: from muru.com ([72.249.23.125]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mnGQQ-003y74-AY for linux-arm-kernel@lists.infradead.org; Wed, 17 Nov 2021 08:36:15 +0000 Received: from localhost (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 76A3680F0; Wed, 17 Nov 2021 08:36:51 +0000 (UTC) Date: Wed, 17 Nov 2021 10:36:12 +0200 From: Tony Lindgren To: Ard Biesheuvel Cc: "Russell King (Oracle)" , Guillaume Tucker , linux-omap , Linux ARM , Nicolas Pitre , Arnd Bergmann , Kees Cook , Keith Packard , Linus Walleij , Nick Desaulniers , "kernelci@groups.io" Subject: Re: [PATCH v3 7/7] ARM: implement support for vmap'ed stacks Message-ID: References: <20211115111816.3911213-1-ardb@kernel.org> <20211115111816.3911213-8-ardb@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211117_003614_448100_372E7794 X-CRM114-Status: GOOD ( 18.35 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org * Ard Biesheuvel [211117 08:29]: > On Wed, 17 Nov 2021 at 08:59, Tony Lindgren wrote: > > > > * Ard Biesheuvel [211116 22:03]: > > > Of course, I may have missed something, but I wouldn't expect a > > > fundamental flaw in this logic to affect only OMAP3/4 based platforms > > > in such a weird way. Perhaps there is something I missed in terms of > > > TLB maintenance, although I would expect the existing fault handler to > > > take care of that. > > > > Looks like disabling the deeper idle states for cpuidle where the CPUSs > > get shut down and restored seems to work around the issue at least for > > omap4. The assembly code is in arch/arm/mach-omap2/sleep44xx.S, and in > > sleep34xx.S for omap3. No idea so far what might be causing this.. > > > > Thanks Tony, that is very helpful. I have a Beaglebone white somewhere > so I'll try and reproduce it locally as well. I think with Beaglebone you may hit this only with suspend/resume if at all. On am335x cpuidle is not shutting down the CPU. And only some models will suspend to deeper idle states as it depends on the PMIC. If you have some test patch to try, just let me know. Regards, Tony _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel