From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sean Christopherson Date: Thu, 18 Nov 2021 18:40:47 +0000 Subject: [PATCH v3 08/12] KVM: Propagate vcpu explicitly to mark_page_dirty_in_slot() In-Reply-To: <20b5952e76c54a3a5dfe5a898e3b835404ac6fb1.camel@infradead.org> References: <20211117174003.297096-1-dwmw2@infradead.org> <20211117174003.297096-9-dwmw2@infradead.org> <85d9fec17f32c3eb9e100e56b91af050.squirrel@twosheds.infradead.org> <4c48546b-eb4a-dff7-cc38-5df54f73f5d4@redhat.com> <20b5952e76c54a3a5dfe5a898e3b835404ac6fb1.camel@infradead.org> Message-ID: List-Id: To: kvm-riscv@lists.infradead.org MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Thu, Nov 18, 2021, David Woodhouse wrote: > That leaves the one in TDP MMU handle_changed_spte_dirty_log() which > AFAICT can trigger the same crash seen by butt3rflyh4ck ? can't that > happen from a thread where kvm_get_running_vcpu() is NULL too? For that > one I'm not sure. I think could be trigger in the TDP MMU via kvm_mmu_notifier_release() -> kvm_mmu_zap_all(), e.g. if the userspace VMM exits while dirty logging is enabled. That should be easy to (dis)prove via a selftest. And for the record :-) On Mon, Dec 02, 2019 at 12:10:36PM -0800, Sean Christopherson wrote: > IMO, adding kvm_get_running_vcpu() is a hack that is just asking for future > abuse and the vcpu/vm/as_id interactions in mark_page_dirty_in_ring() > look extremely fragile. On 03/12/19 20:01, Sean Christopherson wrote: > In case it was clear, I strongly dislike adding kvm_get_running_vcpu(). > IMO, it's a unnecessary hack. The proper change to ensure a valid vCPU is > seen by mark_page_dirty_in_ring() when there is a current vCPU is to > plumb the vCPU down through the various call stacks. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA341C433F5 for ; Thu, 18 Nov 2021 18:40:57 +0000 (UTC) Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by mail.kernel.org (Postfix) with ESMTP id 4D52B61AA3 for ; Thu, 18 Nov 2021 18:40:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 4D52B61AA3 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.cs.columbia.edu Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id C1DE84B17D; Thu, 18 Nov 2021 13:40:56 -0500 (EST) X-Virus-Scanned: at lists.cs.columbia.edu Authentication-Results: mm01.cs.columbia.edu (amavisd-new); dkim=softfail (fail, message has been altered) header.i=@google.com Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id BbsB93YL5+jt; Thu, 18 Nov 2021 13:40:55 -0500 (EST) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id ABC584ACC9; Thu, 18 Nov 2021 13:40:55 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id EB6864ACC9 for ; Thu, 18 Nov 2021 13:40:53 -0500 (EST) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 6RykxuhN-Yxk for ; Thu, 18 Nov 2021 13:40:52 -0500 (EST) Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id 99DEA4A4BE for ; Thu, 18 Nov 2021 13:40:52 -0500 (EST) Received: by mail-pl1-f175.google.com with SMTP id q17so6004361plr.11 for ; Thu, 18 Nov 2021 10:40:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=grrMnij3a2kLK2nD9/+zi8H0lxQV5j7EQVRD7AIwS2E=; b=DnjI9osT+moWRQdwwunhhgYe2YGuzWKrQy5JwjvEJNUqQcpvnb0WoX5Pei6uXI5OdC 7eGLhv3YIzk62P6sC5D7JBPnUohj6O7s664U/+jqNIv857J2ijyYc9lxkutY0si+1Jso ztfH/9rMsVdRRal+62dCEzvALKr3rtl5XahGBeHA8m4ynGczBHkUGlN7RYWuUfQGcFke WSfMnan0Kg6M9yWEVCFKWFu1Oy/he0ioyfZD1myK/YDRWIUpBN/5hc73yoNPRxPOyT9C VLzYMyPNfdN9orn15Wn6MlOWGc4Qs8aD/O0pRMiPP4mF4KE17PRSHz5sCFRZguQ3AWZA KcTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=grrMnij3a2kLK2nD9/+zi8H0lxQV5j7EQVRD7AIwS2E=; b=rhpB6k1LEjUfiOGjb/5Ur5xt7rqE1nKTxrLAEVIo5/bnjN7YqQIZyEQG29RvHZbWba p8WqVF71Qs82mL+O8dUmrUH58Mzd9g3AZ41iBR6YKsZOhYAKJ7Ph6OSFu5Cudzxx3qJd igpKV6JgfDe9eXepRlTqJ0irq5vpuzgOfMEB0rwCsiwytAvG9alWZh9ksMbeq6UhfdYo CNo6TTvoGKDU5sLcR0gdWnPx9e6G1cIsj/kZzh97l88T+dAZ76ULyTBYiwggdkWi5aou HoYHCMX6rvY9ynwXrvJRwT8P16LkC//xNvWs8wiC8nCJ6vo9brwn5UrZPqq/UPrNHeTn 2bBA== X-Gm-Message-State: AOAM533RD+nYdC602JY/xmemh2uQdMHeiZH3829jLAMXDZg1+fXzviqr O0yFHhYcvlSI6YKL07EvvA5pbQ== X-Google-Smtp-Source: ABdhPJxTT+sS2hBA2CisuiyQO1bWgOM4L3odX2TF09Y4yJcQHjhUg5+FNsR41T/1dQnqfraxxzIiPQ== X-Received: by 2002:a17:90a:af94:: with SMTP id w20mr12506911pjq.223.1637260851435; Thu, 18 Nov 2021 10:40:51 -0800 (PST) Received: from google.com (157.214.185.35.bc.googleusercontent.com. [35.185.214.157]) by smtp.gmail.com with ESMTPSA id a12sm8600266pjq.16.2021.11.18.10.40.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Nov 2021 10:40:50 -0800 (PST) Date: Thu, 18 Nov 2021 18:40:47 +0000 From: Sean Christopherson To: David Woodhouse Subject: Re: [PATCH v3 08/12] KVM: Propagate vcpu explicitly to mark_page_dirty_in_slot() Message-ID: References: <20211117174003.297096-1-dwmw2@infradead.org> <20211117174003.297096-9-dwmw2@infradead.org> <85d9fec17f32c3eb9e100e56b91af050.squirrel@twosheds.infradead.org> <4c48546b-eb4a-dff7-cc38-5df54f73f5d4@redhat.com> <20b5952e76c54a3a5dfe5a898e3b835404ac6fb1.camel@infradead.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20b5952e76c54a3a5dfe5a898e3b835404ac6fb1.camel@infradead.org> Cc: Anup Patel , "wanpengli @ tencent . com" , kvm , Benjamin Herrenschmidt , Joao Martins , Will Deacon , kvmarm@lists.cs.columbia.edu, linux-s390@vger.kernel.org, Michael Ellerman , "joro @ 8bytes . org" , Huacai Chen , Christian Borntraeger , Aleksandar Markovic , karahmed@amazon.com, Catalin Marinas , Boris Ostrovsky , linux-arm-kernel , "jmattson @ google . com" , "mtosatti @ redhat . com" , linux-mips@vger.kernel.org, kvm-riscv@lists.infradead.org, Marc Zyngier , Paolo Bonzini , "vkuznets @ redhat . com" , linuxppc-dev@lists.ozlabs.org X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu T24gVGh1LCBOb3YgMTgsIDIwMjEsIERhdmlkIFdvb2Rob3VzZSB3cm90ZToKPiBUaGF0IGxlYXZl cyB0aGUgb25lIGluIFREUCBNTVUgaGFuZGxlX2NoYW5nZWRfc3B0ZV9kaXJ0eV9sb2coKSB3aGlj aAo+IEFGQUlDVCBjYW4gdHJpZ2dlciB0aGUgc2FtZSBjcmFzaCBzZWVuIGJ5IGJ1dHQzcmZseWg0 Y2sg4oCUIGNhbid0IHRoYXQKPiBoYXBwZW4gZnJvbSBhIHRocmVhZCB3aGVyZSBrdm1fZ2V0X3J1 bm5pbmdfdmNwdSgpIGlzIE5VTEwgdG9vPyBGb3IgdGhhdAo+IG9uZSBJJ20gbm90IHN1cmUuCgpJ IHRoaW5rIGNvdWxkIGJlIHRyaWdnZXIgaW4gdGhlIFREUCBNTVUgdmlhIGt2bV9tbXVfbm90aWZp ZXJfcmVsZWFzZSgpCi0+IGt2bV9tbXVfemFwX2FsbCgpLCBlLmcuIGlmIHRoZSB1c2Vyc3BhY2Ug Vk1NIGV4aXRzIHdoaWxlIGRpcnR5IGxvZ2dpbmcgaXMKZW5hYmxlZC4gIFRoYXQgc2hvdWxkIGJl IGVhc3kgdG8gKGRpcylwcm92ZSB2aWEgYSBzZWxmdGVzdC4KCkFuZCBmb3IgdGhlIHJlY29yZCA6 LSkKCk9uIE1vbiwgRGVjIDAyLCAyMDE5IGF0IDEyOjEwOjM2UE0gLTA4MDAsIFNlYW4gQ2hyaXN0 b3BoZXJzb24gd3JvdGU6Cj4gSU1PLCBhZGRpbmcga3ZtX2dldF9ydW5uaW5nX3ZjcHUoKSBpcyBh IGhhY2sgdGhhdCBpcyBqdXN0IGFza2luZyBmb3IgZnV0dXJlCj4gYWJ1c2UgYW5kIHRoZSB2Y3B1 L3ZtL2FzX2lkIGludGVyYWN0aW9ucyBpbiBtYXJrX3BhZ2VfZGlydHlfaW5fcmluZygpCj4gbG9v ayBleHRyZW1lbHkgZnJhZ2lsZS4KCk9uIDAzLzEyLzE5IDIwOjAxLCBTZWFuIENocmlzdG9waGVy c29uIHdyb3RlOgo+IEluIGNhc2UgaXQgd2FzIGNsZWFyLCBJIHN0cm9uZ2x5IGRpc2xpa2UgYWRk aW5nIGt2bV9nZXRfcnVubmluZ192Y3B1KCkuCj4gSU1PLCBpdCdzIGEgdW5uZWNlc3NhcnkgaGFj ay4gIFRoZSBwcm9wZXIgY2hhbmdlIHRvIGVuc3VyZSBhIHZhbGlkIHZDUFUgaXMKPiBzZWVuIGJ5 IG1hcmtfcGFnZV9kaXJ0eV9pbl9yaW5nKCkgd2hlbiB0aGVyZSBpcyBhIGN1cnJlbnQgdkNQVSBp cyB0bwo+IHBsdW1iIHRoZSB2Q1BVIGRvd24gdGhyb3VnaCB0aGUgdmFyaW91cyBjYWxsIHN0YWNr cy4KX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18Ka3ZtYXJt IG1haWxpbmcgbGlzdAprdm1hcm1AbGlzdHMuY3MuY29sdW1iaWEuZWR1Cmh0dHBzOi8vbGlzdHMu Y3MuY29sdW1iaWEuZWR1L21haWxtYW4vbGlzdGluZm8va3ZtYXJtCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 147F7C433EF for ; Thu, 18 Nov 2021 18:40:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F214361A38 for ; Thu, 18 Nov 2021 18:40:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231429AbhKRSnw (ORCPT ); Thu, 18 Nov 2021 13:43:52 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46086 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229662AbhKRSnw (ORCPT ); Thu, 18 Nov 2021 13:43:52 -0500 Received: from mail-pl1-x631.google.com (mail-pl1-x631.google.com [IPv6:2607:f8b0:4864:20::631]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 236E0C061748 for ; Thu, 18 Nov 2021 10:40:52 -0800 (PST) Received: by mail-pl1-x631.google.com with SMTP id u17so6024001plg.9 for ; Thu, 18 Nov 2021 10:40:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=grrMnij3a2kLK2nD9/+zi8H0lxQV5j7EQVRD7AIwS2E=; b=DnjI9osT+moWRQdwwunhhgYe2YGuzWKrQy5JwjvEJNUqQcpvnb0WoX5Pei6uXI5OdC 7eGLhv3YIzk62P6sC5D7JBPnUohj6O7s664U/+jqNIv857J2ijyYc9lxkutY0si+1Jso ztfH/9rMsVdRRal+62dCEzvALKr3rtl5XahGBeHA8m4ynGczBHkUGlN7RYWuUfQGcFke WSfMnan0Kg6M9yWEVCFKWFu1Oy/he0ioyfZD1myK/YDRWIUpBN/5hc73yoNPRxPOyT9C VLzYMyPNfdN9orn15Wn6MlOWGc4Qs8aD/O0pRMiPP4mF4KE17PRSHz5sCFRZguQ3AWZA KcTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=grrMnij3a2kLK2nD9/+zi8H0lxQV5j7EQVRD7AIwS2E=; b=o8yszLEA3PEpv797sn6XZ3bAh/zjbAAgPClzJBAJeIvHxx3vZw5xGexuDQqww+BXsm dr5ppTeb0bZlnkJWmMTxGHWpO3tBeu2AS6rTjCiwi4OxsyW0eAc4fP/tWUmkL+kEZrhn NUFKmLOnTOhijtkp/d+eYaIJJ22TgPo7u8VNBH9WJIuyF1kQVq6tM7IbnkP0lAiFZ/cm aGK2B9uJsMrc013lDyiaYEdUnyW5wArCc9J3cT+UUbuLUQj5D7u6fMfjFwziUHMsxL55 ap4sEUqw/f4bpN724FR/Ip3q28hu3hjKGBOEBy9epwD3BSFyRpkRnXQFjowk1xvX0KaF B0dg== X-Gm-Message-State: AOAM5328BOp/GHPW7SQ6NGJCGQJAsVGyE7/+ICCngYkdBzHHoZL1bwU2 O21nQNEqBns5cebxavhKAJwUMQ== X-Google-Smtp-Source: ABdhPJxTT+sS2hBA2CisuiyQO1bWgOM4L3odX2TF09Y4yJcQHjhUg5+FNsR41T/1dQnqfraxxzIiPQ== X-Received: by 2002:a17:90a:af94:: with SMTP id w20mr12506911pjq.223.1637260851435; Thu, 18 Nov 2021 10:40:51 -0800 (PST) Received: from google.com (157.214.185.35.bc.googleusercontent.com. [35.185.214.157]) by smtp.gmail.com with ESMTPSA id a12sm8600266pjq.16.2021.11.18.10.40.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Nov 2021 10:40:50 -0800 (PST) Date: Thu, 18 Nov 2021 18:40:47 +0000 From: Sean Christopherson To: David Woodhouse Cc: Paolo Bonzini , kvm , Boris Ostrovsky , Joao Martins , "jmattson @ google . com" , "wanpengli @ tencent . com" , "vkuznets @ redhat . com" , "mtosatti @ redhat . com" , "joro @ 8bytes . org" , karahmed@amazon.com, Marc Zyngier , James Morse , Alexandru Elisei , Suzuki K Poulose , Catalin Marinas , Will Deacon , Huacai Chen , Aleksandar Markovic , Michael Ellerman , Benjamin Herrenschmidt , Anup Patel , Christian Borntraeger , kvmarm@lists.cs.columbia.edu, linux-arm-kernel , linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm-riscv@lists.infradead.org, linux-s390@vger.kernel.org Subject: Re: [PATCH v3 08/12] KVM: Propagate vcpu explicitly to mark_page_dirty_in_slot() Message-ID: References: <20211117174003.297096-1-dwmw2@infradead.org> <20211117174003.297096-9-dwmw2@infradead.org> <85d9fec17f32c3eb9e100e56b91af050.squirrel@twosheds.infradead.org> <4c48546b-eb4a-dff7-cc38-5df54f73f5d4@redhat.com> <20b5952e76c54a3a5dfe5a898e3b835404ac6fb1.camel@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20b5952e76c54a3a5dfe5a898e3b835404ac6fb1.camel@infradead.org> Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org On Thu, Nov 18, 2021, David Woodhouse wrote: > That leaves the one in TDP MMU handle_changed_spte_dirty_log() which > AFAICT can trigger the same crash seen by butt3rflyh4ck — can't that > happen from a thread where kvm_get_running_vcpu() is NULL too? For that > one I'm not sure. I think could be trigger in the TDP MMU via kvm_mmu_notifier_release() -> kvm_mmu_zap_all(), e.g. if the userspace VMM exits while dirty logging is enabled. That should be easy to (dis)prove via a selftest. And for the record :-) On Mon, Dec 02, 2019 at 12:10:36PM -0800, Sean Christopherson wrote: > IMO, adding kvm_get_running_vcpu() is a hack that is just asking for future > abuse and the vcpu/vm/as_id interactions in mark_page_dirty_in_ring() > look extremely fragile. On 03/12/19 20:01, Sean Christopherson wrote: > In case it was clear, I strongly dislike adding kvm_get_running_vcpu(). > IMO, it's a unnecessary hack. The proper change to ensure a valid vCPU is > seen by mark_page_dirty_in_ring() when there is a current vCPU is to > plumb the vCPU down through the various call stacks. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C3DBC4332F for ; Thu, 18 Nov 2021 18:41:41 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 50DF761A09 for ; Thu, 18 Nov 2021 18:41:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 50DF761A09 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.ozlabs.org Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4Hw7tV5vBLz3bjB for ; Fri, 19 Nov 2021 05:41:38 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20210112 header.b=DnjI9osT; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=google.com (client-ip=2607:f8b0:4864:20::62b; helo=mail-pl1-x62b.google.com; envelope-from=seanjc@google.com; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20210112 header.b=DnjI9osT; dkim-atps=neutral Received: from mail-pl1-x62b.google.com (mail-pl1-x62b.google.com [IPv6:2607:f8b0:4864:20::62b]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4Hw7sj45Thz2ymq for ; Fri, 19 Nov 2021 05:40:55 +1100 (AEDT) Received: by mail-pl1-x62b.google.com with SMTP id z6so4830483plk.6 for ; Thu, 18 Nov 2021 10:40:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=grrMnij3a2kLK2nD9/+zi8H0lxQV5j7EQVRD7AIwS2E=; b=DnjI9osT+moWRQdwwunhhgYe2YGuzWKrQy5JwjvEJNUqQcpvnb0WoX5Pei6uXI5OdC 7eGLhv3YIzk62P6sC5D7JBPnUohj6O7s664U/+jqNIv857J2ijyYc9lxkutY0si+1Jso ztfH/9rMsVdRRal+62dCEzvALKr3rtl5XahGBeHA8m4ynGczBHkUGlN7RYWuUfQGcFke WSfMnan0Kg6M9yWEVCFKWFu1Oy/he0ioyfZD1myK/YDRWIUpBN/5hc73yoNPRxPOyT9C VLzYMyPNfdN9orn15Wn6MlOWGc4Qs8aD/O0pRMiPP4mF4KE17PRSHz5sCFRZguQ3AWZA KcTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=grrMnij3a2kLK2nD9/+zi8H0lxQV5j7EQVRD7AIwS2E=; b=4qPS4YP8/KQ3/ZvTxP1RhgyfvRHAm7i42FdqHHSqrJaPDE98rb1GbrvqjLomy0wLvU +BJCBkMynpjCnf09pjBa6NscOBMIOULTADi/GsKc8QWjbbyt4Vr0BTMor0bUEFmxejlV lqFAMBjNVFvpA8HUGknfvHl/TBqz8CH9rKVFuHjlaBfIsXK6X6Cs4M8Yk8AJNAKzQR7O wOXpqddF/RAZohnuhfmD841Q3aMGQ4h8h/mxNLepsu1oWch///mMy0oi9EzAOjy8jCgD x9+sbB+hhnazJmlztZEtKHTy99cnvp+QsPK9WaC1KdnExJsspZpscKAYTGI/JI02Y3R2 9z2w== X-Gm-Message-State: AOAM531uaAHDRGESB7lm2M9dNRwwZX5iJ89U2AUfoTtysNQw/5uHrtvi oRPYi6vqdsIXVa6LpVBd9Q1zqw== X-Google-Smtp-Source: ABdhPJxTT+sS2hBA2CisuiyQO1bWgOM4L3odX2TF09Y4yJcQHjhUg5+FNsR41T/1dQnqfraxxzIiPQ== X-Received: by 2002:a17:90a:af94:: with SMTP id w20mr12506911pjq.223.1637260851435; Thu, 18 Nov 2021 10:40:51 -0800 (PST) Received: from google.com (157.214.185.35.bc.googleusercontent.com. [35.185.214.157]) by smtp.gmail.com with ESMTPSA id a12sm8600266pjq.16.2021.11.18.10.40.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Nov 2021 10:40:50 -0800 (PST) Date: Thu, 18 Nov 2021 18:40:47 +0000 From: Sean Christopherson To: David Woodhouse Subject: Re: [PATCH v3 08/12] KVM: Propagate vcpu explicitly to mark_page_dirty_in_slot() Message-ID: References: <20211117174003.297096-1-dwmw2@infradead.org> <20211117174003.297096-9-dwmw2@infradead.org> <85d9fec17f32c3eb9e100e56b91af050.squirrel@twosheds.infradead.org> <4c48546b-eb4a-dff7-cc38-5df54f73f5d4@redhat.com> <20b5952e76c54a3a5dfe5a898e3b835404ac6fb1.camel@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20b5952e76c54a3a5dfe5a898e3b835404ac6fb1.camel@infradead.org> X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Anup Patel , "wanpengli @ tencent . com" , kvm , Joao Martins , Will Deacon , kvmarm@lists.cs.columbia.edu, linux-s390@vger.kernel.org, "joro @ 8bytes . org" , Huacai Chen , Christian Borntraeger , Aleksandar Markovic , karahmed@amazon.com, Catalin Marinas , Suzuki K Poulose , Boris Ostrovsky , Alexandru Elisei , linux-arm-kernel , "jmattson @ google . com" , "mtosatti @ redhat . com" , linux-mips@vger.kernel.org, James Morse , kvm-riscv@lists.infradead.org, Marc Zyngier , Paolo Bonzini , "vkuznets @ redhat . com" , linuxppc-dev@lists.ozlabs.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Thu, Nov 18, 2021, David Woodhouse wrote: > That leaves the one in TDP MMU handle_changed_spte_dirty_log() which > AFAICT can trigger the same crash seen by butt3rflyh4ck — can't that > happen from a thread where kvm_get_running_vcpu() is NULL too? For that > one I'm not sure. I think could be trigger in the TDP MMU via kvm_mmu_notifier_release() -> kvm_mmu_zap_all(), e.g. if the userspace VMM exits while dirty logging is enabled. That should be easy to (dis)prove via a selftest. And for the record :-) On Mon, Dec 02, 2019 at 12:10:36PM -0800, Sean Christopherson wrote: > IMO, adding kvm_get_running_vcpu() is a hack that is just asking for future > abuse and the vcpu/vm/as_id interactions in mark_page_dirty_in_ring() > look extremely fragile. On 03/12/19 20:01, Sean Christopherson wrote: > In case it was clear, I strongly dislike adding kvm_get_running_vcpu(). > IMO, it's a unnecessary hack. The proper change to ensure a valid vCPU is > seen by mark_page_dirty_in_ring() when there is a current vCPU is to > plumb the vCPU down through the various call stacks. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85AD1C433F5 for ; Thu, 18 Nov 2021 18:42:38 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4CD1B61A38 for ; Thu, 18 Nov 2021 18:42:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 4CD1B61A38 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=SdUGGSFbt4DoJ6e7UiT+c7LJ3ROjIuWQ2Plfu5mihVs=; b=mVxihMDWvX7Oz1 gsUnN6tEZI3zVgC9FIqKPO1PTPvmMAmXbxkZ7SMjLKiA9Cny02cHxImzmbQJ1QbciK3yWPcegd3Qk Rg81UyCcTzyqjQgmceGyTyZblShP2MMbZ593Gbjh1S35WEPO4PvqBsT2GFdw4HsLyMc3B6IBH6CKY zfd8vmWGZgoqW924phKlO9qStxCz2MZQhNw0fwe02d5566YzBzq2z4VF7pz6cjwWWKzpssjXtbwd5 9vifVZ87CmtdCJdUZl3mbFx+yEySP7b+9jS1c2oSpVeSQiD1eH08Y632Vxzxyp7FOfKrvJ9mIlOzK LkBS3aoT2smHbfh4DOQg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mnmLC-008bfX-04; Thu, 18 Nov 2021 18:40:58 +0000 Received: from mail-pl1-x62b.google.com ([2607:f8b0:4864:20::62b]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mnmL6-008bdG-Qu for linux-arm-kernel@lists.infradead.org; Thu, 18 Nov 2021 18:40:54 +0000 Received: by mail-pl1-x62b.google.com with SMTP id k4so6004841plx.8 for ; Thu, 18 Nov 2021 10:40:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=grrMnij3a2kLK2nD9/+zi8H0lxQV5j7EQVRD7AIwS2E=; b=DnjI9osT+moWRQdwwunhhgYe2YGuzWKrQy5JwjvEJNUqQcpvnb0WoX5Pei6uXI5OdC 7eGLhv3YIzk62P6sC5D7JBPnUohj6O7s664U/+jqNIv857J2ijyYc9lxkutY0si+1Jso ztfH/9rMsVdRRal+62dCEzvALKr3rtl5XahGBeHA8m4ynGczBHkUGlN7RYWuUfQGcFke WSfMnan0Kg6M9yWEVCFKWFu1Oy/he0ioyfZD1myK/YDRWIUpBN/5hc73yoNPRxPOyT9C VLzYMyPNfdN9orn15Wn6MlOWGc4Qs8aD/O0pRMiPP4mF4KE17PRSHz5sCFRZguQ3AWZA KcTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=grrMnij3a2kLK2nD9/+zi8H0lxQV5j7EQVRD7AIwS2E=; b=rKcgK3aJpWhW9HgwTiSeqjRP4zUxKlgbuNPNofewrYC4+APVv3ctIiNBKdOZnx6l/7 MLwZ8wyPo49TtR+blVBXUQBgdyyI9BaiDgsih5YThkZMJpuiijJe1n/nz/WFfCNKgrzc 3XlcNd4FwbhniT7TMz7JwJxmH+h6VuBENakej4cKkDQLaKdGcyqV+fu2nGbvRcPOf9Nw qjiLTel9h2m5L9IhJr425NQ/FfOG/V0FjspG/hhkzu9/MfZCN1l8VcxeQA0O7UR4AKI/ 1m70iVpgedNLyuLu6wLYwaoNBBz2p6C6qLTso/7y14p+2E5Xp6R42SOppfTe+hvNMSj2 O21A== X-Gm-Message-State: AOAM5309oe/TvJQBcwH6Vpf9TLNGDvKxnjJk2Jnwx8aZNC0bnnGV1R4v HsaI4f3L4S9MP+A9vb+hovSPfw== X-Google-Smtp-Source: ABdhPJxTT+sS2hBA2CisuiyQO1bWgOM4L3odX2TF09Y4yJcQHjhUg5+FNsR41T/1dQnqfraxxzIiPQ== X-Received: by 2002:a17:90a:af94:: with SMTP id w20mr12506911pjq.223.1637260851435; Thu, 18 Nov 2021 10:40:51 -0800 (PST) Received: from google.com (157.214.185.35.bc.googleusercontent.com. [35.185.214.157]) by smtp.gmail.com with ESMTPSA id a12sm8600266pjq.16.2021.11.18.10.40.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Nov 2021 10:40:50 -0800 (PST) Date: Thu, 18 Nov 2021 18:40:47 +0000 From: Sean Christopherson To: David Woodhouse Cc: Paolo Bonzini , kvm , Boris Ostrovsky , Joao Martins , "jmattson @ google . com" , "wanpengli @ tencent . com" , "vkuznets @ redhat . com" , "mtosatti @ redhat . com" , "joro @ 8bytes . org" , karahmed@amazon.com, Marc Zyngier , James Morse , Alexandru Elisei , Suzuki K Poulose , Catalin Marinas , Will Deacon , Huacai Chen , Aleksandar Markovic , Michael Ellerman , Benjamin Herrenschmidt , Anup Patel , Christian Borntraeger , kvmarm@lists.cs.columbia.edu, linux-arm-kernel , linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm-riscv@lists.infradead.org, linux-s390@vger.kernel.org Subject: Re: [PATCH v3 08/12] KVM: Propagate vcpu explicitly to mark_page_dirty_in_slot() Message-ID: References: <20211117174003.297096-1-dwmw2@infradead.org> <20211117174003.297096-9-dwmw2@infradead.org> <85d9fec17f32c3eb9e100e56b91af050.squirrel@twosheds.infradead.org> <4c48546b-eb4a-dff7-cc38-5df54f73f5d4@redhat.com> <20b5952e76c54a3a5dfe5a898e3b835404ac6fb1.camel@infradead.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20b5952e76c54a3a5dfe5a898e3b835404ac6fb1.camel@infradead.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211118_104052_931275_ADDC260D X-CRM114-Status: GOOD ( 15.32 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVGh1LCBOb3YgMTgsIDIwMjEsIERhdmlkIFdvb2Rob3VzZSB3cm90ZToKPiBUaGF0IGxlYXZl cyB0aGUgb25lIGluIFREUCBNTVUgaGFuZGxlX2NoYW5nZWRfc3B0ZV9kaXJ0eV9sb2coKSB3aGlj aAo+IEFGQUlDVCBjYW4gdHJpZ2dlciB0aGUgc2FtZSBjcmFzaCBzZWVuIGJ5IGJ1dHQzcmZseWg0 Y2sg4oCUIGNhbid0IHRoYXQKPiBoYXBwZW4gZnJvbSBhIHRocmVhZCB3aGVyZSBrdm1fZ2V0X3J1 bm5pbmdfdmNwdSgpIGlzIE5VTEwgdG9vPyBGb3IgdGhhdAo+IG9uZSBJJ20gbm90IHN1cmUuCgpJ IHRoaW5rIGNvdWxkIGJlIHRyaWdnZXIgaW4gdGhlIFREUCBNTVUgdmlhIGt2bV9tbXVfbm90aWZp ZXJfcmVsZWFzZSgpCi0+IGt2bV9tbXVfemFwX2FsbCgpLCBlLmcuIGlmIHRoZSB1c2Vyc3BhY2Ug Vk1NIGV4aXRzIHdoaWxlIGRpcnR5IGxvZ2dpbmcgaXMKZW5hYmxlZC4gIFRoYXQgc2hvdWxkIGJl IGVhc3kgdG8gKGRpcylwcm92ZSB2aWEgYSBzZWxmdGVzdC4KCkFuZCBmb3IgdGhlIHJlY29yZCA6 LSkKCk9uIE1vbiwgRGVjIDAyLCAyMDE5IGF0IDEyOjEwOjM2UE0gLTA4MDAsIFNlYW4gQ2hyaXN0 b3BoZXJzb24gd3JvdGU6Cj4gSU1PLCBhZGRpbmcga3ZtX2dldF9ydW5uaW5nX3ZjcHUoKSBpcyBh IGhhY2sgdGhhdCBpcyBqdXN0IGFza2luZyBmb3IgZnV0dXJlCj4gYWJ1c2UgYW5kIHRoZSB2Y3B1 L3ZtL2FzX2lkIGludGVyYWN0aW9ucyBpbiBtYXJrX3BhZ2VfZGlydHlfaW5fcmluZygpCj4gbG9v ayBleHRyZW1lbHkgZnJhZ2lsZS4KCk9uIDAzLzEyLzE5IDIwOjAxLCBTZWFuIENocmlzdG9waGVy c29uIHdyb3RlOgo+IEluIGNhc2UgaXQgd2FzIGNsZWFyLCBJIHN0cm9uZ2x5IGRpc2xpa2UgYWRk aW5nIGt2bV9nZXRfcnVubmluZ192Y3B1KCkuCj4gSU1PLCBpdCdzIGEgdW5uZWNlc3NhcnkgaGFj ay4gIFRoZSBwcm9wZXIgY2hhbmdlIHRvIGVuc3VyZSBhIHZhbGlkIHZDUFUgaXMKPiBzZWVuIGJ5 IG1hcmtfcGFnZV9kaXJ0eV9pbl9yaW5nKCkgd2hlbiB0aGVyZSBpcyBhIGN1cnJlbnQgdkNQVSBp cyB0bwo+IHBsdW1iIHRoZSB2Q1BVIGRvd24gdGhyb3VnaCB0aGUgdmFyaW91cyBjYWxsIHN0YWNr cy4KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4 LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFk Lm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFy bS1rZXJuZWwK