From: Matthew Wilcox <willy@infradead.org>
To: Christophe Vu-Brugier <cvubrugier@fastmail.fm>
Cc: linux-fsdevel@vger.kernel.org,
Namjae Jeon <linkinjeon@kernel.org>,
Sungjong Seo <sj1557.seo@samsung.com>,
Christophe Vu-Brugier <christophe.vu-brugier@seagate.com>
Subject: Re: [PATCH 1/1] exfat: fix i_blocks for files truncated over 4 GiB
Date: Thu, 18 Nov 2021 21:50:25 +0000 [thread overview]
Message-ID: <YZbKobiUUt6eG6zQ@casper.infradead.org> (raw)
In-Reply-To: <20211118212828.4360-2-cvubrugier@fastmail.fm>
On Thu, Nov 18, 2021 at 10:28:28PM +0100, Christophe Vu-Brugier wrote:
> inode->i_blocks = ((i_size_read(inode) + (sbi->cluster_size - 1)) &
> - ~(sbi->cluster_size - 1)) >> inode->i_blkbits;
> + ~((loff_t)sbi->cluster_size - 1)) >> inode->i_blkbits;
Isn't this a convoluted way to write:
inode->i_blocks = round_up(i_size_read(inode), sbi->cluster_size) >>
inode->i_blkbits;
?
next prev parent reply other threads:[~2021-11-18 21:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-18 21:28 [PATCH 0/1] exfat: fix i_blocks for files truncated over 4 GiB Christophe Vu-Brugier
2021-11-18 21:28 ` [PATCH 1/1] " Christophe Vu-Brugier
2021-11-18 21:50 ` Matthew Wilcox [this message]
2021-11-18 22:43 ` Christophe Vu-Brugier
2021-11-19 17:37 ` [PATCH v2] " Christophe Vu-Brugier
2021-11-22 2:10 ` Sungjong Seo
2021-11-22 2:33 ` Namjae Jeon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YZbKobiUUt6eG6zQ@casper.infradead.org \
--to=willy@infradead.org \
--cc=christophe.vu-brugier@seagate.com \
--cc=cvubrugier@fastmail.fm \
--cc=linkinjeon@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=sj1557.seo@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.