From: Greg KH <gregkh@linuxfoundation.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: helgaas@kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH v4.14y - v5.14y] PCI/MSI: Destroy sysfs before freeing entries
Date: Fri, 19 Nov 2021 15:03:32 +0100 [thread overview]
Message-ID: <YZeutF6uD+IaryNu@kroah.com> (raw)
In-Reply-To: <87fsrx6whk.ffs@tglx>
On Mon, Nov 15, 2021 at 08:37:43PM +0100, Thomas Gleixner wrote:
> Commit 3735459037114d31e5acd9894fad9aed104231a0 uptream
>
> free_msi_irqs() frees the MSI entries before destroying the sysfs entries
> which are exposing them. Nothing prevents a concurrent free while a sysfs
> file is read and accesses the possibly freed entry.
>
> Move the sysfs release ahead of freeing the entries.
>
> Fixes: 1c51b50c2995 ("PCI/MSI: Export MSI mode using attributes, not kobjects")
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: stable@vger.kernel.org
> Link: https://lore.kernel.org/r/87sfw5305m.ffs@tglx
> ---
> Backport applies to 4.14.y up to 5.14.y series
All now queued up, thanks.
greg k-h
prev parent reply other threads:[~2021-11-19 14:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-15 12:41 FAILED: patch "[PATCH] PCI/MSI: Destroy sysfs before freeing entries" failed to apply to 5.14-stable tree gregkh
2021-11-15 19:37 ` [PATCH v4.14y - v5.14y] PCI/MSI: Destroy sysfs before freeing entries Thomas Gleixner
2021-11-19 14:03 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YZeutF6uD+IaryNu@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=helgaas@kernel.org \
--cc=stable@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.