From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A75FCC433F5 for ; Fri, 19 Nov 2021 16:01:19 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 666A761A58 for ; Fri, 19 Nov 2021 16:01:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 666A761A58 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 831056EDAA; Fri, 19 Nov 2021 16:01:18 +0000 (UTC) Received: from mail-ed1-x52d.google.com (mail-ed1-x52d.google.com [IPv6:2a00:1450:4864:20::52d]) by gabe.freedesktop.org (Postfix) with ESMTPS id 339C66EDA4 for ; Fri, 19 Nov 2021 16:01:18 +0000 (UTC) Received: by mail-ed1-x52d.google.com with SMTP id t5so44933004edd.0 for ; Fri, 19 Nov 2021 08:01:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=4bmmiqGFVF3c4eOLSe06WVhfiqWVoidcMplPIJMDdLE=; b=LS2IPJuvNBDKJboKgPO56rYiI2Hfr4RIPNQ8vCKNbwmgOIATKEW6dlYREu3Jvo5kaZ lbelMOMgaTc2/+sTmPQ2Mzc2+0IUDhXmQtzoe+wFzcIBG0sasY2oEsaWqo54qeuaEMvT 6H6ywSYwgugBI5SV8iLR2G2Wcli6j3fxX0xm4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=4bmmiqGFVF3c4eOLSe06WVhfiqWVoidcMplPIJMDdLE=; b=gbjLSjfZUUjcmM7FjVP3bQ04tjWj4Y1MZDTMZxp2ba3mrXAONMVtZd5LQthP5XgJPS Eo6dr052YTowxWMq5Cz3DZkwt2kQhxaObibJ8w176N5iBav4Vt18HwKUmtm3GgyzjXmq 4wzRh6DNHNRZNxHn5QLIjdvJYebhDC957xTdaumbdX3NRWEUuLXNa9k444ngf/pP/4VL TBhzkpU2JqAinJ4DmK3Cv86UF6RVx4tPTMHGivg9wf1m/Ms7VmvzMcl1lha6wpqBVavM HmRU55kdJH6PSaShMk0eCUtFUASSORO45/68L6YexP2ZnhI687CdgNE+YGxmeu/Ecbbe +e4w== X-Gm-Message-State: AOAM531nKKBWATGdAcDUbgYjY6KieCSMRXeF/EfBI8X/wdVNFsA9g+h6 +jdJdydF0OKufoY40kdYagSryg== X-Google-Smtp-Source: ABdhPJwYo18PBweJM60UMYbXxcXsunbW0J1lw381vnpaCzB0Pvli7+WDEngfJ4ZIXDP9jtIfAKx7bQ== X-Received: by 2002:a05:6402:268d:: with SMTP id w13mr26718762edd.257.1637337676691; Fri, 19 Nov 2021 08:01:16 -0800 (PST) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id u16sm118094ejy.16.2021.11.19.08.01.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Nov 2021 08:01:15 -0800 (PST) Date: Fri, 19 Nov 2021 17:01:14 +0100 From: Daniel Vetter To: Maxime Ripard Subject: Re: [PATCH v2 00/13] drm: Add generic helpers for HDMI scrambling Message-ID: References: <20211118103814.524670-1-maxime@cerno.tech> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211118103814.524670-1-maxime@cerno.tech> X-Operating-System: Linux phenom 5.10.0-8-amd64 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Dom Cobley , Tim Gover , Dave Stevenson , David Airlie , dri-devel@lists.freedesktop.org, Thomas Zimmermann , Daniel Vetter , Phil Elwell Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Thu, Nov 18, 2021 at 11:38:01AM +0100, Maxime Ripard wrote: > Hi, > > This is a follow-up of the work to support the interactions between the hotplug > and the scrambling support for vc4: > > https://lore.kernel.org/dri-devel/20210507150515.257424-11-maxime@cerno.tech/ > https://lore.kernel.org/dri-devel/20211025152903.1088803-10-maxime@cerno.tech/ > > Ville feedback was that the same discussion happened some time ago for i915, > and resulted in a function to do an full disable/enable cycle on reconnection > to avoid breaking the HDMI 2.0 spec. > > This series improves the current scrambling support by adding generic helpers > for usual scrambling-related operations, and builds upon them to provide a > generic alternative to intel_hdmi_reset_link. Out of curiosity, can we rebuild intel_hdmi_reset_link on top of these? Always better to have two drivers to actually show the helpers help, than just one. -Daniel > > Let me know what you think, > Maxime > > Changes from v1: > - Dropped the 340MHz define > - Make drm_mode_hdmi_requires_scrambling use the bpc > - Make more drm_display_mode const in vc4 > - Dropped the tegra conversion > - Added more comments > > Maxime Ripard (13): > drm/connector: Add helper to check if a mode requires scrambling > drm/atomic: Add HDMI scrambler state helper > drm/atomic: Add HDMI reset link helper > drm/scdc: Document hotplug gotchas > drm/vc4: hdmi: Constify drm_display_mode > drm/vc4: hdmi: Remove unused argument in vc4_hdmi_supports_scrambling > drm/vc4: hdmi: Remove mutex in detect > drm/vc4: hdmi: Remove HDMI flag from encoder > drm/vc4: hdmi: Simplify the hotplug handling > drm/vc4: hdmi: Simplify the connector state retrieval > drm/vc4: hdmi: Switch to detect_ctx > drm/vc4: hdmi: Leverage new SCDC atomic_check > drm/vc4: hdmi: Reset link on hotplug > > drivers/gpu/drm/drm_atomic_helper.c | 109 +++++++++ > drivers/gpu/drm/drm_atomic_state_helper.c | 58 +++++ > drivers/gpu/drm/drm_scdc_helper.c | 13 ++ > drivers/gpu/drm/vc4/vc4_hdmi.c | 257 ++++++++++------------ > drivers/gpu/drm/vc4/vc4_hdmi.h | 19 +- > include/drm/drm_atomic_helper.h | 3 + > include/drm/drm_atomic_state_helper.h | 3 + > include/drm/drm_connector.h | 25 +++ > include/drm/drm_modes.h | 20 ++ > 9 files changed, 353 insertions(+), 154 deletions(-) > > -- > 2.33.1 > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch