From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 31162C433EF for ; Mon, 22 Nov 2021 19:55:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=cr3SoMD+dfUgw0I1Qt9fhwtD3PJ0ltpluGDoBuf27e8=; b=r/yUriERNXWG4r TwWe3QhoQuYY3mToz0u7b6Do8/xHd73kgZcpXCTMz7gQ9QcH1lnx2qRtAIiVcBf1fWUz6ub9ADMyv OxgzZnc8ZILtAfjC8s6ujaeMW/LcUhVpN14qnvVJoaf3NyY6TWzT68FaEcqeln4QrfOdcs+/sj700 pT5m8SCxlhS3KxkyudH85Wi/cvIAXINGrAWThY0XmRFaFhMMtTRS4f084547QlkfgU1ZJdTC5c1oG Ga5T8a12eF+AOvxyh4H2tDWev8TrdfM0hfy53N992rFYwWKY1C78i00EnvsEPBKaIgOFPGsCwfX8U aeZkfl2WRiNAIFhE5eVg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mpFOB-00HV40-H4; Mon, 22 Nov 2021 19:54:07 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mpFO7-00HV2f-Uq for linux-arm-kernel@lists.infradead.org; Mon, 22 Nov 2021 19:54:06 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=KdZmRcc3t+prr1s7+hSrGjqXoixJomYlrH7C4x4Wvhk=; b=HC/R7sKScVNcLXHvCwjx2WD97d JWsW/Co+TC7xT7JyHfLebl4AMhkemUz2OnbnTTCmwI8kqKh5R81C6guICkw+NZBSp6DYNbBt4pN0Z ImwT8MxDNiiD+FMA1cDNJtssA4gyZnJ+kDx+FQ5+qcnE1kU3/F6INSjaDSbjgBLYIENA7tCvZ5ASq VtKVT442vmTKA7x2NYAknc3SxtCnD3La5RIBSACdC6KZh8PV9TXiHiM3emH7FJZcr21KoOmRPfNep qjbDwamRhY3jS2dY+Rxzmmk0bYEpOPQQHuwIKSujt5OQRV+1Lz2HBu+VKHKwrXm9GvvF0KHa/1g2I CLjY0r7g==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:55800) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1mpFNs-00074Z-O1; Mon, 22 Nov 2021 19:53:48 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1mpFNo-0007xa-7a; Mon, 22 Nov 2021 19:53:44 +0000 Date: Mon, 22 Nov 2021 19:53:44 +0000 From: "Russell King (Oracle)" To: Jordan Vrtanoski , stable@vger.kernel.org Cc: mw@semihalf.com, linux-arm-kernel@lists.infradead.org, stefanc@marvell.com Subject: Re: ClearFog GT 8K not initialising SFP-H10GB-CU1M transceiver on 5.4.150 Message-ID: References: <3AB36F18-250C-46F5-8135-94C79102B8A5@gmail.com> <256509AE-EE75-40AF-882F-F84A55F98C2D@gmail.com> <2F6C75BF-6CD8-4A58-B8AA-4D3A6B5A1008@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <2F6C75BF-6CD8-4A58-B8AA-4D3A6B5A1008@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211122_115404_018447_3C23789F X-CRM114-Status: GOOD ( 11.98 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gTW9uLCBOb3YgMjIsIDIwMjEgYXQgMDI6NTE6MzZQTSArMDQwMCwgSm9yZGFuIFZydGFub3Nr aSB3cm90ZToKPiBIaSwKPiAgICAgQWZ0ZXIgYmlzZWN0aW5nLCB0aGUgcmVncmVzc2lvbiBkZWZl Y3Qgd2FzIGludHJvZHVjZWQgaW4gNS40LjkwIHdpdGggdGhlIGZvbGxvd2luZyBwYXRjaDoKPiAi W1BBVENIIG5ldCB2M10gbmV0OiBtdnBwMjogZGlzYWJsZSBmb3JjZSBsaW5rIFVQIGR1cmluZyBw b3J0IGluaXQgcHJvY2VkdXJl4oCdCj4gCj4gICAgIFRoZSBwYXRjaCBpcyBjaGFuZ2luZyB0aGUg Y29uZmlndXJhdGlvbiBvZiB0aGUgcG9ydCBkdXJpbmcgdGhlIGluaXRpYWxpc2F0aW9uIG9mIE1W UFAyMl9YTEdfQ1RSTDBfUkVHLCB3aGljaAo+IG9uIENsZWFyRm9nIEdUIDhLIGlzIHByZXZlbnRp bmcgdGhlIE1WUFAyIHRvIHByb3Blcmx5IHN0YXJ0IHRoZSBNQUMgYWZ0ZXIgdGhlIHRyYW5zY2Vp dmVyIGlzIGRldGVjdGVkLiBBZnRlciByZXZlcnRpbmcgCj4gdGhlIHBhdGNoLCB0aGUgdHJhbnNj ZWl2ZXIgd29ya3MgcHJvcGVybHkuCgpSaWdodCwgdGhlIHByb2JsZW0gd2lsbCBiZSA4NzUwODIy NDQ4NTMgKCJuZXQ6IG12cHAyOiBkaXNhYmxlIGZvcmNlCmxpbmsgVVAgZHVyaW5nIHBvcnQgaW5p dCBwcm9jZWR1cmUiKSB0aGF0IGhhcyBiZWVuIGJhY2twb3J0ZWQgdG8Ka2VybmVscyB0aGF0IGl0 IHNob3VsZG4ndCBoYXZlIGJlZW4gYXBwbGllZCB0by4KClRoZXJlIGlzIGEgc3VidGxlIGludGVy YWN0aW9uIGJldHdlZW4gdGhhdCBjb21taXQgYW5kIGRldmVsb3BtZW50IHdvcmsKbGVhZGluZyB1 cCB0byBpdCB0aGF0IHdhc24ndCBvYnZpb3VzIGR1cmluZyB0aGUgcmV2aWV3LiBTcGVjaWZpY2Fs bHksCmFueSBrZXJuZWwgd2l0aG91dCBmZWZlYWU3M2FjN2EgKCJuZXQ6IG12cHAyOiBlbnN1cmUg dGhlIHBvcnQgaXMgZm9yY2VkCmRvd24gd2hpbGUgY2hhbmdpbmcgbW9kZXMiKSB3aWxsIG5vdyBi ZSBicm9rZW4uCgpIb3dldmVyLCBmZWZlYWU3M2FjN2EgaXMgZGV2ZWxvcG1lbnQgd29yaywgYW5k IHNvIGNhbid0IGJlIGJhY2twb3J0ZWQuCgpBZGRpbmcgc3RhYmxlIHRvIHRoaXMgdGhyZWFkIHNv IHRoZXkncmUgYXdhcmUgb2YgdGhlIGlzc3VlLgoKLS0gClJNSydzIFBhdGNoIHN5c3RlbTogaHR0 cHM6Ly93d3cuYXJtbGludXgub3JnLnVrL2RldmVsb3Blci9wYXRjaGVzLwpGVFRQIGlzIGhlcmUh IDQwTWJwcyBkb3duIDEwTWJwcyB1cC4gRGVjZW50IGNvbm5lY3Rpdml0eSBhdCBsYXN0IQoKX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtl cm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0 dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5l bAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4945EC433FE for ; Mon, 22 Nov 2021 19:54:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240303AbhKVT5H (ORCPT ); Mon, 22 Nov 2021 14:57:07 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35976 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237596AbhKVT5G (ORCPT ); Mon, 22 Nov 2021 14:57:06 -0500 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B85DEC061574 for ; Mon, 22 Nov 2021 11:53:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=KdZmRcc3t+prr1s7+hSrGjqXoixJomYlrH7C4x4Wvhk=; b=HC/R7sKScVNcLXHvCwjx2WD97d JWsW/Co+TC7xT7JyHfLebl4AMhkemUz2OnbnTTCmwI8kqKh5R81C6guICkw+NZBSp6DYNbBt4pN0Z ImwT8MxDNiiD+FMA1cDNJtssA4gyZnJ+kDx+FQ5+qcnE1kU3/F6INSjaDSbjgBLYIENA7tCvZ5ASq VtKVT442vmTKA7x2NYAknc3SxtCnD3La5RIBSACdC6KZh8PV9TXiHiM3emH7FJZcr21KoOmRPfNep qjbDwamRhY3jS2dY+Rxzmmk0bYEpOPQQHuwIKSujt5OQRV+1Lz2HBu+VKHKwrXm9GvvF0KHa/1g2I CLjY0r7g==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:55800) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1mpFNs-00074Z-O1; Mon, 22 Nov 2021 19:53:48 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1mpFNo-0007xa-7a; Mon, 22 Nov 2021 19:53:44 +0000 Date: Mon, 22 Nov 2021 19:53:44 +0000 From: "Russell King (Oracle)" To: Jordan Vrtanoski , stable@vger.kernel.org Cc: mw@semihalf.com, linux-arm-kernel@lists.infradead.org, stefanc@marvell.com Subject: Re: ClearFog GT 8K not initialising SFP-H10GB-CU1M transceiver on 5.4.150 Message-ID: References: <3AB36F18-250C-46F5-8135-94C79102B8A5@gmail.com> <256509AE-EE75-40AF-882F-F84A55F98C2D@gmail.com> <2F6C75BF-6CD8-4A58-B8AA-4D3A6B5A1008@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <2F6C75BF-6CD8-4A58-B8AA-4D3A6B5A1008@gmail.com> Sender: Russell King (Oracle) Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Mon, Nov 22, 2021 at 02:51:36PM +0400, Jordan Vrtanoski wrote: > Hi, > After bisecting, the regression defect was introduced in 5.4.90 with the following patch: > "[PATCH net v3] net: mvpp2: disable force link UP during port init procedure” > > The patch is changing the configuration of the port during the initialisation of MVPP22_XLG_CTRL0_REG, which > on ClearFog GT 8K is preventing the MVPP2 to properly start the MAC after the transceiver is detected. After reverting > the patch, the transceiver works properly. Right, the problem will be 875082244853 ("net: mvpp2: disable force link UP during port init procedure") that has been backported to kernels that it shouldn't have been applied to. There is a subtle interaction between that commit and development work leading up to it that wasn't obvious during the review. Specifically, any kernel without fefeae73ac7a ("net: mvpp2: ensure the port is forced down while changing modes") will now be broken. However, fefeae73ac7a is development work, and so can't be backported. Adding stable to this thread so they're aware of the issue. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!