From: Wolfram Sang <wsa@kernel.org>
To: minyard@acm.org
Cc: Oleksij Rempel <o.rempel@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
Andrew Manley <andrew.manley@sealingtech.com>
Subject: Re: [PATCH v2 2/2] i2c:imx: Add an extra read at the end of an I2C slave read
Date: Tue, 23 Nov 2021 11:28:41 +0100 [thread overview]
Message-ID: <YZzCWfvq5k2JaMka@kunai> (raw)
In-Reply-To: <20211112133956.655179-3-minyard@acm.org>
[-- Attachment #1: Type: text/plain, Size: 623 bytes --]
On Fri, Nov 12, 2021 at 07:39:56AM -0600, minyard@acm.org wrote:
> From: Corey Minyard <minyard@acm.org>
>
> The I2C slave interface expects that the driver will read ahead one
> byte. The IMX driver/device doesn't do this, but simulate it so that
> read operations get their index set correctly.
From what I understand, the patch is correct but the description may be
wrong?
AFAIU the patch adds the slave event I2C_SLAVE_READ_PROCESSED to the
case when the last byte was transferred. We as the client got a NAK from
the controller. However, the byte WAS processed, so the event is ok and
not a dummy?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2021-11-23 10:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-12 13:39 [PATCH v2 0/2] i2c:imx: Deliver a timely stop on slave side, fix recv minyard
2021-11-12 13:39 ` [PATCH v2 1/2] i2c:imx: Add timer for handling the stop condition minyard
2021-11-12 13:39 ` [PATCH v2 2/2] i2c:imx: Add an extra read at the end of an I2C slave read minyard
2021-11-23 10:28 ` Wolfram Sang [this message]
2021-11-23 12:44 ` Corey Minyard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YZzCWfvq5k2JaMka@kunai \
--to=wsa@kernel.org \
--cc=andrew.manley@sealingtech.com \
--cc=kernel@pengutronix.de \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=minyard@acm.org \
--cc=o.rempel@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.