From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: James Clark <james.clark@arm.com>
Cc: "Uwe Kleine-König" <uwe@kleine-koenig.org>,
"Peter Zijlstra" <peterz@infradead.org>,
"Ingo Molnar" <mingo@redhat.com>,
"Mark Rutland" <mark.rutland@arm.com>,
"Alexander Shishkin" <alexander.shishkin@linux.intel.com>,
"Jiri Olsa" <jolsa@redhat.com>,
"Namhyung Kim" <namhyung@kernel.org>,
linux-perf-users@vger.kernel.org,
"Diederik de Haas" <didi.debian@cknow.org>,
"Branislav Rankov" <Branislav.Rankov@arm.com>,
"Adrian Bunk" <bunk@debian.org>
Subject: Re: [PATCH v2] perf: Drop requirement for libstdc++.so for libopencsd check
Date: Mon, 6 Dec 2021 17:10:59 -0300 [thread overview]
Message-ID: <Ya5uU11x7cQc46F1@kernel.org> (raw)
In-Reply-To: <2d97dd02-fd30-005e-5578-065706986a0c@arm.com>
Em Mon, Dec 06, 2021 at 10:14:57AM +0000, James Clark escreveu:
>
>
> On 03/12/2021 21:05, Uwe Kleine-König wrote:
> > It's possible to link against libopencsd_c_api without having
> > libstdc++.so available, only libstdc++.so.6.0.28 (or whatever version is
> > in use) needs to be available. The same holds true for libopencsd.so.
> > When -lstdc++ (or -lopencsd) is explicitly passed to the linker however
> > the .so file must be available.
> >
> > So wrap adding the dependencies into a check for static linking that
> > actually requires adding them all. The same construct is already used
> > for some other tests in the same file to reduce dependencies in the
> > dynamic linking case.
> >
> > Fixes: 573cf5c9a152 ("perf build: Add missing -lstdc++ when linking with libopencsd")
> > Signed-off-by: Uwe Kleine-König <uwe@kleine-koenig.org>
>
> Reviewed-by: James Clark <james.clark@arm.com>
Thanks, applied.
- Arnaldo
prev parent reply other threads:[~2021-12-06 20:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-03 21:05 [PATCH v2] perf: Drop requirement for libstdc++.so for libopencsd check Uwe Kleine-König
2021-12-06 10:14 ` James Clark
2021-12-06 20:10 ` Arnaldo Carvalho de Melo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ya5uU11x7cQc46F1@kernel.org \
--to=acme@kernel.org \
--cc=Branislav.Rankov@arm.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=bunk@debian.org \
--cc=didi.debian@cknow.org \
--cc=james.clark@arm.com \
--cc=jolsa@redhat.com \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=uwe@kleine-koenig.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.