From mboxrd@z Thu Jan  1 00:00:00 1970
Content-Type: multipart/mixed; boundary="===============5235956915924318676=="
MIME-Version: 1.0
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [pdx86-platform-drivers-x86:review-hans 41/44] drivers/platform/x86/lenovo-yogabook-wmi.c:278:20: warning: no previous prototype for 'yogabook_wmi_suspend'
Date: Tue, 07 Dec 2021 12:38:53 +0200
Message-ID: <Ya85vcmiq+MI2Scc@smile.fi.intel.com>
In-Reply-To: <202112070945.X05c2wgI-lkp@intel.com>
List-Id: <oe-kbuild-all.lists.linux.dev>

--===============5235956915924318676==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable

On Tue, Dec 07, 2021 at 09:42:46AM +0800, kernel test robot wrote:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-dr=
ivers-x86.git review-hans
> head:   cb01df9ef827442739051c6457962a5c6bc85d99
> commit: 4709e8b835ec25e8627844e9927804f814b64fd4 [41/44] platform/x86: le=
novo-yogabook-wmi: Add driver for Lenovo Yoga Book
> config: x86_64-allyesconfig (https://download.01.org/0day-ci/archive/2021=
1207/202112070945.X05c2wgI-lkp(a)intel.com/config)
> compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
> reproduce (this is a W=3D1 build):
>         # https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-=
drivers-x86.git/commit/?id=3D4709e8b835ec25e8627844e9927804f814b64fd4
>         git remote add pdx86-platform-drivers-x86 https://git.kernel.org/=
pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git
>         git fetch --no-tags pdx86-platform-drivers-x86 review-hans
>         git checkout 4709e8b835ec25e8627844e9927804f814b64fd4
>         # save the config file to linux build tree
>         mkdir build_dir
>         make W=3D1 O=3Dbuild_dir ARCH=3Dx86_64 SHELL=3D/bin/bash drivers/=
platform/x86/
> =

> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
> =

> All warnings (new ones prefixed by >>):
> =

> >> drivers/platform/x86/lenovo-yogabook-wmi.c:278:20: warning: no previou=
s prototype for 'yogabook_wmi_suspend' [-Wmissing-prototypes]
>      278 | __maybe_unused int yogabook_wmi_suspend(struct device *dev)
>          |                    ^~~~~~~~~~~~~~~~~~~~
> >> drivers/platform/x86/lenovo-yogabook-wmi.c:294:20: warning: no previou=
s prototype for 'yogabook_wmi_resume' [-Wmissing-prototypes]
>      294 | __maybe_unused int yogabook_wmi_resume(struct device *dev)
>          |                    ^~~~~~~~~~~~~~~~~~~

Despite missed static, we usually put __maybe_unused between type and funct=
ion
name in this cases.

-- =

With Best Regards,
Andy Shevchenko


--===============5235956915924318676==--