From: Vinod Koul <vkoul@kernel.org>
To: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: Andy Gross <agross@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Amit Nischal <anischal@codeaurora.org>,
Taniya Das <tdas@codeaurora.org>,
dmitry.baryshkov@linaro.org, linux-arm-msm@vger.kernel.org,
linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] clk: qcom: rcg2: Cache rate changes for parked RCGs
Date: Tue, 7 Dec 2021 12:37:04 +0530 [thread overview]
Message-ID: <Ya8IGPJCBl+seblO@matsya> (raw)
In-Reply-To: <20211203035601.3505780-1-bjorn.andersson@linaro.org>
On 02-12-21, 19:56, Bjorn Andersson wrote:
> As GDSCs are turned on and off some associated clocks are momentarily
> enabled for house keeping purposes. Failure to enable these clocks seems
> to have been silently ignored in the past, but starting in SM8350 this
> failure will prevent the GDSC to turn on.
>
> At least on SM8350 this operation will enable the RCG per the
> configuration in CFG_REG. This means that the current model where the
> current configuration is written back to CF_REG immediately after
s/CF_REG/CFG_REG
> parking the RCG doesn't work.
>
> Instead, keep track of the currently requested rate of the clock and
> upon enabling the clock reapply the configuration per the saved rate.
With that fixed:
Reviewed-by: Vinod Koul <vkoul@kernel.org>
--
~Vinod
next prev parent reply other threads:[~2021-12-07 7:07 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-03 3:56 [PATCH] clk: qcom: rcg2: Cache rate changes for parked RCGs Bjorn Andersson
2021-12-04 0:39 ` Steev Klimaszewski
2021-12-04 3:16 ` Steev Klimaszewski
2021-12-07 7:07 ` Vinod Koul [this message]
2021-12-12 23:28 ` Steev Klimaszewski
2021-12-15 22:27 ` Bjorn Andersson
2021-12-16 1:51 ` Stephen Boyd
2021-12-16 2:48 ` Bjorn Andersson
2021-12-16 18:58 ` Stephen Boyd
2021-12-16 23:32 ` Bjorn Andersson
2021-12-17 1:45 ` Stephen Boyd
2021-12-17 4:05 ` Bjorn Andersson
2022-01-12 3:06 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ya8IGPJCBl+seblO@matsya \
--to=vkoul@kernel.org \
--cc=agross@kernel.org \
--cc=anischal@codeaurora.org \
--cc=bjorn.andersson@linaro.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
--cc=tdas@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.