From: Thierry Reding <thierry.reding@gmail.com>
To: Rob Herring <robh@kernel.org>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
Tony Lindgren <tony@atomide.com>,
Roger Quadros <rogerq@kernel.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: memory-controllers: ti,gpmc: Drop incorrect unevaluatedProperties
Date: Tue, 7 Dec 2021 09:37:56 +0100 [thread overview]
Message-ID: <Ya8dZKQJWxt5IfZh@orome.fritz.box> (raw)
In-Reply-To: <20211206174215.2297796-1-robh@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 1011 bytes --]
On Mon, Dec 06, 2021 at 11:42:15AM -0600, Rob Herring wrote:
> With 'unevaluatedProperties' support implemented, the TI GPMC example
> has a warning:
>
> Documentation/devicetree/bindings/mtd/ti,gpmc-onenand.example.dt.yaml: memory-controller@6e000000: onenand@0,0: Unevaluated properties are not allowed ('compatible', '#address-cells', '#size-cells', 'partition@0', 'partition@100000' were unexpected)
>
> The child node definition for GPMC is not a complete binding, so specifying
> 'unevaluatedProperties: false' for it is not correct and should be
> dropped.
>
> Fixup the unnecessary 'allOf' while we're here.
>
> Cc: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> Cc: Tony Lindgren <tony@atomide.com>
> Cc: Roger Quadros <rogerq@kernel.org>
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> .../devicetree/bindings/memory-controllers/ti,gpmc.yaml | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
Reviewed-by: Thierry Reding <treding@nvidia.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2021-12-07 8:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-06 17:42 [PATCH] dt-bindings: memory-controllers: ti,gpmc: Drop incorrect unevaluatedProperties Rob Herring
2021-12-07 8:37 ` Thierry Reding [this message]
2021-12-07 9:12 ` Krzysztof Kozlowski
2021-12-07 15:54 ` Rob Herring
2021-12-07 16:27 ` Krzysztof Kozlowski
2021-12-07 12:49 ` Roger Quadros
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ya8dZKQJWxt5IfZh@orome.fritz.box \
--to=thierry.reding@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=rogerq@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.