From: Cyril Hrubis <chrubis@suse.cz>
To: Richard Palethorpe <rpalethorpe@suse.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH] check: Deprecated API symbols
Date: Tue, 7 Dec 2021 13:59:31 +0100 [thread overview]
Message-ID: <Ya9as97Bo46XvDtO@yuki> (raw)
In-Reply-To: <20211207125420.32538-1-rpalethorpe@suse.com>
Hi!
> The old API represents a big source of complication. It invalidates a
> lot of assumptions we can make when writing checks specifically for
> the new API.
>
> Cyril proposed ignoring these symbols altogether in a previous
> patch. This is a counter proposal to print a warning, but then abandon
> checking the symbol any further.
>
> The reasoning is that ignoring them altogether might hide errors. Also
> the existence of the old API may be a surprise to new developers. This
> change will alert them that a test needs updating and that it is not
> to be used as a reference.
>
> Signed-off-by: Richard Palethorpe <rpalethorpe@suse.com>
Sounds good to me:
Reviewed-by: Cyril Hrubis <chrubis@suse.cz>
--
Cyril Hrubis
chrubis@suse.cz
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2021-12-07 12:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-30 11:45 [LTP] [PATCH] sparse: Skip TCID and TST_TOTAL Cyril Hrubis
2021-11-30 13:56 ` Richard Palethorpe
2021-11-30 14:27 ` Cyril Hrubis
2021-12-01 7:21 ` Richard Palethorpe
2021-12-07 12:54 ` [LTP] [PATCH] check: Deprecated API symbols Richard Palethorpe via ltp
2021-12-07 12:59 ` Cyril Hrubis [this message]
2021-12-07 14:09 ` Richard Palethorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ya9as97Bo46XvDtO@yuki \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
--cc=rpalethorpe@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.