Re: [Virtio-fs] [PATCH v7 0/6] virtiofsd: support per inode DAX

[Vivek Goyal <vgoyal@redhat.com>]

Hi Jeffle,

I noticed that you posted V8 of kernel patches. I was away from work
so could not look at it. Now I am back and want to review and test
those patches.

Is there a new version of patches for virtiofsd as well?

As per v6 changelog, I see that you have rebased virtiofsd patches to.

https://gitlab.com/virtio-fs/qemu/-/commits/virtio-fs-dev

I am not sure if that's the branch where latest DAX patches are supposed
to be.

David, could you please let us know which branch should we use for
latest DAX patches you have. Or push your latest patches to virtio-fs-dev
so that we are on same page.

Thanks
Vivek

On Tue, Nov 02, 2021 at 01:56:40PM +0800, Jeffle Xu wrote:
> The corresponding kernel patch set:
> https://lore.kernel.org/all/20211102052604.59462-1-jefflexu@linux.alibaba.com/
> 
> changes since v6:
> - rebase to 'virtio-fs-dev' branch
> - the added new option is now named as "-o dax=inode|filesize"
> - virtiofsd won't advertise support for per inode DAX if no DAX policy
>   specified
> 
> changes since v5:
> - add back support for .ioctl()
> - add back negotiation during FUSE_INIT
> - add '-o dax=[server|attr]' option to control the policy used by
>   virtiofsd to determine whether DAX shall be enabled or not for
>   specific file. Please refer to the commit log of patch 4/5/6 for
>   more detailed information.
> 
> 
> changes since v4:
> - decide whether DAX shall be enabled or not solely depending on file
>   size (DAX is disabled for files smaller than 32KB)
> - negotiation during FUSE_INIT is droped
> - drop support for .ioctl() for passthrough
> 
> changes since v2/v3:
> Patch 4 in v2 is incomplete by mistake and it will fail to be compiled.
> I had ever sent a seperate patch 4 of v3. Now I send the whole complete
> set in v4. Except for this, there's no other diferrence.
> 
> Jeffle Xu (6):
>   virtiofsd: add .ioctl() support
>   virtiofsd: support per inode DAX in fuse protocol
>   virtiofsd: add 'dax=' option
>   virtiofsd: negotiate per inode DAX in FUSE_INIT
>   virtiofsd: implement xflag based dax policy
>   virtiofsd: implement file size based dax policy
> 
>  include/standard-headers/linux/fuse.h |   2 +
>  tools/virtiofsd/fuse_common.h         |   5 +
>  tools/virtiofsd/fuse_lowlevel.c       |   6 ++
>  tools/virtiofsd/helper.c              |   5 +
>  tools/virtiofsd/passthrough_ll.c      | 141 ++++++++++++++++++++++++++
>  tools/virtiofsd/passthrough_seccomp.c |   1 +
>  6 files changed, 160 insertions(+)
> 
> -- 
> 2.27.0
>