From: Calvin Zhang <calvinzhang.cool@gmail.com>
To: Catalin Marinas <catalin.marinas@arm.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Frank Rowand <frowand.list@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org
Subject: Re: [PATCH] mm: kmemleak: alloc gray object for reserved region with direct map.
Date: Fri, 26 Nov 2021 09:35:36 +0800 [thread overview]
Message-ID: <YaA56JVYPfzCsawG@debian> (raw)
In-Reply-To: <YZ/FQXS3gWZ2xfEy@arm.com>
On Thu, Nov 25, 2021 at 05:17:53PM +0000, Catalin Marinas wrote:
>On Tue, Nov 23, 2021 at 05:06:41PM +0800, Calvin Zhang wrote:
>> Reserved regions with direct mapping may contain references to other
>> regions. CMA region with fixed location is reserved without creating
>> kmemleak_object for it.
>>
>> So add them as gray kmemleak objects.
>
>Do you get any kmemleak false positives without this patch? It would be
>good to include them in the commit message.
Sorry, no. I thought it was possible before I saw this commit:
620951e27457 ("mm/cma: make kmemleak ignore CMA regions").
>
>Without seeing a false positive caused by this, I'm not convinced it is
>the right approach. You mentioned CMA but telling kmemleak about the
>whole CMA region is a pretty big hammer. I'd rather add individual
>kmemleak_alloc_*() calls in cma_alloc().
Yeah, I agree.
--
Calvin
prev parent reply other threads:[~2021-11-26 1:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-23 9:06 [PATCH] mm: kmemleak: alloc gray object for reserved region with direct map Calvin Zhang
2021-11-25 17:17 ` Catalin Marinas
2021-11-26 1:35 ` Calvin Zhang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YaA56JVYPfzCsawG@debian \
--to=calvinzhang.cool@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=catalin.marinas@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.