From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 66C0EC433F5 for ; Fri, 26 Nov 2021 10:18:54 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 4100818F5; Fri, 26 Nov 2021 11:18:02 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 4100818F5 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1637921932; bh=KcX7rHHPkbVBoPNzTbkKY19v5RLmo4U+f/zwJpmTIXo=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=ufGvwkQtxMIF3tyLKEm16P9FjK3JSm7n8LCEltOFgj9Q1uZoZGnaYTlxVpRZWjYhh Ktw/9+J1zuZYOmlvNGtTt1YYiY4Dp2CaBte5557Yqc9fylekhkH9SWibynOM/VE+oH Qa2JXtuZN2TUHymxPwPrn5/inuDRtXgvb0MWMkVU= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id BAACAF80245; Fri, 26 Nov 2021 11:18:01 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 70F5EF80166; Fri, 26 Nov 2021 11:17:56 +0100 (CET) Received: from mail-pf1-x431.google.com (mail-pf1-x431.google.com [IPv6:2607:f8b0:4864:20::431]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 9D0C3F801F7 for ; Fri, 26 Nov 2021 11:17:48 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 9D0C3F801F7 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="LBWGHLBR" Received: by mail-pf1-x431.google.com with SMTP id x131so8467246pfc.12 for ; Fri, 26 Nov 2021 02:17:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=xMgOp7lbYkwgl7D+YMk4FsWl75ZCyIN6+KuA/rtaF/I=; b=LBWGHLBRsRzhoMj3EqgNJCHjvF8Omp+lFltj4q3PZ2eTjzxauxbrZCw7VbA2RptFHn 9JO/dvgYGwWp4DfxLeQ87M9rBFpS5DkINqTqchCLy+3yNbuIofGIjth24f7bfe8aKXFT EglCS4q/j7GP5uJ4lMjPtOb2gbX0j0DUHXDzZXyTF8mmC7crt2z6WMYg92igq2kFgHOQ EkDVWvXJ9BG6UYNazP6na42UVuE1dJn4OPLcOrN4d9Cxu4OOcaCKeaRAkFHhej6oMlSi Zu30smqSUDtulrTke8JXTTjnTRyYDBkyb2lMv6lTqM1BVNgwNV2dvLtMbFd8ZVIpNeUC g5YQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=xMgOp7lbYkwgl7D+YMk4FsWl75ZCyIN6+KuA/rtaF/I=; b=CYw6MMoLDZMRDoWMFebQH33EdlyE+b0rVtOzun0JAO61g79ryXVLkZkadT6FZS+u8V BxqNQHwjG/V2u57dV6/XSBHxqXuXbxrYsJQPsv+mPo+7NgwLKs4HAzGHijuC2H+xOIX9 1BMZ3Xbrow6FDTQt0A7ew/twJqFlT9OnhRC/rZTsGTcUaOOBcsSQ0R7giBRVn2mv66eH XApOz4R6swZkrnKtuN2mKbub5XWDoo/33TesZ6jEu2R9je6l/XuxFDrTcSAJlQlveHAN Cnf6Z63LMwtuQZIrf1JtabAWdVxIfCc9DRFK9itbbxDwnmG9n69IHZBcMjL0qvIfbSe2 hUxA== X-Gm-Message-State: AOAM533EyVVqlSmeQJvr8aNESWnOgBHySelb271c0Uj/qyuxJy05tSTa o9oBiYjfunt8a5Xj4OAYoPUeyA== X-Google-Smtp-Source: ABdhPJy9F/ggoPbCVgIvZMQl0QH1RDypskEwFasKoD+ufuypgX8T72E/Pcuk/nqiUvcMw6OeB5Z0yw== X-Received: by 2002:a05:6a00:24cd:b0:49f:bf3f:c42c with SMTP id d13-20020a056a0024cd00b0049fbf3fc42cmr19995895pfv.54.1637921863703; Fri, 26 Nov 2021 02:17:43 -0800 (PST) Received: from google.com ([2401:fa00:1:10:5eda:d984:1426:91ca]) by smtp.gmail.com with ESMTPSA id f185sm6281835pfg.39.2021.11.26.02.17.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Nov 2021 02:17:43 -0800 (PST) Date: Fri, 26 Nov 2021 18:17:39 +0800 From: Tzung-Bi Shih To: "allen-kh.cheng" Subject: Re: [PATCH v6 3/3] mailbox: mediatek: add support for adsp mailbox controller Message-ID: References: <20211126093021.25462-1-allen-kh.cheng@mediatek.com> <20211126093021.25462-4-allen-kh.cheng@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211126093021.25462-4-allen-kh.cheng@mediatek.com> Cc: devicetree@vger.kernel.org, Linux-ALSA , Kai Vehmanen , cujomalainey@google.com, Daniel Baluta , Jassi Brar , Liam Girdwood , Rob Herring , linux-kernel@vger.kernel.org, Project_Global_Chrome_Upstream_Group@mediatek.com, Mark Brown , linux-mediatek@lists.infradead.org, Ranjani Sridharan , Matthias Brugger , Takashi Iwai , Pierre-Louis Bossart , linux-arm-kernel@lists.infradead.org, sound-open-firmware@alsa-project.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Fri, Nov 26, 2021 at 05:30:21PM +0800, allen-kh.cheng wrote: > Signed-off-by: Allen-KH Cheng With a minor comment: Reviewed-by: Tzung-Bi Shih > diff --git a/drivers/mailbox/Kconfig b/drivers/mailbox/Kconfig > index c9fc06c7e685..c44a0102585d 100644 > --- a/drivers/mailbox/Kconfig > +++ b/drivers/mailbox/Kconfig > @@ -226,6 +226,13 @@ config STM32_IPCC > with hardware for Inter-Processor Communication Controller (IPCC) > between processors. Say Y here if you want to have this support. > > +config MTK_ADSP_IPC_MBOX > + tristate "MediaTek ADSP Mailbox Controller" > + depends on ARCH_MEDIATEK || COMPILE_TEST > + help > + Say yes here to add support for MediaTek ADSP IPC mailbox controller > + driver. It is used to send short messages between processors with dsp. > + > config MTK_CMDQ_MBOX > tristate "MediaTek CMDQ Mailbox Support" > depends on ARCH_MEDIATEK || COMPILE_TEST > diff --git a/drivers/mailbox/Makefile b/drivers/mailbox/Makefile > index c2089f04887e..13d5c81852ca 100644 > --- a/drivers/mailbox/Makefile > +++ b/drivers/mailbox/Makefile > @@ -49,6 +49,8 @@ obj-$(CONFIG_TEGRA_HSP_MBOX) += tegra-hsp.o > > obj-$(CONFIG_STM32_IPCC) += stm32-ipcc.o > > +obj-$(CONFIG_MTK_ADSP_IPC_MBOX) += mtk-adsp-mailbox.o > + > obj-$(CONFIG_MTK_CMDQ_MBOX) += mtk-cmdq-mailbox.o To be neat, Kconfig name should be aligned to the file name. That is, either: - s/MTK_ADSP_IPC_MBOX/MTK_ADSP_MBOX/ - s/mtk-adsp-mailbox.o/mtk-adsp-ipc-mailbox.o/ From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 94450C433EF for ; Fri, 26 Nov 2021 10:18:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=5kpSOnlZjQwzkLck3YkQft8hCuVeUlhmPEVOtkdKNbI=; b=Wpal/yzsHyRCGy 35qNsG4YDW0eMNtgkZYqXWFbsXoI+Jb0bLzUEo7qShETGcjjow7oC3TVGlPuHzLl70NVCkyaVkzyP qVuQkzGzntiFWFMJUYqVQ6L8aX/bgJ9fxSAJRgFGLnO9J5iqXzI8LgSS7TnUxl5dxd6OJraHL/mkb itEBTngubPwdxqtsxUNZ87+A12QmlkUhdfjLKiF4p0feSm4badAxDKn4v4nVnkIclcUk8ZPD6JiKK zKdZQTY087TNXznv/k6G9OIrkCXDlodExbxSy7PWRXfhKAihc4aeG1JlGp3zyCAC75dTS1nubiCQV X5+E44Fy25FAlVT4jARQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mqYJE-009xWL-2G; Fri, 26 Nov 2021 10:18:24 +0000 Received: from mail-pf1-x42f.google.com ([2607:f8b0:4864:20::42f]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mqYIa-009xKz-GA for linux-mediatek@lists.infradead.org; Fri, 26 Nov 2021 10:17:45 +0000 Received: by mail-pf1-x42f.google.com with SMTP id 8so8497994pfo.4 for ; Fri, 26 Nov 2021 02:17:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=xMgOp7lbYkwgl7D+YMk4FsWl75ZCyIN6+KuA/rtaF/I=; b=LBWGHLBRsRzhoMj3EqgNJCHjvF8Omp+lFltj4q3PZ2eTjzxauxbrZCw7VbA2RptFHn 9JO/dvgYGwWp4DfxLeQ87M9rBFpS5DkINqTqchCLy+3yNbuIofGIjth24f7bfe8aKXFT EglCS4q/j7GP5uJ4lMjPtOb2gbX0j0DUHXDzZXyTF8mmC7crt2z6WMYg92igq2kFgHOQ EkDVWvXJ9BG6UYNazP6na42UVuE1dJn4OPLcOrN4d9Cxu4OOcaCKeaRAkFHhej6oMlSi Zu30smqSUDtulrTke8JXTTjnTRyYDBkyb2lMv6lTqM1BVNgwNV2dvLtMbFd8ZVIpNeUC g5YQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=xMgOp7lbYkwgl7D+YMk4FsWl75ZCyIN6+KuA/rtaF/I=; b=BmJv8EnGSfOZ0b+/Y/vA+ukNYUJ2LegnKCkEp523g8PMNbiQM/MI7dKBaI+4RZGbnA W/m606ziSVt0Q1Rd6c2uAJuLkw4u4M77R+oDLKJ1kV8RJRpIyqpxET8bGwMFq9dd0Lj7 zD2CWpbM6BfkSx4SLhQl7srVlmX8QlMp/HNdJ2mEAnT4RKfJvLbKeDscJYe6AHpywF9b Mz6462tSFt+L4lo/E7x+aN7YQBGIzT+zVJ8sEqSZ0mxLeRwz+sSsh7UXMOceSnC/2YXr 8hVIyX1TfUA/j4Vc1GUn63+grzu5MLh4YSxVtnPiQPC1c1kMb+mJ6C+ZDBWnNpLsbwm9 /pmg== X-Gm-Message-State: AOAM533/GT78jvpMnRjNA4R3Ii/85KNwxwxl++ByU2qRBQuy1XtPCjOu qgb5igwPPPw2tfUGURiqD3c5Sg== X-Google-Smtp-Source: ABdhPJy9F/ggoPbCVgIvZMQl0QH1RDypskEwFasKoD+ufuypgX8T72E/Pcuk/nqiUvcMw6OeB5Z0yw== X-Received: by 2002:a05:6a00:24cd:b0:49f:bf3f:c42c with SMTP id d13-20020a056a0024cd00b0049fbf3fc42cmr19995895pfv.54.1637921863703; Fri, 26 Nov 2021 02:17:43 -0800 (PST) Received: from google.com ([2401:fa00:1:10:5eda:d984:1426:91ca]) by smtp.gmail.com with ESMTPSA id f185sm6281835pfg.39.2021.11.26.02.17.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Nov 2021 02:17:43 -0800 (PST) Date: Fri, 26 Nov 2021 18:17:39 +0800 From: Tzung-Bi Shih To: "allen-kh.cheng" Cc: Mark Brown , Rob Herring , Matthias Brugger , Jassi Brar , devicetree@vger.kernel.org, Linux-ALSA , Kai Vehmanen , Liam Girdwood , cujomalainey@google.com, linux-kernel@vger.kernel.org, Takashi Iwai , Ranjani Sridharan , Pierre-Louis Bossart , Project_Global_Chrome_Upstream_Group@mediatek.com, linux-mediatek@lists.infradead.org, Daniel Baluta , linux-arm-kernel@lists.infradead.org, sound-open-firmware@alsa-project.org Subject: Re: [PATCH v6 3/3] mailbox: mediatek: add support for adsp mailbox controller Message-ID: References: <20211126093021.25462-1-allen-kh.cheng@mediatek.com> <20211126093021.25462-4-allen-kh.cheng@mediatek.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20211126093021.25462-4-allen-kh.cheng@mediatek.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211126_021744_606303_E21BA83A X-CRM114-Status: GOOD ( 13.90 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Fri, Nov 26, 2021 at 05:30:21PM +0800, allen-kh.cheng wrote: > Signed-off-by: Allen-KH Cheng With a minor comment: Reviewed-by: Tzung-Bi Shih > diff --git a/drivers/mailbox/Kconfig b/drivers/mailbox/Kconfig > index c9fc06c7e685..c44a0102585d 100644 > --- a/drivers/mailbox/Kconfig > +++ b/drivers/mailbox/Kconfig > @@ -226,6 +226,13 @@ config STM32_IPCC > with hardware for Inter-Processor Communication Controller (IPCC) > between processors. Say Y here if you want to have this support. > > +config MTK_ADSP_IPC_MBOX > + tristate "MediaTek ADSP Mailbox Controller" > + depends on ARCH_MEDIATEK || COMPILE_TEST > + help > + Say yes here to add support for MediaTek ADSP IPC mailbox controller > + driver. It is used to send short messages between processors with dsp. > + > config MTK_CMDQ_MBOX > tristate "MediaTek CMDQ Mailbox Support" > depends on ARCH_MEDIATEK || COMPILE_TEST > diff --git a/drivers/mailbox/Makefile b/drivers/mailbox/Makefile > index c2089f04887e..13d5c81852ca 100644 > --- a/drivers/mailbox/Makefile > +++ b/drivers/mailbox/Makefile > @@ -49,6 +49,8 @@ obj-$(CONFIG_TEGRA_HSP_MBOX) += tegra-hsp.o > > obj-$(CONFIG_STM32_IPCC) += stm32-ipcc.o > > +obj-$(CONFIG_MTK_ADSP_IPC_MBOX) += mtk-adsp-mailbox.o > + > obj-$(CONFIG_MTK_CMDQ_MBOX) += mtk-cmdq-mailbox.o To be neat, Kconfig name should be aligned to the file name. That is, either: - s/MTK_ADSP_IPC_MBOX/MTK_ADSP_MBOX/ - s/mtk-adsp-mailbox.o/mtk-adsp-ipc-mailbox.o/ _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 63427C433FE for ; Fri, 26 Nov 2021 10:19:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=NVt5N9btwpl5qH7TGOR4Zmy1FwDJaMpcq17uQ5Wm/rc=; b=mQ5RCX25OuO05v ypVIV/zMhpf64Dmm88o0FyABoB+Z7wfJY/r8WHBaWIjon0Hzl80tBqSnSr7qS3xmoj7S35FVlwBWU x1FlsfIABiVHiycUqh20+06hJJgNsRQKlExKCGxVnQGefoWZfaB7VGU2zlBVC41vaZkYgYx4frKx5 ejh+GEGb6I5Gcd1OfOH5YiBLbFYGkN0jYRskOFDl68Fnjggapnl+0/c1zaGKhXbSJk3cFEqdqWe90 WFy6eXOCUI+4hI3NGRHDk2nUJgHZB872aimI4vaPGvDot3A2U1NAl+7KS00hkR7ySFjNyhdJR+xw8 oshunZssWbp/Zpea3M9w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mqYIj-009xMR-4y; Fri, 26 Nov 2021 10:17:54 +0000 Received: from mail-pf1-x436.google.com ([2607:f8b0:4864:20::436]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mqYIa-009xKy-Gw for linux-arm-kernel@lists.infradead.org; Fri, 26 Nov 2021 10:17:45 +0000 Received: by mail-pf1-x436.google.com with SMTP id i12so8499568pfd.6 for ; Fri, 26 Nov 2021 02:17:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=xMgOp7lbYkwgl7D+YMk4FsWl75ZCyIN6+KuA/rtaF/I=; b=LBWGHLBRsRzhoMj3EqgNJCHjvF8Omp+lFltj4q3PZ2eTjzxauxbrZCw7VbA2RptFHn 9JO/dvgYGwWp4DfxLeQ87M9rBFpS5DkINqTqchCLy+3yNbuIofGIjth24f7bfe8aKXFT EglCS4q/j7GP5uJ4lMjPtOb2gbX0j0DUHXDzZXyTF8mmC7crt2z6WMYg92igq2kFgHOQ EkDVWvXJ9BG6UYNazP6na42UVuE1dJn4OPLcOrN4d9Cxu4OOcaCKeaRAkFHhej6oMlSi Zu30smqSUDtulrTke8JXTTjnTRyYDBkyb2lMv6lTqM1BVNgwNV2dvLtMbFd8ZVIpNeUC g5YQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=xMgOp7lbYkwgl7D+YMk4FsWl75ZCyIN6+KuA/rtaF/I=; b=ExKFd8gB6yCl84sIb5dnw2oI2/Mj4yb4j+6HaS3GqzcvogiiKQfGwLJrnqXTs9elCA NhDVyXEn5AjF4811GRioJdmmsDq0ZrZc8v0WxZt+eRQ4A7udlRxQyCdD2o91tNbMILKW pDVvgDvVTTksaMtr7VY0SCVpQ+f6jzY6k8461CCZO6My6T1ItbMQAPQLJ7Gcu9Nhp6P/ j48zQmmfCgQgW7JNj+7D7caBVYXQWXUgvAkhEX6Z8vbkWQWBNZHQAOQh9W5ELYomtuW2 nATKSU21iK6F48UwOhdJLkmZDrZV/urUWWRu5xdDzh99FihlYqwQ8zxUCMDNe+7jWKtb GIzA== X-Gm-Message-State: AOAM531nMCL2EdBp7d9puN6FxOXH8GtBzb8S4hoXQ9hjYOo/6rplvSa2 mguuCQX4UQutd+RJmVkFahSvBQ== X-Google-Smtp-Source: ABdhPJy9F/ggoPbCVgIvZMQl0QH1RDypskEwFasKoD+ufuypgX8T72E/Pcuk/nqiUvcMw6OeB5Z0yw== X-Received: by 2002:a05:6a00:24cd:b0:49f:bf3f:c42c with SMTP id d13-20020a056a0024cd00b0049fbf3fc42cmr19995895pfv.54.1637921863703; Fri, 26 Nov 2021 02:17:43 -0800 (PST) Received: from google.com ([2401:fa00:1:10:5eda:d984:1426:91ca]) by smtp.gmail.com with ESMTPSA id f185sm6281835pfg.39.2021.11.26.02.17.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Nov 2021 02:17:43 -0800 (PST) Date: Fri, 26 Nov 2021 18:17:39 +0800 From: Tzung-Bi Shih To: "allen-kh.cheng" Cc: Mark Brown , Rob Herring , Matthias Brugger , Jassi Brar , devicetree@vger.kernel.org, Linux-ALSA , Kai Vehmanen , Liam Girdwood , cujomalainey@google.com, linux-kernel@vger.kernel.org, Takashi Iwai , Ranjani Sridharan , Pierre-Louis Bossart , Project_Global_Chrome_Upstream_Group@mediatek.com, linux-mediatek@lists.infradead.org, Daniel Baluta , linux-arm-kernel@lists.infradead.org, sound-open-firmware@alsa-project.org Subject: Re: [PATCH v6 3/3] mailbox: mediatek: add support for adsp mailbox controller Message-ID: References: <20211126093021.25462-1-allen-kh.cheng@mediatek.com> <20211126093021.25462-4-allen-kh.cheng@mediatek.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20211126093021.25462-4-allen-kh.cheng@mediatek.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211126_021744_607422_6E6B1EB8 X-CRM114-Status: GOOD ( 15.11 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Nov 26, 2021 at 05:30:21PM +0800, allen-kh.cheng wrote: > Signed-off-by: Allen-KH Cheng With a minor comment: Reviewed-by: Tzung-Bi Shih > diff --git a/drivers/mailbox/Kconfig b/drivers/mailbox/Kconfig > index c9fc06c7e685..c44a0102585d 100644 > --- a/drivers/mailbox/Kconfig > +++ b/drivers/mailbox/Kconfig > @@ -226,6 +226,13 @@ config STM32_IPCC > with hardware for Inter-Processor Communication Controller (IPCC) > between processors. Say Y here if you want to have this support. > > +config MTK_ADSP_IPC_MBOX > + tristate "MediaTek ADSP Mailbox Controller" > + depends on ARCH_MEDIATEK || COMPILE_TEST > + help > + Say yes here to add support for MediaTek ADSP IPC mailbox controller > + driver. It is used to send short messages between processors with dsp. > + > config MTK_CMDQ_MBOX > tristate "MediaTek CMDQ Mailbox Support" > depends on ARCH_MEDIATEK || COMPILE_TEST > diff --git a/drivers/mailbox/Makefile b/drivers/mailbox/Makefile > index c2089f04887e..13d5c81852ca 100644 > --- a/drivers/mailbox/Makefile > +++ b/drivers/mailbox/Makefile > @@ -49,6 +49,8 @@ obj-$(CONFIG_TEGRA_HSP_MBOX) += tegra-hsp.o > > obj-$(CONFIG_STM32_IPCC) += stm32-ipcc.o > > +obj-$(CONFIG_MTK_ADSP_IPC_MBOX) += mtk-adsp-mailbox.o > + > obj-$(CONFIG_MTK_CMDQ_MBOX) += mtk-cmdq-mailbox.o To be neat, Kconfig name should be aligned to the file name. That is, either: - s/MTK_ADSP_IPC_MBOX/MTK_ADSP_MBOX/ - s/mtk-adsp-mailbox.o/mtk-adsp-ipc-mailbox.o/ _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9456C433FE for ; Fri, 26 Nov 2021 10:30:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1376846AbhKZKdc (ORCPT ); Fri, 26 Nov 2021 05:33:32 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39054 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1376875AbhKZKbU (ORCPT ); Fri, 26 Nov 2021 05:31:20 -0500 Received: from mail-pf1-x435.google.com (mail-pf1-x435.google.com [IPv6:2607:f8b0:4864:20::435]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 646CCC061A11 for ; Fri, 26 Nov 2021 02:17:44 -0800 (PST) Received: by mail-pf1-x435.google.com with SMTP id n26so8521624pff.3 for ; Fri, 26 Nov 2021 02:17:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=xMgOp7lbYkwgl7D+YMk4FsWl75ZCyIN6+KuA/rtaF/I=; b=LBWGHLBRsRzhoMj3EqgNJCHjvF8Omp+lFltj4q3PZ2eTjzxauxbrZCw7VbA2RptFHn 9JO/dvgYGwWp4DfxLeQ87M9rBFpS5DkINqTqchCLy+3yNbuIofGIjth24f7bfe8aKXFT EglCS4q/j7GP5uJ4lMjPtOb2gbX0j0DUHXDzZXyTF8mmC7crt2z6WMYg92igq2kFgHOQ EkDVWvXJ9BG6UYNazP6na42UVuE1dJn4OPLcOrN4d9Cxu4OOcaCKeaRAkFHhej6oMlSi Zu30smqSUDtulrTke8JXTTjnTRyYDBkyb2lMv6lTqM1BVNgwNV2dvLtMbFd8ZVIpNeUC g5YQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=xMgOp7lbYkwgl7D+YMk4FsWl75ZCyIN6+KuA/rtaF/I=; b=KVvVzwTVC2Ea/YohzY6VZTAEULirMZoYD6OtPaWW32aNP/bt/Z0C9tJpozJm8EaNf3 ZJrIA1FeB92ImZgSn5sdI3HUDQ3e3ddbjmcVRz+mfoVceoI3bygbn+hpOBxg8pHCcDnQ /2lJ8OjYRIWBysCq7VFfmZnf5E17jA65DcKswsRc0fOL7ZojnEsewinEYvLzmO0SJnLM hDxgpI++9xbb4Q3zEk8aOgpnAdl9tAY2TvJ9IZ28CCkA608GKfk/cPxHdZ6dSWuTIt1R Cl6aaMrIbk79eZiRdmK9tcOLRh73rxubkdo9opKzsi98/0aSNYATT2rf7pnAofjdLcAp WgiQ== X-Gm-Message-State: AOAM53178g6akHYTgGdykDCEgNg8OaSW9ky9VjLEcN38dAVmz+FEds6c EY4tCeUJvmXHsvnBv2Fe+fqKDQ== X-Google-Smtp-Source: ABdhPJy9F/ggoPbCVgIvZMQl0QH1RDypskEwFasKoD+ufuypgX8T72E/Pcuk/nqiUvcMw6OeB5Z0yw== X-Received: by 2002:a05:6a00:24cd:b0:49f:bf3f:c42c with SMTP id d13-20020a056a0024cd00b0049fbf3fc42cmr19995895pfv.54.1637921863703; Fri, 26 Nov 2021 02:17:43 -0800 (PST) Received: from google.com ([2401:fa00:1:10:5eda:d984:1426:91ca]) by smtp.gmail.com with ESMTPSA id f185sm6281835pfg.39.2021.11.26.02.17.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Nov 2021 02:17:43 -0800 (PST) Date: Fri, 26 Nov 2021 18:17:39 +0800 From: Tzung-Bi Shih To: "allen-kh.cheng" Cc: Mark Brown , Rob Herring , Matthias Brugger , Jassi Brar , devicetree@vger.kernel.org, Linux-ALSA , Kai Vehmanen , Liam Girdwood , cujomalainey@google.com, linux-kernel@vger.kernel.org, Takashi Iwai , Ranjani Sridharan , Pierre-Louis Bossart , Project_Global_Chrome_Upstream_Group@mediatek.com, linux-mediatek@lists.infradead.org, Daniel Baluta , linux-arm-kernel@lists.infradead.org, sound-open-firmware@alsa-project.org Subject: Re: [PATCH v6 3/3] mailbox: mediatek: add support for adsp mailbox controller Message-ID: References: <20211126093021.25462-1-allen-kh.cheng@mediatek.com> <20211126093021.25462-4-allen-kh.cheng@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211126093021.25462-4-allen-kh.cheng@mediatek.com> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Fri, Nov 26, 2021 at 05:30:21PM +0800, allen-kh.cheng wrote: > Signed-off-by: Allen-KH Cheng With a minor comment: Reviewed-by: Tzung-Bi Shih > diff --git a/drivers/mailbox/Kconfig b/drivers/mailbox/Kconfig > index c9fc06c7e685..c44a0102585d 100644 > --- a/drivers/mailbox/Kconfig > +++ b/drivers/mailbox/Kconfig > @@ -226,6 +226,13 @@ config STM32_IPCC > with hardware for Inter-Processor Communication Controller (IPCC) > between processors. Say Y here if you want to have this support. > > +config MTK_ADSP_IPC_MBOX > + tristate "MediaTek ADSP Mailbox Controller" > + depends on ARCH_MEDIATEK || COMPILE_TEST > + help > + Say yes here to add support for MediaTek ADSP IPC mailbox controller > + driver. It is used to send short messages between processors with dsp. > + > config MTK_CMDQ_MBOX > tristate "MediaTek CMDQ Mailbox Support" > depends on ARCH_MEDIATEK || COMPILE_TEST > diff --git a/drivers/mailbox/Makefile b/drivers/mailbox/Makefile > index c2089f04887e..13d5c81852ca 100644 > --- a/drivers/mailbox/Makefile > +++ b/drivers/mailbox/Makefile > @@ -49,6 +49,8 @@ obj-$(CONFIG_TEGRA_HSP_MBOX) += tegra-hsp.o > > obj-$(CONFIG_STM32_IPCC) += stm32-ipcc.o > > +obj-$(CONFIG_MTK_ADSP_IPC_MBOX) += mtk-adsp-mailbox.o > + > obj-$(CONFIG_MTK_CMDQ_MBOX) += mtk-cmdq-mailbox.o To be neat, Kconfig name should be aligned to the file name. That is, either: - s/MTK_ADSP_IPC_MBOX/MTK_ADSP_MBOX/ - s/mtk-adsp-mailbox.o/mtk-adsp-ipc-mailbox.o/