From: Andrew Lunn <andrew@lunn.ch>
To: Holger Brunck <holger.brunck@hitachienergy.com>
Cc: netdev@vger.kernel.org, Jakub Kicinski <kuba@kernel.org>
Subject: Re: [PATCH 1/2] Docs/devicetree: add serdes-output-amplitude to marvell.txt
Date: Sat, 27 Nov 2021 00:14:49 +0100 [thread overview]
Message-ID: <YaFqafEDK8Fdub9q@lunn.ch> (raw)
In-Reply-To: <20211126154249.2958-1-holger.brunck@hitachienergy.com>
> @@ -46,6 +46,9 @@ Optional properties:
> - mdio? : Container of PHYs and devices on the external MDIO
> bus. The node must contains a compatible string of
> "marvell,mv88e6xxx-mdio-external"
> +- serdes-output-amplitude: Configure the output amplitude of the serdes
> + interface.
> + serdes-output-amplitude = <MV88E6352_SERDES_OUT_AMP_210MV>;
I checked a couple of Marvell PHY datasheets. The 1510, 1512, and 1518
have the exact same register/bits. So ideally we want DT property name
which somebody can later reuse in the Marvell PHY
driver. serdes-output-amplitude-mv seems O.K. for that.
Andrew
prev parent reply other threads:[~2021-11-26 23:16 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-26 15:42 [PATCH 1/2] Docs/devicetree: add serdes-output-amplitude to marvell.txt Holger Brunck
2021-11-26 15:42 ` [PATCH 2/2] dsa: mv88e6xxx: make serdes SGMII/Fiber output amplitude configurable Holger Brunck
2021-11-26 16:16 ` Andrew Lunn
2021-11-26 19:56 ` Marek Behún
2021-11-26 20:43 ` Andrew Lunn
2021-11-26 21:13 ` Marek Behún
2021-11-26 21:49 ` Andrew Lunn
2021-11-29 11:17 ` Holger Brunck
2021-11-26 16:08 ` [PATCH 1/2] Docs/devicetree: add serdes-output-amplitude to marvell.txt Andrew Lunn
2021-11-29 10:40 ` Holger Brunck
2021-11-26 16:12 ` Andrew Lunn
2021-11-29 11:14 ` Holger Brunck
2021-11-26 18:37 ` Jakub Kicinski
2021-11-26 19:57 ` Jakub Kicinski
2021-11-26 23:14 ` Andrew Lunn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YaFqafEDK8Fdub9q@lunn.ch \
--to=andrew@lunn.ch \
--cc=holger.brunck@hitachienergy.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.