From: Andrew Lunn <andrew@lunn.ch>
To: Tianhao Chai <cth451@gmail.com>
Cc: Igor Russkikh <irusskikh@marvell.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Hector Martin <marcan@marcan.st>, Sven Peter <sven@svenpeter.dev>,
Alyssa Rosenzweig <alyssa@rosenzweig.io>
Subject: Re: [PATCH] ethernet: aquantia: Try MAC address from device tree
Date: Sun, 28 Nov 2021 17:33:14 +0100 [thread overview]
Message-ID: <YaOvShya4kP4SRk7@lunn.ch> (raw)
In-Reply-To: <20211128023733.GA466664@cth-desktop-dorm.mad.wi.cth451.me>
On Sat, Nov 27, 2021 at 08:37:33PM -0600, Tianhao Chai wrote:
> Apple M1 Mac minis (2020) with 10GE NICs do not have MAC address in the
> card, but instead need to obtain MAC addresses from the device tree. In
> this case the hardware will report an invalid MAC.
>
> Currently atlantic driver does not query the DT for MAC address and will
> randomly assign a MAC if the NIC doesn't have a permanent MAC burnt in.
> This patch causes the driver to perfer a valid MAC address from OF (if
> present) over HW self-reported MAC and only fall back to a random MAC
> address when neither of them is valid.
This is a change in behaviour, and could cause regressions. It would
be better to keep with the current flow. Call
aq_fw_ops->get_mac_permanent() first. If that does not give a valid
MAC address, then try DT, and lastly use a random MAC address.
Andrew
next prev parent reply other threads:[~2021-11-28 16:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-28 2:37 [PATCH] ethernet: aquantia: Try MAC address from device tree Tianhao Chai
2021-11-28 16:33 ` Andrew Lunn [this message]
2021-11-28 17:08 ` Hector Martin
2021-11-30 2:32 ` Andrew Lunn
2021-11-30 4:43 ` Tianhao Chai
2021-12-02 5:10 ` Hector Martin
2021-11-29 22:11 ` Heiner Kallweit
2021-11-30 3:12 ` Tianhao Chai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YaOvShya4kP4SRk7@lunn.ch \
--to=andrew@lunn.ch \
--cc=alyssa@rosenzweig.io \
--cc=cth451@gmail.com \
--cc=davem@davemloft.net \
--cc=irusskikh@marvell.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcan@marcan.st \
--cc=netdev@vger.kernel.org \
--cc=sven@svenpeter.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.