From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 65B12C433F5 for ; Mon, 29 Nov 2021 07:14:04 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 7D8AD17D5; Mon, 29 Nov 2021 08:13:12 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 7D8AD17D5 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1638170042; bh=57oTTRSNx9YNMs4ihpm8haSL4gRbD5XmDEw05r91OaU=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=LF0yQYyq7FmY7LkFUrel365zcmYsxrD3k53/+AQJDqbGxxqGbzgFntSj/YAQWWuBV qBiipTPLp9N5ilmxGdknHXislyrwTT6w2FLgboHbsuQ02UY+EacQVGMJ3ZF/H58mBT OoBdM5XxP9bAK5aaVAm/WSR1hhMuYMmNpBTvKgyI= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 68F1CF80254; Mon, 29 Nov 2021 08:12:30 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 987E2F80256; Mon, 29 Nov 2021 08:12:28 +0100 (CET) Received: from mail-pl1-x62c.google.com (mail-pl1-x62c.google.com [IPv6:2607:f8b0:4864:20::62c]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 425D2F80246 for ; Mon, 29 Nov 2021 08:12:20 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 425D2F80246 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="Sjv5tuU3" Received: by mail-pl1-x62c.google.com with SMTP id y8so11451257plg.1 for ; Sun, 28 Nov 2021 23:12:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=XOVClEjHy2YCmmxBNWZViUvkZtP1AdWZ7jyiRVXX/3Q=; b=Sjv5tuU3YefSTVzJGdWEKxum4VaFMKb5gxi04NlC81VNM6HCAfuQLXGCZMvt83jl0B 095duvMeJkcxy6vpoByoMGLUVgoALS4C9E4mvfyeJgpTr3CfyPC4V7mK292GP9L41NYJ J1CNIFmMyGbSsvEgUUarFrLyxv/z3D2jvMJymtJP4B69F5Wk8evpoEVg26aowPzBqPlx a0DrZ20URASj+2Zc/cFzyir3b2v8oA8iqJawkdIqTcKILSNUyaRrejfS+HJdInNrbrdC bxhXHDSafZMIAajFSMvxtE6S/cK9ykm51ZAsZ7ufCBS7XPoE+jfqT7dr2UCXUTuiQ8qv 7WfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=XOVClEjHy2YCmmxBNWZViUvkZtP1AdWZ7jyiRVXX/3Q=; b=QyQHtuSwtp349ETCHHwsimwa51PnOmxx77PVeK1mWUhzhpWO9SFhMUZA6ueC3Mnt2y WdeJopcEHqEnYeqTMebA7loBtY0/yIW3HusvHg7WKgkI/Rjfx27pKmnbcb5spw/s/vWt CXrCxuVvq7VC7tBHIrqZ2f7lX4y0+tTqk4UrzxSgvlkJfff0tvjnWIH16nJzmZu2J0we DEWjXMPYF05V20Fuz1bbhEjqi91/UuKhLr2IasSi5PCN3RECeLfqaOgYgijaUQSXu2nL QZIfJM11GzD6RjKZCmLYyQka3r46fcHkyu5t1z7DH3d9xYmGZJE6aRyZKY89qp6tI2wl kglA== X-Gm-Message-State: AOAM531abZjJSaQFeHiH+1xYUnWTrB/Kd0febQkcsFw/Dr9UgLkspw+5 2F+/QxEObIoIYBSZacTboWy6hQ== X-Google-Smtp-Source: ABdhPJwOh28YXHGKAJUi7kIV5rLOOLWW21lh5L1/C7V9rKaGzWrMqT4TrSV/3iTvTifnRN+wFK+7vg== X-Received: by 2002:a17:90b:1643:: with SMTP id il3mr35457906pjb.182.1638169937067; Sun, 28 Nov 2021 23:12:17 -0800 (PST) Received: from google.com ([2401:fa00:1:10:3807:fdf3:5573:47d6]) by smtp.gmail.com with ESMTPSA id nv12sm13818886pjb.49.2021.11.28.23.12.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 28 Nov 2021 23:12:16 -0800 (PST) Date: Mon, 29 Nov 2021 15:12:12 +0800 From: Tzung-Bi Shih To: "allen-kh.cheng" Subject: Re: [PATCH v7 3/3] mailbox: mediatek: add support for adsp mailbox controller Message-ID: References: <20211129063954.1616-1-allen-kh.cheng@mediatek.com> <20211129063954.1616-4-allen-kh.cheng@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211129063954.1616-4-allen-kh.cheng@mediatek.com> Cc: devicetree@vger.kernel.org, Linux-ALSA , Kai Vehmanen , cujomalainey@google.com, linux-kernel@vger.kernel.org, Jassi Brar , Pierre-Louis Bossart , Rob Herring , Liam Girdwood , Project_Global_Chrome_Upstream_Group@mediatek.com, Mark Brown , linux-mediatek@lists.infradead.org, Ranjani Sridharan , Matthias Brugger , Takashi Iwai , Daniel Baluta , linux-arm-kernel@lists.infradead.org, sound-open-firmware@alsa-project.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Mon, Nov 29, 2021 at 02:39:54PM +0800, allen-kh.cheng wrote: > From: Allen-KH Cheng > > This patch is to for MediaTek ADSP IPC mailbox controller driver > It is used to send short messages between processors with adsp > > Reviewed-by: Tzung-Bi Shih > Reviewed-by: AngeloGioacchino Del Regno > Signed-off-by: Allen-KH Cheng Please double check again if you use the R-b tags correctly. I have provided my R-b tag before but have some more minor comments below. With the minor comments: Reviewed-by: Tzung-Bi Shih > diff --git a/drivers/mailbox/mtk-adsp-mailbox.c b/drivers/mailbox/mtk-adsp-mailbox.c [...] > +static const struct mbox_chan_ops adsp_mbox_chan_ops = { > + .send_data = mtk_adsp_mbox_send_data, > + .startup = mtk_adsp_mbox_startup, > + .shutdown = mtk_adsp_mbox_shutdown, > + .last_tx_done = mtk_adsp_mbox_last_tx_done, > +}; Rename adsp_mbox_chan_ops to mtk_adsp_mbox_chan_ops looks better to me. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BE81FC433F5 for ; Mon, 29 Nov 2021 07:13:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=McFJFmY2WFxSXRewgPLEhUxBVjxh+b6gVOiwKKlMzzw=; b=wCyfCXhXXKAL// WJNkBHjtd0inVygv7DIAAew0UrPXDpjlMYe/r1V4r9E20/qsSfat/D+4RPGPUKh//I9P4y9H8VDEi 29/IBzlGFmu+9AduPg4U5A5ilDFCS12WyMj3QBLZPQSm27Ua76/nO59MPo+W9DRH/wEJ5cXSJpenE J3bwrZ5fh8EBW1zOLAlY5D+Bxl1fN8ZodqgQ3isCxaZHpEgoY0yty9iOnK8rPryxSPw5hVJRshRrv TJyvsU1R26AVaZaak/QY4pn0f+m7xyYzSkMC5k00dqvLVY1LfSitrL2rKDPfeOyGC0K8Q/oWMuVkK maThESkNfDwqD3l7aDKQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mraqX-00HaIQ-Eo; Mon, 29 Nov 2021 07:13:05 +0000 Received: from mail-pj1-x1033.google.com ([2607:f8b0:4864:20::1033]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mrapn-00HZzC-6Q for linux-mediatek@lists.infradead.org; Mon, 29 Nov 2021 07:12:21 +0000 Received: by mail-pj1-x1033.google.com with SMTP id h24so12007039pjq.2 for ; Sun, 28 Nov 2021 23:12:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=XOVClEjHy2YCmmxBNWZViUvkZtP1AdWZ7jyiRVXX/3Q=; b=Sjv5tuU3YefSTVzJGdWEKxum4VaFMKb5gxi04NlC81VNM6HCAfuQLXGCZMvt83jl0B 095duvMeJkcxy6vpoByoMGLUVgoALS4C9E4mvfyeJgpTr3CfyPC4V7mK292GP9L41NYJ J1CNIFmMyGbSsvEgUUarFrLyxv/z3D2jvMJymtJP4B69F5Wk8evpoEVg26aowPzBqPlx a0DrZ20URASj+2Zc/cFzyir3b2v8oA8iqJawkdIqTcKILSNUyaRrejfS+HJdInNrbrdC bxhXHDSafZMIAajFSMvxtE6S/cK9ykm51ZAsZ7ufCBS7XPoE+jfqT7dr2UCXUTuiQ8qv 7WfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=XOVClEjHy2YCmmxBNWZViUvkZtP1AdWZ7jyiRVXX/3Q=; b=NxrsGT4LQgddE/iOt7p4+wN4fNLBJ4QreuO0wVczpubFsS8p49HJP2TiCX5fZy0Brz bl0Tg3rdqJIuIvDu6hWIeeV1bJk0QDXqyD+AUJOwSwdKhrABGF/cgulsB1+GJ5SZkSkb saQPtWXXlyFgDde9Tmd8B0MsvTfcylWq4t7P0smatHXsEv5eruVGBO7XE2rgExA5Tahm eRCyR4U6ucCrbhD1xkIWr5KBXLpbDyUBmPPrmBAlG3fm7NClDhxsua49dbT0beQuUPo0 n3XYq9KaDRKEhOfCwtEhHNt8P4eU5jWWWdmRtcDLLI3bsUGv7vWSE9Wqu7OS4KnA8xiI nSLA== X-Gm-Message-State: AOAM532Tu22drW5AO1A/xBlkGYDQOxWIBmVaes2VFQkolesBCOzSmwEy jR0oEeFI+MiNm+IFD00iHskSPA== X-Google-Smtp-Source: ABdhPJwOh28YXHGKAJUi7kIV5rLOOLWW21lh5L1/C7V9rKaGzWrMqT4TrSV/3iTvTifnRN+wFK+7vg== X-Received: by 2002:a17:90b:1643:: with SMTP id il3mr35457906pjb.182.1638169937067; Sun, 28 Nov 2021 23:12:17 -0800 (PST) Received: from google.com ([2401:fa00:1:10:3807:fdf3:5573:47d6]) by smtp.gmail.com with ESMTPSA id nv12sm13818886pjb.49.2021.11.28.23.12.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 28 Nov 2021 23:12:16 -0800 (PST) Date: Mon, 29 Nov 2021 15:12:12 +0800 From: Tzung-Bi Shih To: "allen-kh.cheng" Cc: Mark Brown , Rob Herring , Matthias Brugger , Jassi Brar , Linux-ALSA , cujomalainey@google.com, Pierre-Louis Bossart , Liam Girdwood , Ranjani Sridharan , Kai Vehmanen , Daniel Baluta , Jaroslav Kysela , Takashi Iwai , Project_Global_Chrome_Upstream_Group@mediatek.com, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, sound-open-firmware@alsa-project.org Subject: Re: [PATCH v7 3/3] mailbox: mediatek: add support for adsp mailbox controller Message-ID: References: <20211129063954.1616-1-allen-kh.cheng@mediatek.com> <20211129063954.1616-4-allen-kh.cheng@mediatek.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20211129063954.1616-4-allen-kh.cheng@mediatek.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211128_231219_278567_6B005A66 X-CRM114-Status: GOOD ( 13.41 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Mon, Nov 29, 2021 at 02:39:54PM +0800, allen-kh.cheng wrote: > From: Allen-KH Cheng > > This patch is to for MediaTek ADSP IPC mailbox controller driver > It is used to send short messages between processors with adsp > > Reviewed-by: Tzung-Bi Shih > Reviewed-by: AngeloGioacchino Del Regno > Signed-off-by: Allen-KH Cheng Please double check again if you use the R-b tags correctly. I have provided my R-b tag before but have some more minor comments below. With the minor comments: Reviewed-by: Tzung-Bi Shih > diff --git a/drivers/mailbox/mtk-adsp-mailbox.c b/drivers/mailbox/mtk-adsp-mailbox.c [...] > +static const struct mbox_chan_ops adsp_mbox_chan_ops = { > + .send_data = mtk_adsp_mbox_send_data, > + .startup = mtk_adsp_mbox_startup, > + .shutdown = mtk_adsp_mbox_shutdown, > + .last_tx_done = mtk_adsp_mbox_last_tx_done, > +}; Rename adsp_mbox_chan_ops to mtk_adsp_mbox_chan_ops looks better to me. _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 46889C433EF for ; Mon, 29 Nov 2021 07:14:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=c9OYCtwljgz6lP6G9Hx6+1r7I4HR7GhVJwckb1p7UhE=; b=xThvcg893+yiiO rF59No9qm5rJ74D/mbq6lh2HxoygSlZwXnaRdVflmOwKi+q7VIK40twPXpxu8hBU4GNk8aHLV7nnq 9CQGADrDIaC6V4L/jWVVcdAHy5C7AOwAZLfHASrqpTCsnnEdcegsIIN7KEZtXsrnfcyeXoTqlPXgw ItTpabwwNnYU+2Vx5y04ilSSSvQWIamgxa+MA9G8wQF4t8dzwnyYHJYLgdxlFI+VVYHXlDRUYEpqN w19sTX6QJ3+eSAt8LiyOiFU01LSZJIWgch6QFTtxA5vSqw0y3kSXLaHeTz0HAKEffW5WDFMviMF8G 3TsVXPP5EI2Jo0AiGhvg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mraq3-00Ha3c-78; Mon, 29 Nov 2021 07:12:37 +0000 Received: from mail-pl1-x634.google.com ([2607:f8b0:4864:20::634]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mrapn-00HZzE-4o for linux-arm-kernel@lists.infradead.org; Mon, 29 Nov 2021 07:12:20 +0000 Received: by mail-pl1-x634.google.com with SMTP id u17so11436089plg.9 for ; Sun, 28 Nov 2021 23:12:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=XOVClEjHy2YCmmxBNWZViUvkZtP1AdWZ7jyiRVXX/3Q=; b=Sjv5tuU3YefSTVzJGdWEKxum4VaFMKb5gxi04NlC81VNM6HCAfuQLXGCZMvt83jl0B 095duvMeJkcxy6vpoByoMGLUVgoALS4C9E4mvfyeJgpTr3CfyPC4V7mK292GP9L41NYJ J1CNIFmMyGbSsvEgUUarFrLyxv/z3D2jvMJymtJP4B69F5Wk8evpoEVg26aowPzBqPlx a0DrZ20URASj+2Zc/cFzyir3b2v8oA8iqJawkdIqTcKILSNUyaRrejfS+HJdInNrbrdC bxhXHDSafZMIAajFSMvxtE6S/cK9ykm51ZAsZ7ufCBS7XPoE+jfqT7dr2UCXUTuiQ8qv 7WfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=XOVClEjHy2YCmmxBNWZViUvkZtP1AdWZ7jyiRVXX/3Q=; b=qykHnsv7/DYKxnufPfm98TSRffpCOkBol3B3iisuOaDf0p0Hy1XmQrJ7PlMwqWAJYO twTEQPcxF/PYG6FWUqTRl2qdjYc2d5SKuKnSsaypgdi2JxuiYphWuCRQFHtpLkEGIhoS THPBZtcin72tfEtRvzgegkGgmvYGu1W5RJZnWDOI7RTRqc9ZKci8pu8dtMJDsQYeox/U vDFTlZmJgKyO/lZ0BlgBWkA6PYrZDJyeAWVp8EFWRM+e2KqghNNR7CnYlOloQ1TbMi6P EEjotcFn5ieIV5w91mZq+pdHFguJAN4jer38UjZh0hmP0bf6O7P4advZIHp7fWJRCEoU NZ3w== X-Gm-Message-State: AOAM532LGukBysXTkjf0LM3A0mcPMFCjMcFfHadM7If90DI5Ds+qAij6 bC00mp/mmVouupzUC3l76Q1/MQ== X-Google-Smtp-Source: ABdhPJwOh28YXHGKAJUi7kIV5rLOOLWW21lh5L1/C7V9rKaGzWrMqT4TrSV/3iTvTifnRN+wFK+7vg== X-Received: by 2002:a17:90b:1643:: with SMTP id il3mr35457906pjb.182.1638169937067; Sun, 28 Nov 2021 23:12:17 -0800 (PST) Received: from google.com ([2401:fa00:1:10:3807:fdf3:5573:47d6]) by smtp.gmail.com with ESMTPSA id nv12sm13818886pjb.49.2021.11.28.23.12.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 28 Nov 2021 23:12:16 -0800 (PST) Date: Mon, 29 Nov 2021 15:12:12 +0800 From: Tzung-Bi Shih To: "allen-kh.cheng" Cc: Mark Brown , Rob Herring , Matthias Brugger , Jassi Brar , Linux-ALSA , cujomalainey@google.com, Pierre-Louis Bossart , Liam Girdwood , Ranjani Sridharan , Kai Vehmanen , Daniel Baluta , Jaroslav Kysela , Takashi Iwai , Project_Global_Chrome_Upstream_Group@mediatek.com, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, sound-open-firmware@alsa-project.org Subject: Re: [PATCH v7 3/3] mailbox: mediatek: add support for adsp mailbox controller Message-ID: References: <20211129063954.1616-1-allen-kh.cheng@mediatek.com> <20211129063954.1616-4-allen-kh.cheng@mediatek.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20211129063954.1616-4-allen-kh.cheng@mediatek.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211128_231219_256938_389CAE49 X-CRM114-Status: GOOD ( 14.80 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Nov 29, 2021 at 02:39:54PM +0800, allen-kh.cheng wrote: > From: Allen-KH Cheng > > This patch is to for MediaTek ADSP IPC mailbox controller driver > It is used to send short messages between processors with adsp > > Reviewed-by: Tzung-Bi Shih > Reviewed-by: AngeloGioacchino Del Regno > Signed-off-by: Allen-KH Cheng Please double check again if you use the R-b tags correctly. I have provided my R-b tag before but have some more minor comments below. With the minor comments: Reviewed-by: Tzung-Bi Shih > diff --git a/drivers/mailbox/mtk-adsp-mailbox.c b/drivers/mailbox/mtk-adsp-mailbox.c [...] > +static const struct mbox_chan_ops adsp_mbox_chan_ops = { > + .send_data = mtk_adsp_mbox_send_data, > + .startup = mtk_adsp_mbox_startup, > + .shutdown = mtk_adsp_mbox_shutdown, > + .last_tx_done = mtk_adsp_mbox_last_tx_done, > +}; Rename adsp_mbox_chan_ops to mtk_adsp_mbox_chan_ops looks better to me. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30D93C433EF for ; Mon, 29 Nov 2021 07:14:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236939AbhK2HRh (ORCPT ); Mon, 29 Nov 2021 02:17:37 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56498 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236996AbhK2HPg (ORCPT ); Mon, 29 Nov 2021 02:15:36 -0500 Received: from mail-pl1-x62a.google.com (mail-pl1-x62a.google.com [IPv6:2607:f8b0:4864:20::62a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C9836C0613E0 for ; Sun, 28 Nov 2021 23:12:17 -0800 (PST) Received: by mail-pl1-x62a.google.com with SMTP id z6so11450126plk.6 for ; Sun, 28 Nov 2021 23:12:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=XOVClEjHy2YCmmxBNWZViUvkZtP1AdWZ7jyiRVXX/3Q=; b=Sjv5tuU3YefSTVzJGdWEKxum4VaFMKb5gxi04NlC81VNM6HCAfuQLXGCZMvt83jl0B 095duvMeJkcxy6vpoByoMGLUVgoALS4C9E4mvfyeJgpTr3CfyPC4V7mK292GP9L41NYJ J1CNIFmMyGbSsvEgUUarFrLyxv/z3D2jvMJymtJP4B69F5Wk8evpoEVg26aowPzBqPlx a0DrZ20URASj+2Zc/cFzyir3b2v8oA8iqJawkdIqTcKILSNUyaRrejfS+HJdInNrbrdC bxhXHDSafZMIAajFSMvxtE6S/cK9ykm51ZAsZ7ufCBS7XPoE+jfqT7dr2UCXUTuiQ8qv 7WfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=XOVClEjHy2YCmmxBNWZViUvkZtP1AdWZ7jyiRVXX/3Q=; b=mRdsobME8pyD5cDlHqWxj0msAaj7zAcjBQeljok3lF9c5f9div6qiKVnCujvbWRolj NDQCulmRyoKAtRn9jO95t2r4w721EKVhHfi7e33S5gyKexr9uI9qIrFJQiCB6qZwPNxt WZKNgXvdIGS1QmVJAWP4vBg+Cp/ws+7n+w4hutRDjKB7hgH7IycxsIDgy4SnRe5nOJQ4 gvvY6KGKcMEhCqrGdx/ZSi7geiNEB14e7UrVIRhTlEJ/Y5HJHTRBjURrS/ZWGh2ZSdce XZHLT9W6c3O6KO0TImeiysXxy2ZOSm92VP/BFtjNx5+hlRv0e2x8y5tYTp0anh2fGekQ MM4w== X-Gm-Message-State: AOAM5310MLbrRg5peNOgQpMZGYMRf+u3SM7YPGTPPWJk9NCCDQKRtWcQ BsHvwXXv6eKJdtabq/NLB2LLVw== X-Google-Smtp-Source: ABdhPJwOh28YXHGKAJUi7kIV5rLOOLWW21lh5L1/C7V9rKaGzWrMqT4TrSV/3iTvTifnRN+wFK+7vg== X-Received: by 2002:a17:90b:1643:: with SMTP id il3mr35457906pjb.182.1638169937067; Sun, 28 Nov 2021 23:12:17 -0800 (PST) Received: from google.com ([2401:fa00:1:10:3807:fdf3:5573:47d6]) by smtp.gmail.com with ESMTPSA id nv12sm13818886pjb.49.2021.11.28.23.12.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 28 Nov 2021 23:12:16 -0800 (PST) Date: Mon, 29 Nov 2021 15:12:12 +0800 From: Tzung-Bi Shih To: "allen-kh.cheng" Cc: Mark Brown , Rob Herring , Matthias Brugger , Jassi Brar , Linux-ALSA , cujomalainey@google.com, Pierre-Louis Bossart , Liam Girdwood , Ranjani Sridharan , Kai Vehmanen , Daniel Baluta , Jaroslav Kysela , Takashi Iwai , Project_Global_Chrome_Upstream_Group@mediatek.com, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, sound-open-firmware@alsa-project.org Subject: Re: [PATCH v7 3/3] mailbox: mediatek: add support for adsp mailbox controller Message-ID: References: <20211129063954.1616-1-allen-kh.cheng@mediatek.com> <20211129063954.1616-4-allen-kh.cheng@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211129063954.1616-4-allen-kh.cheng@mediatek.com> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Mon, Nov 29, 2021 at 02:39:54PM +0800, allen-kh.cheng wrote: > From: Allen-KH Cheng > > This patch is to for MediaTek ADSP IPC mailbox controller driver > It is used to send short messages between processors with adsp > > Reviewed-by: Tzung-Bi Shih > Reviewed-by: AngeloGioacchino Del Regno > Signed-off-by: Allen-KH Cheng Please double check again if you use the R-b tags correctly. I have provided my R-b tag before but have some more minor comments below. With the minor comments: Reviewed-by: Tzung-Bi Shih > diff --git a/drivers/mailbox/mtk-adsp-mailbox.c b/drivers/mailbox/mtk-adsp-mailbox.c [...] > +static const struct mbox_chan_ops adsp_mbox_chan_ops = { > + .send_data = mtk_adsp_mbox_send_data, > + .startup = mtk_adsp_mbox_startup, > + .shutdown = mtk_adsp_mbox_shutdown, > + .last_tx_done = mtk_adsp_mbox_last_tx_done, > +}; Rename adsp_mbox_chan_ops to mtk_adsp_mbox_chan_ops looks better to me.