Re: [PATCHv2] i2c-mpc: Correct I2C reset procedure

[Wolfram Sang <wsa@the-dreams.de>]

[-- Attachment #1: Type: text/plain, Size: 1146 bytes --]

On Thu, May 11, 2017 at 02:20:33PM +0200, Joakim Tjernlund wrote:
> Current I2C reset procedure is broken in two ways:
> 1) It only generate 1 START instead of 9 STARTs and STOP.
> 2) It leaves the bus Busy so every I2C xfer after the first
>    fixup calls the reset routine again, for every xfer there after.
> 
> This fixes both errors.
> 
> Signed-off-by: Joakim Tjernlund <joakim.tjernlund@infinera.com>
> Acked-by: Scott Wood <oss@buserror.net>

Okay, I admit it is strange to apply a patch after 4 years, but I am
doing a bus_recovery overhaul right now and Joakim mentioned a few
times, he is still using this patch.

I still do wonder why the generic bus recovery algorithm can't be used.
It has been updated quite a bit and at least sends STOPs after each
pulse (as a result of an earlier discussion about this patch). But a
conversion to generic bus recovery wasn't happening, so apply a) what
users need and b) document what worked for them. Maybe the conversion
will happen somewhen and/or the algorithm here might improve the generic
one. We will see.

That all being said:

Applied to for-next, thanks!


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]