From: Andrew Lunn <andrew@lunn.ch>
To: "Alvin Šipraga" <alvin@pqrs.dk>
Cc: netdev@vger.kernel.org, davem@davemloft.net, kuba@kernel.org,
linus.walleij@linaro.org, f.fainelli@gmail.com,
olteanv@gmail.com, vivien.didelot@gmail.com,
hkallweit1@gmail.com, "Alvin Šipraga" <alsi@bang-olufsen.dk>,
"Arınç ÜNAL" <arinc.unal@arinc9.com>
Subject: Re: [PATCH net v2 3/3] net: dsa: rtl8365mb: set RGMII RX delay in steps of 0.3 ns
Date: Mon, 29 Nov 2021 14:00:10 +0100 [thread overview]
Message-ID: <YaTO2hO2/vPbijCu@lunn.ch> (raw)
In-Reply-To: <20211129103019.1997018-3-alvin@pqrs.dk>
On Mon, Nov 29, 2021 at 11:30:19AM +0100, Alvin Šipraga wrote:
> From: Alvin Šipraga <alsi@bang-olufsen.dk>
>
> A contact at Realtek has clarified what exactly the units of RGMII RX
> delay are. The answer is that the unit of RX delay is "about 0.3 ns".
> Take this into account when parsing rx-internal-delay-ps by
> approximating the closest step value. Delays of more than 2.1 ns are
> rejected.
>
> This obviously contradicts the previous assumption in the driver that a
> step value of 4 was "about 2 ns", but Realtek also points out that it is
> easy to find more than one RX delay step value which makes RGMII work.
>
> Fixes: 4af2950c50c8 ("net: dsa: realtek-smi: add rtl8365mb subdriver for RTL8365MB-VC")
> Cc: Arınç ÜNAL <arinc.unal@arinc9.com>
> Signed-off-by: Alvin Šipraga <alsi@bang-olufsen.dk>
> Acked-by: Arınç ÜNAL <arinc.unal@arinc9.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
next prev parent reply other threads:[~2021-11-29 13:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-29 10:30 [PATCH net v2 1/3] net: dsa: realtek-smi: don't log an error on EPROBE_DEFER Alvin Šipraga
2021-11-29 10:30 ` [PATCH net v2 2/3] net: dsa: rtl8365mb: fix garbled comment Alvin Šipraga
2021-11-29 12:56 ` Andrew Lunn
2021-11-29 10:30 ` [PATCH net v2 3/3] net: dsa: rtl8365mb: set RGMII RX delay in steps of 0.3 ns Alvin Šipraga
2021-11-29 13:00 ` Andrew Lunn [this message]
2021-11-29 12:55 ` [PATCH net v2 1/3] net: dsa: realtek-smi: don't log an error on EPROBE_DEFER Andrew Lunn
2021-11-29 13:00 ` patchwork-bot+netdevbpf
2021-12-02 16:25 ` Alvin Šipraga
2021-11-29 16:57 ` Heiner Kallweit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YaTO2hO2/vPbijCu@lunn.ch \
--to=andrew@lunn.ch \
--cc=alsi@bang-olufsen.dk \
--cc=alvin@pqrs.dk \
--cc=arinc.unal@arinc9.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.