All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vivek Goyal <vgoyal@redhat.com>
To: Borislav Petkov <bp@alien8.de>
Cc: Usama Arif <usama.arif@bytedance.com>,
	x86@kernel.org, linux-kernel@vger.kernel.org, tglx@linutronix.de,
	fam.zheng@bytedance.com,
	"Eric W. Biederman" <ebiederm@xmission.com>,
	Baoquan He <bhe@redhat.com>, Dave Young <dyoung@redhat.com>
Subject: Re: [PATCH] x86/purgatory: provide config to disable purgatory
Date: Mon, 29 Nov 2021 09:04:17 -0500	[thread overview]
Message-ID: <YaTd4ZID7O+bVRXT@redhat.com> (raw)
In-Reply-To: <YZ0HkaOiKfmgN8zl@zn.tnic>

On Tue, Nov 23, 2021 at 04:24:01PM +0100, Borislav Petkov wrote:
> On Tue, Nov 23, 2021 at 03:05:08PM +0000, Usama Arif wrote:
> > This can help in reducing boot time if purgatory is not needed
> > as the sha256 digest of kexec segments is no longer calculated
> > or verified if the config is disabled.
> 
> I'd prefer a commit message to say:
> 
> "Disable purgatory because of real-life use case X. With it disabled,
> booting a second kernel is sped up by Y."
> 
> "Just because" and adding yet another config option is not worth the
> effort, otherwise.

Agreed. What's the use case.

Also this cheksum is used to make sure purgatory is not corrupted. So
this is sort of saftey mechanism to make sure things are still the
same as we expected before we start executing this piece of code. Hence
this does not sound like an optional feature to me (even if it speeds
up things a bit).

BTW, how much speed up do you see.

Thanks
Vivek


  reply	other threads:[~2021-11-29 14:07 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-23 15:05 [PATCH] x86/purgatory: provide config to disable purgatory Usama Arif
2021-11-23 15:24 ` Borislav Petkov
2021-11-29 14:04   ` Vivek Goyal [this message]
     [not found]     ` <79517d3c-3674-cc21-fbdc-b26946809756@bytedance.com>
2021-11-29 16:53       ` [External] " Eric W. Biederman
2021-12-01 10:29         ` Usama Arif
2021-12-06 16:51           ` Usama Arif
2021-12-16 18:05             ` Usama Arif
2021-12-17  0:56               ` Baoquan He
  -- strict thread matches above, loose matches on Subject: below --
2021-11-29 15:01 Usama Arif

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YaTd4ZID7O+bVRXT@redhat.com \
    --to=vgoyal@redhat.com \
    --cc=bhe@redhat.com \
    --cc=bp@alien8.de \
    --cc=dyoung@redhat.com \
    --cc=ebiederm@xmission.com \
    --cc=fam.zheng@bytedance.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tglx@linutronix.de \
    --cc=usama.arif@bytedance.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.