diff for duplicates of <YaUiEquKYi5eqWC0@google.com> diff --git a/a/1.txt b/N1/1.txt index 0c4d6d5..3a7006c 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -17,8 +17,8 @@ On Mon, Nov 29, 2021, Paolo Bonzini wrote: ... > Still it does seem to be a race that happens when IS_RUNNING=true but -> vcpu->mode == OUTSIDE_GUEST_MODE. This patch makes the race easier to -> trigger because it moves IS_RUNNING=false later. +> vcpu->mode = OUTSIDE_GUEST_MODE. This patch makes the race easier to +> trigger because it moves IS_RUNNINGúlse later. Oh! Any chance the bug only repros with preemption enabled? That would explain why I don't see problems, I'm pretty sure I've only run AVIC with a PREEMPT=n. diff --git a/a/content_digest b/N1/content_digest index 2623220..f35621b 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -5,9 +5,37 @@ "ref\0YaUNBfJh35WXMV0M@google.com\0" "ref\0496c2fc6-26b0-9b5d-32f4-2f9e9dd6a064@redhat.com\0" "From\0Sean Christopherson <seanjc@google.com>\0" - "Subject\0[PATCH v2 11/43] KVM: Don't block+unblock when halt-polling is successful\0" + "Subject\0Re: [PATCH v2 11/43] KVM: Don't block+unblock when halt-polling is successful\0" "Date\0Mon, 29 Nov 2021 18:55:14 +0000\0" - "To\0kvm-riscv@lists.infradead.org\0" + "To\0Paolo Bonzini <pbonzini@redhat.com>\0" + "Cc\0Cornelia Huck <cohuck@redhat.com>" + Wanpeng Li <wanpengli@tencent.com> + kvm@vger.kernel.org + David Hildenbrand <david@redhat.com> + linux-kernel@vger.kernel.org + Paul Mackerras <paulus@ozlabs.org> + Atish Patra <atish.patra@wdc.com> + linux-riscv@lists.infradead.org + Claudio Imbrenda <imbrenda@linux.ibm.com> + kvmarm@lists.cs.columbia.edu + Janosch Frank <frankja@linux.ibm.com> + Marc Zyngier <maz@kernel.org> + Joerg Roedel <joro@8bytes.org> + Huacai Chen <chenhuacai@kernel.org> + Maxim Levitsky <mlevitsk@redhat.com> + Christian Borntraeger <borntraeger@de.ibm.com> + Aleksandar Markovic <aleksandar.qemu.devel@gmail.com> + Albert Ou <aou@eecs.berkeley.edu> + kvm-ppc@vger.kernel.org + Paul Walmsley <paul.walmsley@sifive.com> + David Matlack <dmatlack@google.com> + linux-arm-kernel@lists.infradead.org + Jim Mattson <jmattson@google.com> + Anup Patel <anup.patel@wdc.com> + linux-mips@vger.kernel.org + Palmer Dabbelt <palmer@dabbelt.com> + kvm-riscv@lists.infradead.org + " Vitaly Kuznetsov <vkuznets@redhat.com>\0" "\00:1\0" "b\0" "On Mon, Nov 29, 2021, Paolo Bonzini wrote:\n" @@ -29,8 +57,8 @@ "...\n" "\n" "> Still it does seem to be a race that happens when IS_RUNNING=true but\n" - "> vcpu->mode == OUTSIDE_GUEST_MODE. This patch makes the race easier to\n" - "> trigger because it moves IS_RUNNING=false later.\n" + "> vcpu->mode = OUTSIDE_GUEST_MODE. This patch makes the race easier to\n" + "> trigger because it moves IS_RUNNING\303\272lse later.\n" "\n" "Oh! Any chance the bug only repros with preemption enabled? That would explain\n" "why I don't see problems, I'm pretty sure I've only run AVIC with a PREEMPT=n.\n" @@ -39,4 +67,4 @@ "passes in vcpu->cpu. If the vCPU is preempted and scheduled in on a different CPU,\n" avic_vcpu_load() will overwrite the vCPU's entry with the wrong CPU info. -2f7e1fbe6ad6ab60274dd9cda63afd88c298d4648cc36aed95f9321d9e718a85 +0322539bdaadd17ad3c2cf81fee400fb376b1f9c8c8999b718c90e515c00b547
diff --git a/a/1.txt b/N2/1.txt index 0c4d6d5..29fb228 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -26,3 +26,7 @@ why I don't see problems, I'm pretty sure I've only run AVIC with a PREEMPT=n. svm_vcpu_{un}blocking() are called with preemption enabled, and avic_set_running() passes in vcpu->cpu. If the vCPU is preempted and scheduled in on a different CPU, avic_vcpu_load() will overwrite the vCPU's entry with the wrong CPU info. +_______________________________________________ +kvmarm mailing list +kvmarm@lists.cs.columbia.edu +https://lists.cs.columbia.edu/mailman/listinfo/kvmarm diff --git a/a/content_digest b/N2/content_digest index 2623220..a26c667 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -5,9 +5,37 @@ "ref\0YaUNBfJh35WXMV0M@google.com\0" "ref\0496c2fc6-26b0-9b5d-32f4-2f9e9dd6a064@redhat.com\0" "From\0Sean Christopherson <seanjc@google.com>\0" - "Subject\0[PATCH v2 11/43] KVM: Don't block+unblock when halt-polling is successful\0" + "Subject\0Re: [PATCH v2 11/43] KVM: Don't block+unblock when halt-polling is successful\0" "Date\0Mon, 29 Nov 2021 18:55:14 +0000\0" - "To\0kvm-riscv@lists.infradead.org\0" + "To\0Paolo Bonzini <pbonzini@redhat.com>\0" + "Cc\0Cornelia Huck <cohuck@redhat.com>" + Wanpeng Li <wanpengli@tencent.com> + kvm@vger.kernel.org + David Hildenbrand <david@redhat.com> + linux-kernel@vger.kernel.org + Paul Mackerras <paulus@ozlabs.org> + Atish Patra <atish.patra@wdc.com> + linux-riscv@lists.infradead.org + Claudio Imbrenda <imbrenda@linux.ibm.com> + kvmarm@lists.cs.columbia.edu + Janosch Frank <frankja@linux.ibm.com> + Marc Zyngier <maz@kernel.org> + Joerg Roedel <joro@8bytes.org> + Huacai Chen <chenhuacai@kernel.org> + Maxim Levitsky <mlevitsk@redhat.com> + Christian Borntraeger <borntraeger@de.ibm.com> + Aleksandar Markovic <aleksandar.qemu.devel@gmail.com> + Albert Ou <aou@eecs.berkeley.edu> + kvm-ppc@vger.kernel.org + Paul Walmsley <paul.walmsley@sifive.com> + David Matlack <dmatlack@google.com> + linux-arm-kernel@lists.infradead.org + Jim Mattson <jmattson@google.com> + Anup Patel <anup.patel@wdc.com> + linux-mips@vger.kernel.org + Palmer Dabbelt <palmer@dabbelt.com> + kvm-riscv@lists.infradead.org + " Vitaly Kuznetsov <vkuznets@redhat.com>\0" "\00:1\0" "b\0" "On Mon, Nov 29, 2021, Paolo Bonzini wrote:\n" @@ -37,6 +65,10 @@ "\n" "svm_vcpu_{un}blocking() are called with preemption enabled, and avic_set_running()\n" "passes in vcpu->cpu. If the vCPU is preempted and scheduled in on a different CPU,\n" - avic_vcpu_load() will overwrite the vCPU's entry with the wrong CPU info. + "avic_vcpu_load() will overwrite the vCPU's entry with the wrong CPU info.\n" + "_______________________________________________\n" + "kvmarm mailing list\n" + "kvmarm@lists.cs.columbia.edu\n" + https://lists.cs.columbia.edu/mailman/listinfo/kvmarm -2f7e1fbe6ad6ab60274dd9cda63afd88c298d4648cc36aed95f9321d9e718a85 +751892f276e6e9167b8fa87df8597656d0903fe8112f872eee2e26ec89cab300
diff --git a/a/content_digest b/N3/content_digest index 2623220..b2dec72 100644 --- a/a/content_digest +++ b/N3/content_digest @@ -5,9 +5,42 @@ "ref\0YaUNBfJh35WXMV0M@google.com\0" "ref\0496c2fc6-26b0-9b5d-32f4-2f9e9dd6a064@redhat.com\0" "From\0Sean Christopherson <seanjc@google.com>\0" - "Subject\0[PATCH v2 11/43] KVM: Don't block+unblock when halt-polling is successful\0" + "Subject\0Re: [PATCH v2 11/43] KVM: Don't block+unblock when halt-polling is successful\0" "Date\0Mon, 29 Nov 2021 18:55:14 +0000\0" - "To\0kvm-riscv@lists.infradead.org\0" + "To\0Paolo Bonzini <pbonzini@redhat.com>\0" + "Cc\0Maxim Levitsky <mlevitsk@redhat.com>" + Marc Zyngier <maz@kernel.org> + Huacai Chen <chenhuacai@kernel.org> + Aleksandar Markovic <aleksandar.qemu.devel@gmail.com> + Paul Mackerras <paulus@ozlabs.org> + Anup Patel <anup.patel@wdc.com> + Paul Walmsley <paul.walmsley@sifive.com> + Palmer Dabbelt <palmer@dabbelt.com> + Albert Ou <aou@eecs.berkeley.edu> + Christian Borntraeger <borntraeger@de.ibm.com> + Janosch Frank <frankja@linux.ibm.com> + James Morse <james.morse@arm.com> + Alexandru Elisei <alexandru.elisei@arm.com> + Suzuki K Poulose <suzuki.poulose@arm.com> + Atish Patra <atish.patra@wdc.com> + David Hildenbrand <david@redhat.com> + Cornelia Huck <cohuck@redhat.com> + Claudio Imbrenda <imbrenda@linux.ibm.com> + Vitaly Kuznetsov <vkuznets@redhat.com> + Wanpeng Li <wanpengli@tencent.com> + Jim Mattson <jmattson@google.com> + Joerg Roedel <joro@8bytes.org> + linux-arm-kernel@lists.infradead.org + kvmarm@lists.cs.columbia.edu + linux-mips@vger.kernel.org + kvm@vger.kernel.org + kvm-ppc@vger.kernel.org + kvm-riscv@lists.infradead.org + linux-riscv@lists.infradead.org + linux-kernel@vger.kernel.org + David Matlack <dmatlack@google.com> + Oliver Upton <oupton@google.com> + " Jing Zhang <jingzhangos@google.com>\0" "\00:1\0" "b\0" "On Mon, Nov 29, 2021, Paolo Bonzini wrote:\n" @@ -39,4 +72,4 @@ "passes in vcpu->cpu. If the vCPU is preempted and scheduled in on a different CPU,\n" avic_vcpu_load() will overwrite the vCPU's entry with the wrong CPU info. -2f7e1fbe6ad6ab60274dd9cda63afd88c298d4648cc36aed95f9321d9e718a85 +d6c0e5996487bbee6078170dfd60580cd72b0d0192d054606cd29bdc761280a6
diff --git a/a/1.txt b/N4/1.txt index 0c4d6d5..cb347ab 100644 --- a/a/1.txt +++ b/N4/1.txt @@ -26,3 +26,8 @@ why I don't see problems, I'm pretty sure I've only run AVIC with a PREEMPT=n. svm_vcpu_{un}blocking() are called with preemption enabled, and avic_set_running() passes in vcpu->cpu. If the vCPU is preempted and scheduled in on a different CPU, avic_vcpu_load() will overwrite the vCPU's entry with the wrong CPU info. + +_______________________________________________ +linux-riscv mailing list +linux-riscv@lists.infradead.org +http://lists.infradead.org/mailman/listinfo/linux-riscv diff --git a/a/content_digest b/N4/content_digest index 2623220..1f4e91f 100644 --- a/a/content_digest +++ b/N4/content_digest @@ -5,9 +5,42 @@ "ref\0YaUNBfJh35WXMV0M@google.com\0" "ref\0496c2fc6-26b0-9b5d-32f4-2f9e9dd6a064@redhat.com\0" "From\0Sean Christopherson <seanjc@google.com>\0" - "Subject\0[PATCH v2 11/43] KVM: Don't block+unblock when halt-polling is successful\0" + "Subject\0Re: [PATCH v2 11/43] KVM: Don't block+unblock when halt-polling is successful\0" "Date\0Mon, 29 Nov 2021 18:55:14 +0000\0" - "To\0kvm-riscv@lists.infradead.org\0" + "To\0Paolo Bonzini <pbonzini@redhat.com>\0" + "Cc\0Maxim Levitsky <mlevitsk@redhat.com>" + Marc Zyngier <maz@kernel.org> + Huacai Chen <chenhuacai@kernel.org> + Aleksandar Markovic <aleksandar.qemu.devel@gmail.com> + Paul Mackerras <paulus@ozlabs.org> + Anup Patel <anup.patel@wdc.com> + Paul Walmsley <paul.walmsley@sifive.com> + Palmer Dabbelt <palmer@dabbelt.com> + Albert Ou <aou@eecs.berkeley.edu> + Christian Borntraeger <borntraeger@de.ibm.com> + Janosch Frank <frankja@linux.ibm.com> + James Morse <james.morse@arm.com> + Alexandru Elisei <alexandru.elisei@arm.com> + Suzuki K Poulose <suzuki.poulose@arm.com> + Atish Patra <atish.patra@wdc.com> + David Hildenbrand <david@redhat.com> + Cornelia Huck <cohuck@redhat.com> + Claudio Imbrenda <imbrenda@linux.ibm.com> + Vitaly Kuznetsov <vkuznets@redhat.com> + Wanpeng Li <wanpengli@tencent.com> + Jim Mattson <jmattson@google.com> + Joerg Roedel <joro@8bytes.org> + linux-arm-kernel@lists.infradead.org + kvmarm@lists.cs.columbia.edu + linux-mips@vger.kernel.org + kvm@vger.kernel.org + kvm-ppc@vger.kernel.org + kvm-riscv@lists.infradead.org + linux-riscv@lists.infradead.org + linux-kernel@vger.kernel.org + David Matlack <dmatlack@google.com> + Oliver Upton <oupton@google.com> + " Jing Zhang <jingzhangos@google.com>\0" "\00:1\0" "b\0" "On Mon, Nov 29, 2021, Paolo Bonzini wrote:\n" @@ -37,6 +70,11 @@ "\n" "svm_vcpu_{un}blocking() are called with preemption enabled, and avic_set_running()\n" "passes in vcpu->cpu. If the vCPU is preempted and scheduled in on a different CPU,\n" - avic_vcpu_load() will overwrite the vCPU's entry with the wrong CPU info. + "avic_vcpu_load() will overwrite the vCPU's entry with the wrong CPU info.\n" + "\n" + "_______________________________________________\n" + "linux-riscv mailing list\n" + "linux-riscv@lists.infradead.org\n" + http://lists.infradead.org/mailman/listinfo/linux-riscv -2f7e1fbe6ad6ab60274dd9cda63afd88c298d4648cc36aed95f9321d9e718a85 +542cc7d2ec08b3e9914d278ca3be4e9b02ea8e5e2b7f09f115aa8753c2a4a64b
diff --git a/a/1.txt b/N5/1.txt index 0c4d6d5..d45286c 100644 --- a/a/1.txt +++ b/N5/1.txt @@ -26,3 +26,8 @@ why I don't see problems, I'm pretty sure I've only run AVIC with a PREEMPT=n. svm_vcpu_{un}blocking() are called with preemption enabled, and avic_set_running() passes in vcpu->cpu. If the vCPU is preempted and scheduled in on a different CPU, avic_vcpu_load() will overwrite the vCPU's entry with the wrong CPU info. + +_______________________________________________ +linux-arm-kernel mailing list +linux-arm-kernel@lists.infradead.org +http://lists.infradead.org/mailman/listinfo/linux-arm-kernel diff --git a/a/content_digest b/N5/content_digest index 2623220..a3a0c73 100644 --- a/a/content_digest +++ b/N5/content_digest @@ -5,9 +5,42 @@ "ref\0YaUNBfJh35WXMV0M@google.com\0" "ref\0496c2fc6-26b0-9b5d-32f4-2f9e9dd6a064@redhat.com\0" "From\0Sean Christopherson <seanjc@google.com>\0" - "Subject\0[PATCH v2 11/43] KVM: Don't block+unblock when halt-polling is successful\0" + "Subject\0Re: [PATCH v2 11/43] KVM: Don't block+unblock when halt-polling is successful\0" "Date\0Mon, 29 Nov 2021 18:55:14 +0000\0" - "To\0kvm-riscv@lists.infradead.org\0" + "To\0Paolo Bonzini <pbonzini@redhat.com>\0" + "Cc\0Maxim Levitsky <mlevitsk@redhat.com>" + Marc Zyngier <maz@kernel.org> + Huacai Chen <chenhuacai@kernel.org> + Aleksandar Markovic <aleksandar.qemu.devel@gmail.com> + Paul Mackerras <paulus@ozlabs.org> + Anup Patel <anup.patel@wdc.com> + Paul Walmsley <paul.walmsley@sifive.com> + Palmer Dabbelt <palmer@dabbelt.com> + Albert Ou <aou@eecs.berkeley.edu> + Christian Borntraeger <borntraeger@de.ibm.com> + Janosch Frank <frankja@linux.ibm.com> + James Morse <james.morse@arm.com> + Alexandru Elisei <alexandru.elisei@arm.com> + Suzuki K Poulose <suzuki.poulose@arm.com> + Atish Patra <atish.patra@wdc.com> + David Hildenbrand <david@redhat.com> + Cornelia Huck <cohuck@redhat.com> + Claudio Imbrenda <imbrenda@linux.ibm.com> + Vitaly Kuznetsov <vkuznets@redhat.com> + Wanpeng Li <wanpengli@tencent.com> + Jim Mattson <jmattson@google.com> + Joerg Roedel <joro@8bytes.org> + linux-arm-kernel@lists.infradead.org + kvmarm@lists.cs.columbia.edu + linux-mips@vger.kernel.org + kvm@vger.kernel.org + kvm-ppc@vger.kernel.org + kvm-riscv@lists.infradead.org + linux-riscv@lists.infradead.org + linux-kernel@vger.kernel.org + David Matlack <dmatlack@google.com> + Oliver Upton <oupton@google.com> + " Jing Zhang <jingzhangos@google.com>\0" "\00:1\0" "b\0" "On Mon, Nov 29, 2021, Paolo Bonzini wrote:\n" @@ -37,6 +70,11 @@ "\n" "svm_vcpu_{un}blocking() are called with preemption enabled, and avic_set_running()\n" "passes in vcpu->cpu. If the vCPU is preempted and scheduled in on a different CPU,\n" - avic_vcpu_load() will overwrite the vCPU's entry with the wrong CPU info. + "avic_vcpu_load() will overwrite the vCPU's entry with the wrong CPU info.\n" + "\n" + "_______________________________________________\n" + "linux-arm-kernel mailing list\n" + "linux-arm-kernel@lists.infradead.org\n" + http://lists.infradead.org/mailman/listinfo/linux-arm-kernel -2f7e1fbe6ad6ab60274dd9cda63afd88c298d4648cc36aed95f9321d9e718a85 +a0306b7b8000b33110c6101057e8b812672de712154e97845047d609912a8047
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.