All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wolfram Sang <wsa@kernel.org>
To: "Lawrence,Wang" <lawrence.wang@nokia-sbell.com>
Cc: jarkko.nikula@linux.intel.com, andriy.shevchenko@linux.intel.com,
	mika.westerberg@linux.intel.com, linux-i2c@vger.kernel.org,
	linux-kernel@vger.kernel.org, Wang@wrlinb193.emea.nsn-net.net
Subject: Re: [PATCH] i2c: designware: Get HCNT/LCNT values from dts
Date: Mon, 29 Nov 2021 20:28:26 +0100	[thread overview]
Message-ID: <YaUp2pFmrDJhv4T+@kunai> (raw)
In-Reply-To: <20211115093556.7154-1-lawrence.wang@nokia-sbell.com>

[-- Attachment #1: Type: text/plain, Size: 352 bytes --]


> +	ret = device_property_read_u16_array(dev->dev, "dw-i2c-scl-timing",
> +					(u16 *)&i2c_scl_timing, sizeof(i2c_scl_timing)/sizeof(u16));

Putting hex values directly into DT is not a proper binding. They need
to be more generic. Sadly, I don't know the DW hardware, so I can't be
of much more help. But Andy already gave some pointers, as I saw.


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

      parent reply	other threads:[~2021-11-29 19:30 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-15  9:35 [PATCH] i2c: designware: Get HCNT/LCNT values from dts Lawrence,Wang
2021-11-15 10:19 ` Andy Shevchenko
2021-11-15 10:28   ` Andy Shevchenko
2021-11-15 10:41     ` Wang, Lawrence (NSB - CN/Hangzhou)
2021-11-15 11:01       ` Andy Shevchenko
2021-11-16  1:43         ` Wang, Lawrence (NSB - CN/Hangzhou)
2021-11-29 19:28 ` Wolfram Sang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YaUp2pFmrDJhv4T+@kunai \
    --to=wsa@kernel.org \
    --cc=Wang@wrlinb193.emea.nsn-net.net \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=jarkko.nikula@linux.intel.com \
    --cc=lawrence.wang@nokia-sbell.com \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mika.westerberg@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.