From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4DC53C433F5 for ; Mon, 29 Nov 2021 22:47:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=UVoVOHy/EWXm/EHrPazKj1DkguJdtha7hEmohADEifU=; b=QhpKOvVw+HZmhz Fyftyn6PIsLik2pev/ZpCG8tkjM+RJX9diMWHutw7jOXgoC05YC5lJpbKYHTSqd/RCCfgnbsU9xeI UpjbNHaTjLVWkI9qSo62YjRxWYGESx18LH7uGmIHAyzcb0UX4zkb/5iyZueXEnPMVvDhXHp3Kq9Hu lepSRLMo+/ZglMiytUDGTZNinwRNBVbZ4LUrCU9B4YTHCwZIRFH+r43+mAi2YuO12wzYVrdfQ4w3/ 3F3KxhK7njMidOmf7QUzt12iXOWrna3Spmadf8fp8+nURzzjI3a6SZgLb5BBYTawbr1dSDeoVVvzU 5TVX652oYtjc71xF9IdA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mrpQM-002wzr-6I; Mon, 29 Nov 2021 22:47:02 +0000 Received: from mail-ot1-f52.google.com ([209.85.210.52]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mrpQ1-002ws7-8T; Mon, 29 Nov 2021 22:46:42 +0000 Received: by mail-ot1-f52.google.com with SMTP id 47-20020a9d0332000000b005798ac20d72so27583245otv.9; Mon, 29 Nov 2021 14:46:40 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=vlaUIuTpfkQHFZYUbKS4f3lFAsn1jJAs7KRU7cm0X2I=; b=XNjRL5UbYV8cafKMEYh9/qO432aM1shMx1fNO9FOvaFUrc5/eh2XOZlUK2yFOCrBD/ VgjyIMhfVYI0dxN1fW8WyK9R6SV0QxmDqNnvOd5oPwb1LvaE3lIwaAFxfW2XxFSxXafu z4mCqPPtfVKcxbkpFNAqaNyFSF7/GSYPyYdRqltp88LHfXuTr8ziCnpteMQqV4/gj5iW rlxHKTGhJ6RSpyDHA0b4/NBcwcsc+52phUobassjIPx5879BOXxKOOZpiu2KMib919BH KbtQQso2ghtI3kV0cyQSq2SWzQcJAQWOPoVyCHwADGJK+YNHyns9B29qgg7siFkVVpTC Jo4w== X-Gm-Message-State: AOAM530D8+ikeo0hgolzNF/qem9tGHgpOcMKI6V8TXd+39BgxY6XW/jN wIlg1AFuBD7wXuje5nSmlA== X-Google-Smtp-Source: ABdhPJwjYUv7TStIwEgfVKtax+pxEAr4orFhSvEl5ThKh76p2DPoQYSgbkr5OqmDg1XgSEO47zntGA== X-Received: by 2002:a05:6830:1e25:: with SMTP id t5mr48290837otr.291.1638225999927; Mon, 29 Nov 2021 14:46:39 -0800 (PST) Received: from robh.at.kernel.org (66-90-148-213.dyn.grandenetworks.net. [66.90.148.213]) by smtp.gmail.com with ESMTPSA id q44sm2927209otv.80.2021.11.29.14.46.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Nov 2021 14:46:39 -0800 (PST) Received: (nullmailer pid 750903 invoked by uid 1000); Mon, 29 Nov 2021 22:46:38 -0000 Date: Mon, 29 Nov 2021 16:46:38 -0600 From: Rob Herring To: Sascha Hauer Cc: dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, kernel@pengutronix.de, Benjamin Gaignard , Michael Riesch , Sandy Huang , Heiko =?iso-8859-1?Q?St=FCbner?= , Peter Geis Subject: Re: [PATCH 04/12] drm/rockchip: dw_hdmi: add regulator support Message-ID: References: <20211117143347.314294-1-s.hauer@pengutronix.de> <20211117143347.314294-5-s.hauer@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20211117143347.314294-5-s.hauer@pengutronix.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211129_144641_325342_247D4F7A X-CRM114-Status: GOOD ( 17.10 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org On Wed, Nov 17, 2021 at 03:33:39PM +0100, Sascha Hauer wrote: > The RK3568 has HDMI_TX_AVDD0V9 and HDMI_TX_AVDD_1V8 supply inputs needed > for the HDMI port. add support for these to the driver for boards which > have them supplied by switchable regulators. > > Signed-off-by: Sascha Hauer > --- > .../display/rockchip/rockchip,dw-hdmi.yaml | 6 ++ Bindings should be a separate patch. Include this as part of adding RK3568 support to the binding. > drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c | 58 ++++++++++++++++++- > 2 files changed, 61 insertions(+), 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml b/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml > index 53fa42479d5b7..293b2cfbf739f 100644 > --- a/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml > +++ b/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml > @@ -28,6 +28,12 @@ properties: > reg-io-width: > const: 4 > > + avdd-0v9-supply: > + description: A 0.9V supply that powers up the SoC internal circuitry. > + > + avdd-1v8-supply: > + description: A 0.9V supply that powers up the SoC internal circuitry. 0.9V ??? > + > clocks: > minItems: 2 > items: _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DF588C433EF for ; Mon, 29 Nov 2021 22:48:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=t03LZnddjufoozmZC0MkapNHu//hxCf60XaXBM5uTnQ=; b=tQqUnIEzYWm6FE cnq3KOE6nQKe5r9q3Jnradt4iFSsdxMdwihHsHLHohaAETW+NE8hEjCxpyzj2+2qe7f6eTELFPjJf PqTbKzX2CqUq4icmIxMTl6TX7pOU4Zp2QOXHSppWgoPVgClg7SkQICA1yXa+6meELpwPJzWy1iDu0 Ea7E52oPY6K00AApM0E2lv1gQM4t9QkKZIiPXLsQncBkJgzKbX3QivbPbD3zd0qHR6BHtT2vvrtqO 2ZnSjMpKKlXqv5USj342BBzo2l4UDQkD+wCrd4HFwdp+NRYtSSDU+LuXDWrNNhyEpms1XuIWsLSXS ElPQkzq+2k1b40ImKFHQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mrpQ9-002wuI-CL; Mon, 29 Nov 2021 22:46:49 +0000 Received: from mail-ot1-f52.google.com ([209.85.210.52]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mrpQ1-002ws7-8T; Mon, 29 Nov 2021 22:46:42 +0000 Received: by mail-ot1-f52.google.com with SMTP id 47-20020a9d0332000000b005798ac20d72so27583245otv.9; Mon, 29 Nov 2021 14:46:40 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=vlaUIuTpfkQHFZYUbKS4f3lFAsn1jJAs7KRU7cm0X2I=; b=XNjRL5UbYV8cafKMEYh9/qO432aM1shMx1fNO9FOvaFUrc5/eh2XOZlUK2yFOCrBD/ VgjyIMhfVYI0dxN1fW8WyK9R6SV0QxmDqNnvOd5oPwb1LvaE3lIwaAFxfW2XxFSxXafu z4mCqPPtfVKcxbkpFNAqaNyFSF7/GSYPyYdRqltp88LHfXuTr8ziCnpteMQqV4/gj5iW rlxHKTGhJ6RSpyDHA0b4/NBcwcsc+52phUobassjIPx5879BOXxKOOZpiu2KMib919BH KbtQQso2ghtI3kV0cyQSq2SWzQcJAQWOPoVyCHwADGJK+YNHyns9B29qgg7siFkVVpTC Jo4w== X-Gm-Message-State: AOAM530D8+ikeo0hgolzNF/qem9tGHgpOcMKI6V8TXd+39BgxY6XW/jN wIlg1AFuBD7wXuje5nSmlA== X-Google-Smtp-Source: ABdhPJwjYUv7TStIwEgfVKtax+pxEAr4orFhSvEl5ThKh76p2DPoQYSgbkr5OqmDg1XgSEO47zntGA== X-Received: by 2002:a05:6830:1e25:: with SMTP id t5mr48290837otr.291.1638225999927; Mon, 29 Nov 2021 14:46:39 -0800 (PST) Received: from robh.at.kernel.org (66-90-148-213.dyn.grandenetworks.net. [66.90.148.213]) by smtp.gmail.com with ESMTPSA id q44sm2927209otv.80.2021.11.29.14.46.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Nov 2021 14:46:39 -0800 (PST) Received: (nullmailer pid 750903 invoked by uid 1000); Mon, 29 Nov 2021 22:46:38 -0000 Date: Mon, 29 Nov 2021 16:46:38 -0600 From: Rob Herring To: Sascha Hauer Cc: dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, kernel@pengutronix.de, Benjamin Gaignard , Michael Riesch , Sandy Huang , Heiko =?iso-8859-1?Q?St=FCbner?= , Peter Geis Subject: Re: [PATCH 04/12] drm/rockchip: dw_hdmi: add regulator support Message-ID: References: <20211117143347.314294-1-s.hauer@pengutronix.de> <20211117143347.314294-5-s.hauer@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20211117143347.314294-5-s.hauer@pengutronix.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211129_144641_325342_247D4F7A X-CRM114-Status: GOOD ( 17.10 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Nov 17, 2021 at 03:33:39PM +0100, Sascha Hauer wrote: > The RK3568 has HDMI_TX_AVDD0V9 and HDMI_TX_AVDD_1V8 supply inputs needed > for the HDMI port. add support for these to the driver for boards which > have them supplied by switchable regulators. > > Signed-off-by: Sascha Hauer > --- > .../display/rockchip/rockchip,dw-hdmi.yaml | 6 ++ Bindings should be a separate patch. Include this as part of adding RK3568 support to the binding. > drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c | 58 ++++++++++++++++++- > 2 files changed, 61 insertions(+), 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml b/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml > index 53fa42479d5b7..293b2cfbf739f 100644 > --- a/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml > +++ b/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml > @@ -28,6 +28,12 @@ properties: > reg-io-width: > const: 4 > > + avdd-0v9-supply: > + description: A 0.9V supply that powers up the SoC internal circuitry. > + > + avdd-1v8-supply: > + description: A 0.9V supply that powers up the SoC internal circuitry. 0.9V ??? > + > clocks: > minItems: 2 > items: _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 205FCC4332F for ; Mon, 29 Nov 2021 22:47:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235183AbhK2Wuh (ORCPT ); Mon, 29 Nov 2021 17:50:37 -0500 Received: from mail-ot1-f46.google.com ([209.85.210.46]:40783 "EHLO mail-ot1-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235237AbhK2Wt6 (ORCPT ); Mon, 29 Nov 2021 17:49:58 -0500 Received: by mail-ot1-f46.google.com with SMTP id v15-20020a9d604f000000b0056cdb373b82so27617047otj.7 for ; Mon, 29 Nov 2021 14:46:40 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=vlaUIuTpfkQHFZYUbKS4f3lFAsn1jJAs7KRU7cm0X2I=; b=Ejy1H7Oir3xOu/r6GKUCQa5vUXNY8MG/PkCMp8mH89uOgavJUkznKBzWW2oZE3dpSK 3bfJFw+l2hVAPFuP2QDVUOvOOehZsBVIIEKkHyO92D7UppS+sIFReTLVDoyO+BVW1oav x/YLcPCUuJda+UGUSTEmgWpkU4eTrhircuj22iCGnPtyE/N87SJzqhChjGRuLvj9XRAK t/B2yeNzk7T7Csur9mPNsw7xNf1xdP+pPw5m9za2gd8buqahdRwitEGHXLnAmcecrNNA Z8M16xG69gIegl27b/fBz33mqazGf33wOND6MDc9TgPvsrGf2yFBvQx1UFgf+uxAl3V4 EklQ== X-Gm-Message-State: AOAM530zVVWR/SCcolX2j2RNrQAi20ohQeMLbJK6Q+NZfXzDRVNaZnXq TGKRVj1qnrCRJ+Mn05Ulbl5Fh12YEA== X-Google-Smtp-Source: ABdhPJwjYUv7TStIwEgfVKtax+pxEAr4orFhSvEl5ThKh76p2DPoQYSgbkr5OqmDg1XgSEO47zntGA== X-Received: by 2002:a05:6830:1e25:: with SMTP id t5mr48290837otr.291.1638225999927; Mon, 29 Nov 2021 14:46:39 -0800 (PST) Received: from robh.at.kernel.org (66-90-148-213.dyn.grandenetworks.net. [66.90.148.213]) by smtp.gmail.com with ESMTPSA id q44sm2927209otv.80.2021.11.29.14.46.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Nov 2021 14:46:39 -0800 (PST) Received: (nullmailer pid 750903 invoked by uid 1000); Mon, 29 Nov 2021 22:46:38 -0000 Date: Mon, 29 Nov 2021 16:46:38 -0600 From: Rob Herring To: Sascha Hauer Cc: dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, kernel@pengutronix.de, Benjamin Gaignard , Michael Riesch , Sandy Huang , Heiko =?iso-8859-1?Q?St=FCbner?= , Peter Geis Subject: Re: [PATCH 04/12] drm/rockchip: dw_hdmi: add regulator support Message-ID: References: <20211117143347.314294-1-s.hauer@pengutronix.de> <20211117143347.314294-5-s.hauer@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211117143347.314294-5-s.hauer@pengutronix.de> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Wed, Nov 17, 2021 at 03:33:39PM +0100, Sascha Hauer wrote: > The RK3568 has HDMI_TX_AVDD0V9 and HDMI_TX_AVDD_1V8 supply inputs needed > for the HDMI port. add support for these to the driver for boards which > have them supplied by switchable regulators. > > Signed-off-by: Sascha Hauer > --- > .../display/rockchip/rockchip,dw-hdmi.yaml | 6 ++ Bindings should be a separate patch. Include this as part of adding RK3568 support to the binding. > drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c | 58 ++++++++++++++++++- > 2 files changed, 61 insertions(+), 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml b/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml > index 53fa42479d5b7..293b2cfbf739f 100644 > --- a/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml > +++ b/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml > @@ -28,6 +28,12 @@ properties: > reg-io-width: > const: 4 > > + avdd-0v9-supply: > + description: A 0.9V supply that powers up the SoC internal circuitry. > + > + avdd-1v8-supply: > + description: A 0.9V supply that powers up the SoC internal circuitry. 0.9V ??? > + > clocks: > minItems: 2 > items: From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 666C4C433F5 for ; Mon, 29 Nov 2021 22:46:42 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A302B6E0DA; Mon, 29 Nov 2021 22:46:41 +0000 (UTC) Received: from mail-ot1-f43.google.com (mail-ot1-f43.google.com [209.85.210.43]) by gabe.freedesktop.org (Postfix) with ESMTPS id A91776E0DA for ; Mon, 29 Nov 2021 22:46:40 +0000 (UTC) Received: by mail-ot1-f43.google.com with SMTP id w6-20020a9d77c6000000b0055e804fa524so27604292otl.3 for ; Mon, 29 Nov 2021 14:46:40 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=vlaUIuTpfkQHFZYUbKS4f3lFAsn1jJAs7KRU7cm0X2I=; b=j+csvo7cUevMNO6UxiLEZTbenXpUKpcMi68r5ZcVbaYoEIvZSzRCwE/0RMC9qM0nAA PKi9HORMFtPuSSDXVlV0oJRRPXDRXgEhVjxWNpi1LWOIwjvRSs+fNHfEbwy2z/C44umO MUEtixALeEikpPd4D27EtetXNwT4+zOdFyebLXa5MirYEbxD/IeqpjFn2Cs8cOmMsfJS zhq4fMe2C6y2vnc43btRHibPT2z/1YGxyuM+FMnj9gGnlHWv3qZE+JyT8sOVFphrUIcS UJMZQwEaRqmc8V1bEYqp6eVeoZC3gtl1NGD7+HpXrRwfuYkerfmch5SJV62vn/8XxxFj fZRA== X-Gm-Message-State: AOAM532MXcdnLKowsnlU1QqSsLW2RZ/f0PLUCrYjzxy8F//htdYQH0iC a5/E4Pk2AQs7lbjnINhL5g== X-Google-Smtp-Source: ABdhPJwjYUv7TStIwEgfVKtax+pxEAr4orFhSvEl5ThKh76p2DPoQYSgbkr5OqmDg1XgSEO47zntGA== X-Received: by 2002:a05:6830:1e25:: with SMTP id t5mr48290837otr.291.1638225999927; Mon, 29 Nov 2021 14:46:39 -0800 (PST) Received: from robh.at.kernel.org (66-90-148-213.dyn.grandenetworks.net. [66.90.148.213]) by smtp.gmail.com with ESMTPSA id q44sm2927209otv.80.2021.11.29.14.46.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Nov 2021 14:46:39 -0800 (PST) Received: (nullmailer pid 750903 invoked by uid 1000); Mon, 29 Nov 2021 22:46:38 -0000 Date: Mon, 29 Nov 2021 16:46:38 -0600 From: Rob Herring To: Sascha Hauer Subject: Re: [PATCH 04/12] drm/rockchip: dw_hdmi: add regulator support Message-ID: References: <20211117143347.314294-1-s.hauer@pengutronix.de> <20211117143347.314294-5-s.hauer@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211117143347.314294-5-s.hauer@pengutronix.de> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Benjamin Gaignard , Sandy Huang , dri-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org, Michael Riesch , kernel@pengutronix.de, Peter Geis , linux-arm-kernel@lists.infradead.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Wed, Nov 17, 2021 at 03:33:39PM +0100, Sascha Hauer wrote: > The RK3568 has HDMI_TX_AVDD0V9 and HDMI_TX_AVDD_1V8 supply inputs needed > for the HDMI port. add support for these to the driver for boards which > have them supplied by switchable regulators. > > Signed-off-by: Sascha Hauer > --- > .../display/rockchip/rockchip,dw-hdmi.yaml | 6 ++ Bindings should be a separate patch. Include this as part of adding RK3568 support to the binding. > drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c | 58 ++++++++++++++++++- > 2 files changed, 61 insertions(+), 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml b/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml > index 53fa42479d5b7..293b2cfbf739f 100644 > --- a/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml > +++ b/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml > @@ -28,6 +28,12 @@ properties: > reg-io-width: > const: 4 > > + avdd-0v9-supply: > + description: A 0.9V supply that powers up the SoC internal circuitry. > + > + avdd-1v8-supply: > + description: A 0.9V supply that powers up the SoC internal circuitry. 0.9V ??? > + > clocks: > minItems: 2 > items: