From: Wolfram Sang <wsa@kernel.org>
To: Alain Volmat <alain.volmat@foss.st.com>
Cc: linux-i2c@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
pierre-yves.mordret@foss.st.com
Subject: Re: [PATCH] i2c: stm32f7: remove noisy and imprecise log messages
Date: Tue, 30 Nov 2021 22:41:37 +0100 [thread overview]
Message-ID: <YaaakSa16Dun6b+h@kunai> (raw)
In-Reply-To: <20211130162534.GA813993@gnbcxd0016.gnb.st.com>
[-- Attachment #1: Type: text/plain, Size: 555 bytes --]
> - looking at this area of code again, it appears that the function stm32f7_i2c_release_bus
> is ALWAYS returning 0. So it should actually be a void function. I thus
> propose, if you agree with that, that I propose, and apply a patch PRIOR to your/this patch
> to change that and remove the error checking of the stm32f7_i2c_release_bus function since it is useless.
> Is that fine for you ?
Well, I'd think we can also apply this patch first and then make the
function void, but I don't really care about the order. But we should do
both, I agree.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2021-11-30 21:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-30 9:38 [PATCH] i2c: stm32f7: remove noisy and imprecise log messages Wolfram Sang
2021-11-30 16:25 ` Alain Volmat
2021-11-30 21:41 ` Wolfram Sang [this message]
2021-12-01 10:59 ` Alain Volmat
2021-12-01 11:04 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YaaakSa16Dun6b+h@kunai \
--to=wsa@kernel.org \
--cc=alain.volmat@foss.st.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=pierre-yves.mordret@foss.st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.