From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2093FC433F5 for ; Tue, 30 Nov 2021 22:41:22 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 829F36E1B8; Tue, 30 Nov 2021 22:41:16 +0000 (UTC) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3E9576E079; Tue, 30 Nov 2021 22:41:15 +0000 (UTC) X-IronPort-AV: E=McAfee;i="6200,9189,10184"; a="223211950" X-IronPort-AV: E=Sophos;i="5.87,277,1631602800"; d="scan'208";a="223211950" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Nov 2021 14:41:14 -0800 X-IronPort-AV: E=Sophos;i="5.87,277,1631602800"; d="scan'208";a="512390874" Received: from ppangx-mobl.amr.corp.intel.com (HELO intel.com) ([10.252.53.36]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Nov 2021 14:41:11 -0800 Date: Wed, 1 Dec 2021 00:41:08 +0200 From: Andi Shyti To: Lucas De Marchi Message-ID: References: <20211128110926.2569-1-andi.shyti@linux.intel.com> <20211128110926.2569-3-andi.shyti@linux.intel.com> <20211130210730.wbuy3znor6jel3cc@ldmartin-desk2> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211130210730.wbuy3znor6jel3cc@ldmartin-desk2> Subject: Re: [Intel-gfx] [PATCH v4 2/2] drm/i915: Use to_root_gt() to refer to the root tile X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?utf-8?Q?Michal=C5=82Winiarski?= , Intel GFX , DRI Devel , Chris Wilson Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Hi Lucas, fist of all thanks for taking a look at this, I was eagerly waiting for reviewers. On Tue, Nov 30, 2021 at 01:07:30PM -0800, Lucas De Marchi wrote: > On Sun, Nov 28, 2021 at 01:09:26PM +0200, Andi Shyti wrote: > > Starting from a patch from Matt to_root_gt() returns the > > reference to the root tile in order to abstract the root tile > > from th callers. > > > > Being the root tile identified as tile '0', embed the id in the > > name so that i915->gt becomes i915->gt0. > > > > The renaming has been mostly done with the following command and > > some manual fixes. > > > > sed -i -e sed -i 's/\&i915\->gt\./\&to_root_gt(i915)\->/g' \ > > -e sed -i 's/\&dev_priv\->gt\./\&to_root_gt(dev_priv)\->/g' \ > > -e 's/\&dev_priv\->gt/to_root_gt(dev_priv)/g' \ > > -e 's/\&i915\->gt/to_root_gt(i915)/g' \ > > -e 's/dev_priv\->gt\./to_root_gt(dev_priv)\->/g' \ > > -e 's/i915\->gt\./to_root_gt(i915)\->/g' \ > > `find drivers/gpu/drm/i915/ -name *.[ch]` > > > > Two small changes have been added to this commit: > > > > 1. intel_reset_gpu() in intel_display.c retreives the gt from > > to_scanout_gt() > > 2. in set_scheduler_caps() the gt is taken from the engine and > > not from i915. > > Ideally the non-automatic changes should be in separate patches, before > the ones that can be done by automation. Because then it becomes easier > to apply the final result without conflicts. OK > This is quite a big diff to merge in one go. Looking at the pending > patches from Michal however I see he had similar changes, split in > sensible chunks.. Could you split your version like that? at least > gt/gem and display would be good to have separate. Or sync with Michal > on how to proceed with these versions Here are his patches: > > drm/i915: Remove i915->ggtt > drm/i915: Use to_gt() helper for GGTT accesses > drm/i915: Use to_gt() helper > drm/i915/gvt: Use to_gt() helper > drm/i915/gem: Use to_gt() helper > drm/i915/gt: Use to_gt() helper > drm/i915/display: Use to_gt() helper > drm/i915: Introduce to_gt() helper I understand... will follow this approach. > This first patch also removed the `struct intel_gt *gt = to_gt(pool)`, > that would otherwise be a leftover in drivers/gpu/drm/i915/gt/intel_gt_buffer_pool.c One difference from Michal patch is that I am not using the wrapper to_gt(...) but to_root_gt(...) which was introduced by Matt. To me sounds more meaningful as it specifies that we are really looking for the root tile and not any tile. Thanks again, Andi From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6FD21C433EF for ; Tue, 30 Nov 2021 22:41:17 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id ED0116E079; Tue, 30 Nov 2021 22:41:15 +0000 (UTC) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3E9576E079; Tue, 30 Nov 2021 22:41:15 +0000 (UTC) X-IronPort-AV: E=McAfee;i="6200,9189,10184"; a="223211950" X-IronPort-AV: E=Sophos;i="5.87,277,1631602800"; d="scan'208";a="223211950" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Nov 2021 14:41:14 -0800 X-IronPort-AV: E=Sophos;i="5.87,277,1631602800"; d="scan'208";a="512390874" Received: from ppangx-mobl.amr.corp.intel.com (HELO intel.com) ([10.252.53.36]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Nov 2021 14:41:11 -0800 Date: Wed, 1 Dec 2021 00:41:08 +0200 From: Andi Shyti To: Lucas De Marchi Subject: Re: [PATCH v4 2/2] drm/i915: Use to_root_gt() to refer to the root tile Message-ID: References: <20211128110926.2569-1-andi.shyti@linux.intel.com> <20211128110926.2569-3-andi.shyti@linux.intel.com> <20211130210730.wbuy3znor6jel3cc@ldmartin-desk2> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211130210730.wbuy3znor6jel3cc@ldmartin-desk2> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?utf-8?Q?Michal=C5=82Winiarski?= , Andi Shyti , Tvrtko Ursulin , Intel GFX , DRI Devel , Chris Wilson , Andi Shyti , Rodrigo Vivi Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Lucas, fist of all thanks for taking a look at this, I was eagerly waiting for reviewers. On Tue, Nov 30, 2021 at 01:07:30PM -0800, Lucas De Marchi wrote: > On Sun, Nov 28, 2021 at 01:09:26PM +0200, Andi Shyti wrote: > > Starting from a patch from Matt to_root_gt() returns the > > reference to the root tile in order to abstract the root tile > > from th callers. > > > > Being the root tile identified as tile '0', embed the id in the > > name so that i915->gt becomes i915->gt0. > > > > The renaming has been mostly done with the following command and > > some manual fixes. > > > > sed -i -e sed -i 's/\&i915\->gt\./\&to_root_gt(i915)\->/g' \ > > -e sed -i 's/\&dev_priv\->gt\./\&to_root_gt(dev_priv)\->/g' \ > > -e 's/\&dev_priv\->gt/to_root_gt(dev_priv)/g' \ > > -e 's/\&i915\->gt/to_root_gt(i915)/g' \ > > -e 's/dev_priv\->gt\./to_root_gt(dev_priv)\->/g' \ > > -e 's/i915\->gt\./to_root_gt(i915)\->/g' \ > > `find drivers/gpu/drm/i915/ -name *.[ch]` > > > > Two small changes have been added to this commit: > > > > 1. intel_reset_gpu() in intel_display.c retreives the gt from > > to_scanout_gt() > > 2. in set_scheduler_caps() the gt is taken from the engine and > > not from i915. > > Ideally the non-automatic changes should be in separate patches, before > the ones that can be done by automation. Because then it becomes easier > to apply the final result without conflicts. OK > This is quite a big diff to merge in one go. Looking at the pending > patches from Michal however I see he had similar changes, split in > sensible chunks.. Could you split your version like that? at least > gt/gem and display would be good to have separate. Or sync with Michal > on how to proceed with these versions Here are his patches: > > drm/i915: Remove i915->ggtt > drm/i915: Use to_gt() helper for GGTT accesses > drm/i915: Use to_gt() helper > drm/i915/gvt: Use to_gt() helper > drm/i915/gem: Use to_gt() helper > drm/i915/gt: Use to_gt() helper > drm/i915/display: Use to_gt() helper > drm/i915: Introduce to_gt() helper I understand... will follow this approach. > This first patch also removed the `struct intel_gt *gt = to_gt(pool)`, > that would otherwise be a leftover in drivers/gpu/drm/i915/gt/intel_gt_buffer_pool.c One difference from Michal patch is that I am not using the wrapper to_gt(...) but to_root_gt(...) which was introduced by Matt. To me sounds more meaningful as it specifies that we are really looking for the root tile and not any tile. Thanks again, Andi