From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Vincent Whitchurch <vincent.whitchurch@axis.com>
Cc: Alessandro Zummo <a.zummo@towertech.it>,
kernel@axis.com, linux-rtc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rtc: pcf8523: fix alarm interrupt disabling
Date: Wed, 1 Dec 2021 00:19:12 +0100 [thread overview]
Message-ID: <YaaxcFn/di3wCnO1@piout.net> (raw)
In-Reply-To: <20211103152253.22844-1-vincent.whitchurch@axis.com>
Hello,
On 03/11/2021 16:22:52+0100, Vincent Whitchurch wrote:
> Fix the driver to actually disable the IRQ and not overwrite other bits
> in the CONTROL_1 register when it is asked to disable the alarm
> interrupt.
>
> Compile-tested only.
>
> Fixes: 13e37b7fb75dfaeb4 ("rtc: pcf8523: add alarm support")
> Signed-off-by: Vincent Whitchurch <vincent.whitchurch@axis.com>
> ---
> drivers/rtc/rtc-pcf8523.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/rtc/rtc-pcf8523.c b/drivers/rtc/rtc-pcf8523.c
> index 8b6fb20774bf..e26477267451 100644
> --- a/drivers/rtc/rtc-pcf8523.c
> +++ b/drivers/rtc/rtc-pcf8523.c
> @@ -347,7 +347,7 @@ static int pcf8523_irq_enable(struct device *dev, unsigned int enabled)
> if (err < 0)
> return err;
>
> - value &= PCF8523_CONTROL1_AIE;
> + value &= ~PCF8523_CONTROL1_AIE;
>
I was going to apply that but it seems this was fixed by:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit?id=91f3849d956d58073ef55e01f2e8871dc30847a5
> if (enabled)
> value |= PCF8523_CONTROL1_AIE;
> --
> 2.28.0
>
--
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2021-11-30 23:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-03 15:22 [PATCH] rtc: pcf8523: fix alarm interrupt disabling Vincent Whitchurch
2021-11-30 23:19 ` Alexandre Belloni [this message]
2021-12-01 8:49 ` Vincent Whitchurch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YaaxcFn/di3wCnO1@piout.net \
--to=alexandre.belloni@bootlin.com \
--cc=a.zummo@towertech.it \
--cc=kernel@axis.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=vincent.whitchurch@axis.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.