From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Serge Semin <fancer.lancer@gmail.com>
Cc: Serge Semin <Sergey.Semin@baikalelectronics.ru>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
Hoan Tran <hoan@os.amperecomputing.com>,
Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <brgl@bgdev.pl>
Subject: Re: [PATCH v1 1/1] gpio: dwapb: clarify usage of the register file version
Date: Wed, 1 Dec 2021 15:13:03 +0200 [thread overview]
Message-ID: <Yad032NkgdpL8eSm@smile.fi.intel.com> (raw)
In-Reply-To: <20211201122734.o7m5xb6zh4ngjpo7@mobilestation>
On Wed, Dec 01, 2021 at 03:27:34PM +0300, Serge Semin wrote:
> On Tue, Nov 30, 2021 at 06:49:56PM +0200, Andy Shevchenko wrote:
> > First of all, it's obvious that different versions can't be provided
> > simultaneously. Hence, versions can't be bit masks.
> >
> > Second, due to above we have to mask out the version field in the flags
> > and only that can be evaluated against the certain version.
> >
> > Clarify all above by:
> > - introducing GPIO_REG_OFFSET_V1 and GPIO_REG_OFFSET_MASK
> > - replacing conditional to mask out bits and compare to a version
> >
> > Luckily there is no functional change (at least intended), so no need
> > to backport this.
>
> Seems reasonable. Thanks.
> Acked-by: Serge Semin <fancer.lancer@gmail.com>
Pushed to my review and testing queue, thanks!
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2021-12-01 13:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-30 16:49 [PATCH v1 1/1] gpio: dwapb: clarify usage of the register file version Andy Shevchenko
2021-12-01 8:29 ` Bartosz Golaszewski
2021-12-01 13:12 ` Andy Shevchenko
2021-12-01 12:27 ` Serge Semin
2021-12-01 13:13 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yad032NkgdpL8eSm@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=Sergey.Semin@baikalelectronics.ru \
--cc=brgl@bgdev.pl \
--cc=fancer.lancer@gmail.com \
--cc=hoan@os.amperecomputing.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.