From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Florian Westphal <fw@strlen.de>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nft 0/3] netlink_delinearize cleanups
Date: Wed, 1 Dec 2021 14:10:13 +0100 [thread overview]
Message-ID: <Yad0NcCxBgserhOp@salvia> (raw)
In-Reply-To: <20211201115956.13252-1-fw@strlen.de>
On Wed, Dec 01, 2021 at 12:59:53PM +0100, Florian Westphal wrote:
> No indended behavioural changes here.
> binop postprocessing has been extended a lot and in a few places
> things only work because expr->map and expr->left alias to the same
> location.
LGTM.
We should add more type sanitization to expressions at some point, the
risk is that this might break a few things not covered by tests though.
prev parent reply other threads:[~2021-12-01 13:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-01 11:59 [PATCH nft 0/3] netlink_delinearize cleanups Florian Westphal
2021-12-01 11:59 ` [PATCH nft 1/3] netlink_delinearize: use correct member type Florian Westphal
2021-12-01 11:59 ` [PATCH nft 2/3] netlink_delinearize: rename misleading variable Florian Westphal
2021-12-01 11:59 ` [PATCH nft 3/3] netlink_delinearize: binop: make accesses to expr->left/right conditional Florian Westphal
2021-12-01 13:10 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yad0NcCxBgserhOp@salvia \
--to=pablo@netfilter.org \
--cc=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.