From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Kees Cook <keescook@chromium.org>
Cc: Luis Chamberlain <mcgrof@kernel.org>,
Jessica Yu <jeyu@kernel.org>,
linux-kernel@vger.kernel.org, linux-modules@vger.kernel.org
Subject: Re: [PATCH] module: add in-kernel support for decompressing
Date: Wed, 1 Dec 2021 12:19:08 -0800 [thread overview]
Message-ID: <YafYvA5JWMgb6PVy@google.com> (raw)
In-Reply-To: <202112011112.83416FCA2C@keescook>
On Wed, Dec 01, 2021 at 11:24:35AM -0800, Kees Cook wrote:
> On Sat, Nov 27, 2021 at 09:48:22PM -0800, Dmitry Torokhov wrote:
> > /* Flags for sys_finit_module: */
> > #define MODULE_INIT_IGNORE_MODVERSIONS 1
> > #define MODULE_INIT_IGNORE_VERMAGIC 2
> > +#define MODULE_INIT_COMPRESSED_DATA 4
>
> bikeshedding: adding "_DATA" seems redundant/misleading? The entire
> module is compressed, so maybe call it just MODULE_INIT_COMPRESSED ?
OK, or maybe MODULE_INIT_COMPRESSED_FILE since we are indeed dealing
with a file?
Thanks.
--
Dmitry
next prev parent reply other threads:[~2021-12-01 20:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-28 5:48 [PATCH] module: add in-kernel support for decompressing Dmitry Torokhov
2021-12-01 19:24 ` Kees Cook
2021-12-01 20:19 ` Dmitry Torokhov [this message]
2021-12-02 8:14 ` Kees Cook
2021-12-03 1:01 ` Luis Chamberlain
2021-12-03 21:06 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YafYvA5JWMgb6PVy@google.com \
--to=dmitry.torokhov@gmail.com \
--cc=jeyu@kernel.org \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-modules@vger.kernel.org \
--cc=mcgrof@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.