From: Greg KH <gregkh@linuxfoundation.org>
To: Oleksij Rempel <o.rempel@pengutronix.de>
Cc: stable@vger.kernel.org,
Zhang Changzhong <zhangchangzhong@huawei.com>,
Marc Kleine-Budde <mkl@pengutronix.de>
Subject: Re: [PATCH v1] can: j1939: j1939_tp_cmd_recv(): check the dst address of TP.CM_BAM
Date: Thu, 2 Dec 2021 16:35:43 +0100 [thread overview]
Message-ID: <Yajnz5OhwHyCfFaq@kroah.com> (raw)
In-Reply-To: <20211201102549.3079360-1-o.rempel@pengutronix.de>
On Wed, Dec 01, 2021 at 11:25:49AM +0100, Oleksij Rempel wrote:
> From: Zhang Changzhong <zhangchangzhong@huawei.com>
>
> commit 164051a6ab5445bd97f719f50b16db8b32174269 upstream.
>
> The TP.CM_BAM message must be sent to the global address [1], so add a
> check to drop TP.CM_BAM sent to a non-global address.
>
> Without this patch, the receiver will treat the following packets as
> normal RTS/CTS transport:
> 18EC0102#20090002FF002301
> 18EB0102#0100000000000000
> 18EB0102#020000FFFFFFFFFF
>
> [1] SAE-J1939-82 2015 A.3.3 Row 1.
>
> Fixes: 9d71dd0c7009 ("can: add support of SAE J1939 protocol")
> Link: https://lore.kernel.org/all/1635431907-15617-4-git-send-email-zhangchangzhong@huawei.com
> Cc: stable@vger.kernel.org
> Signed-off-by: Zhang Changzhong <zhangchangzhong@huawei.com>
> Acked-by: Oleksij Rempel <o.rempel@pengutronix.de>
> Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
> ---
> changes:
> - rebase against v5.10.82
Now queued up, thanks! Can you also do this for 5.4.y?
greg k-h
next prev parent reply other threads:[~2021-12-02 15:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-01 10:25 [PATCH v1] can: j1939: j1939_tp_cmd_recv(): check the dst address of TP.CM_BAM Oleksij Rempel
2021-12-02 15:35 ` Greg KH [this message]
2021-12-02 15:54 ` Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yajnz5OhwHyCfFaq@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=mkl@pengutronix.de \
--cc=o.rempel@pengutronix.de \
--cc=stable@vger.kernel.org \
--cc=zhangchangzhong@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.