From: Greg KH <gregkh@linuxfoundation.org>
To: Ameer Hamza <amhamza.mgc@gmail.com>
Cc: arve@android.com, tkjos@android.com, maco@android.com,
joel@joelfernandes.org, christian@brauner.io,
Hridya Valsaraju <hridya@google.com>,
Suren Baghdasaryan <surenb@google.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] binder: fixed coverity warning by moving pr_warn outside lock
Date: Sat, 4 Dec 2021 10:00:32 +0100 [thread overview]
Message-ID: <YasuMNXHlJEKNSwX@kroah.com> (raw)
In-Reply-To: <CANAWnNyyBR3EEtT=SecqGQsc+tnJi6GiqrW0xkqRn5jrV7CpDA@mail.gmail.com>
A: http://en.wikipedia.org/wiki/Top_post
Q: Were do I find info about this thing called top-posting?
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?
A: No.
Q: Should I include quotations after my reply?
http://daringfireball.net/2007/07/on_top
On Sat, Dec 04, 2021 at 01:50:44PM +0500, Ameer Hamza wrote:
> Thank you Greg for your response. The link to Coverity warning:
> https://scan5.coverity.com/reports.htm#v56991/p10063/fileInstanceId=204668511&defectInstanceId=52305699&mergedDefectId=1494148
That link does not seem to be public. What project are you looking at?
> I have seen similar warnings if the print operation is used inside a lock,
> i.e., Coverity speculates a possible deadlock scenario, which might be a
> false positive because internal printk implementation uses a separate lock.
When dealing with Coverity, it is up to you to determine if what it says
is actually true before sending out patches for it, due to the HUGE
number of false-positives it spits out.
thanks,
greg k-h
next prev parent reply other threads:[~2021-12-04 9:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-03 20:50 [PATCH] binder: fixed coverity warning by moving pr_warn outside lock Ameer Hamza
2021-12-04 7:57 ` Greg KH
[not found] ` <CANAWnNyyBR3EEtT=SecqGQsc+tnJi6GiqrW0xkqRn5jrV7CpDA@mail.gmail.com>
2021-12-04 9:00 ` Greg KH [this message]
2021-12-04 10:34 ` Ameer Hamza
2021-12-04 10:42 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YasuMNXHlJEKNSwX@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=amhamza.mgc@gmail.com \
--cc=arve@android.com \
--cc=christian@brauner.io \
--cc=hridya@google.com \
--cc=joel@joelfernandes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maco@android.com \
--cc=surenb@google.com \
--cc=tkjos@android.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.