All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: "Russell King (Oracle)" <linux@armlinux.org.uk>
Cc: Yinbo Zhu <zhuyinbo@loongson.cn>,
	Heiner Kallweit <hkallweit1@gmail.com>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-kbuild@vger.kernel.org,
	"David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>,
	Masahiro Yamada <masahiroy@kernel.org>,
	Michal Marek <michal.lkml@markovi.net>,
	Nick Desaulniers <ndesaulniers@google.com>
Subject: Re: [PATCH v3 1/2] modpost: file2alias: make mdio alias configure match mdio uevent
Date: Sun, 5 Dec 2021 16:56:44 +0100	[thread overview]
Message-ID: <YazhPOIIzpl43tzq@lunn.ch> (raw)
In-Reply-To: <YavYM2cs0RuY0JdM@shell.armlinux.org.uk>

> The modalias string provided in the uevent sysfs file does not conform
> to the format used in PHY driver modules. One of the reasons is that
> udev loading of PHY driver modules has not been an expected use case.
> 
> This patch changes the MODALIAS entry for only PHY devices from:
> 	MODALIAS=of:Nethernet-phyT(null)
> to:
> 	MODALIAS=mdio:00000000001000100001010100010011

Hi Russell

You patch looks good for the straight forward cases.

What happens in the case of

        ethernet-phy@0 {
            compatible = "ethernet-phy-ieee802.3-c45";


Does this get appended to the end, or does it overwrite?

     Andrew

  reply	other threads:[~2021-12-05 15:56 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-30  8:21 [PATCH v3 1/2] modpost: file2alias: make mdio alias configure match mdio uevent Yinbo Zhu
2021-11-30  8:21 ` [PATCH v3 2/2] net: mdio: rework mdio_uevent for mdio ethernet phy device Yinbo Zhu
2021-11-30  9:13   ` Russell King (Oracle)
2021-11-30  9:13 ` [PATCH v3 1/2] modpost: file2alias: make mdio alias configure match mdio uevent Russell King (Oracle)
     [not found]   ` <ea3f6904-c610-0ee6-fbab-913ba6ae36c5@loongson.cn>
2021-12-04  9:38     ` Russell King (Oracle)
2021-12-04 21:05       ` Russell King (Oracle)
2021-12-05 15:56         ` Andrew Lunn [this message]
2021-12-05 19:02           ` Russell King (Oracle)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YazhPOIIzpl43tzq@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=hkallweit1@gmail.com \
    --cc=kuba@kernel.org \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=masahiroy@kernel.org \
    --cc=michal.lkml@markovi.net \
    --cc=ndesaulniers@google.com \
    --cc=netdev@vger.kernel.org \
    --cc=zhuyinbo@loongson.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.