From: Greg KH <gregkh@linuxfoundation.org>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: "stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: Re: [PATCH v4.19 1/2] mac80211: mark TX-during-stop for TX in in_reconfig
Date: Sat, 18 Dec 2021 00:36:18 +0100 [thread overview]
Message-ID: <Yb0e8mSZZT0jxgSl@kroah.com> (raw)
In-Reply-To: <3ce00af3568e08d25b88ba9c7d27638d95c95536.camel@sipsolutions.net>
On Fri, Dec 17, 2021 at 09:42:21PM +0100, Johannes Berg wrote:
> On Fri, 2021-12-17 at 20:35 +0000, Johannes Berg wrote:
> >
> > I'm not sure why you say it doesn't apply - it did for me?
> >
>
> Oh, I'm an idiot, it doesn't *compile* afterwards since
> IEEE80211_TXQ_STOP_NETIF_TX doesn't exist yet.
>
> Let's ignore this patch for now, but please take 2/2.
>
> I'll have to think if we even want to introduce this on the old kernels,
> the bug that was reported required a firmware crash in the first place,
> and it was reported on iwlwifi which doesn't even use TXQs on 4.19 yet.
Yeah, I don't think it's needed, but as it was marked to go back really
far, I wanted to give you the option to do so or not.
Thanks for the 2/2 patch, I'll queue it up when I get a chance tomorrow.
greg k-h
next prev parent reply other threads:[~2021-12-17 23:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-17 20:35 [PATCH v4.19 1/2] mac80211: mark TX-during-stop for TX in in_reconfig Johannes Berg
2021-12-17 20:35 ` [PATCH v4.19 2/2] mac80211: validate extended element ID is present Johannes Berg
2021-12-17 20:42 ` [PATCH v4.19 1/2] mac80211: mark TX-during-stop for TX in in_reconfig Johannes Berg
2021-12-17 23:36 ` Greg KH [this message]
2021-12-18 8:56 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yb0e8mSZZT0jxgSl@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=johannes@sipsolutions.net \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.