All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Theodore Ts'o" <tytso@mit.edu>
To: Eric Biggers <ebiggers@kernel.org>
Cc: Ext4 Developers List <linux-ext4@vger.kernel.org>,
	Leah Rumancik <leah.rumancik@gmail.com>
Subject: Re: [PATCH] test-appliance: add ext4/050 to encrypt.exclude
Date: Sat, 18 Dec 2021 23:05:01 -0500	[thread overview]
Message-ID: <Yb6vbf6M+EYMXvQG@mit.edu> (raw)
In-Reply-To: <Yb6XEo/RcXEZxSai@quark.localdomain>

On Sat, Dec 18, 2021 at 08:21:06PM -0600, Eric Biggers wrote:
> On Fri, Dec 17, 2021 at 11:08:14PM -0500, Theodore Ts'o wrote:
> > The ext4/050 test can't handle encrypted directories, so skip it for
> > now.
> > 
> > Signed-off-by: Theodore Ts'o <tytso@mit.edu>
> > ---
> >  .../test-appliance/files/root/fs/ext4/cfg/encrypt.exclude    | 5 +++++
> >  1 file changed, 5 insertions(+)
> > 
> > diff --git a/kvm-xfstests/test-appliance/files/root/fs/ext4/cfg/encrypt.exclude b/kvm-xfstests/test-appliance/files/root/fs/ext4/cfg/encrypt.exclude
> > index f3c7a959..21a8b45f 100644
> > --- a/kvm-xfstests/test-appliance/files/root/fs/ext4/cfg/encrypt.exclude
> > +++ b/kvm-xfstests/test-appliance/files/root/fs/ext4/cfg/encrypt.exclude
> > @@ -12,6 +12,11 @@ ext4/028
> >  # file systems with encryption enabled can't be mounted with ext3
> >  ext4/044
> >  
> > +# This test to make sure ext4 directory entries are appropriately
> > +# wiped after a file is deleted, or after htree operations is
> > +# incompatible with an encrypted directory.
> > +ext4/048
> 
> The commit message says ext4/050, but the test added to the list is ext4/048.
> Is ext4/048 the one intended?

Yes, it's the commit message that was incorrect.  Thanks for pointing
that out.  I'll fix the commit description in my tree.

     	   	    	       		   - Ted

      reply	other threads:[~2021-12-19  4:05 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-18  4:08 [PATCH] test-appliance: add ext4/050 to encrypt.exclude Theodore Ts'o
2021-12-19  2:21 ` Eric Biggers
2021-12-19  4:05   ` Theodore Ts'o [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Yb6vbf6M+EYMXvQG@mit.edu \
    --to=tytso@mit.edu \
    --cc=ebiggers@kernel.org \
    --cc=leah.rumancik@gmail.com \
    --cc=linux-ext4@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.