From: Leon Romanovsky <leon@kernel.org>
To: Kees Cook <keescook@chromium.org>
Cc: Doug Ledford <dledford@redhat.com>,
Jason Gunthorpe <jgg@ziepe.ca>,
linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org,
linux-hardening@vger.kernel.org
Subject: Re: [PATCH v2] RDMA/mlx5: Use memset_after() to zero struct mlx5_ib_mr
Date: Wed, 8 Dec 2021 10:51:49 +0200 [thread overview]
Message-ID: <YbByJSkBgLRp5S8V@unreal> (raw)
In-Reply-To: <20211207212022.364703-1-keescook@chromium.org>
On Tue, Dec 07, 2021 at 01:20:22PM -0800, Kees Cook wrote:
> In preparation for FORTIFY_SOURCE performing compile-time and run-time
> field bounds checking for memset(), avoid intentionally writing across
> neighboring fields.
>
> Use memset_after() to zero the end of struct mlx5_ib_mr that should
> be initialized.
>
> Signed-off-by: Kees Cook <keescook@chromium.org>
> ---
> v2: rebased, umem moved into the union and is expected to be wiped
> https://lore.kernel.org/lkml/20211207194525.GL6385@nvidia.com
> ---
> drivers/infiniband/hw/mlx5/mlx5_ib.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
Thanks,
Acked-by: Leon Romanovsky <leonro@nvidia.com>
next prev parent reply other threads:[~2021-12-08 8:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-07 21:20 [PATCH v2] RDMA/mlx5: Use memset_after() to zero struct mlx5_ib_mr Kees Cook
2021-12-08 8:51 ` Leon Romanovsky [this message]
2021-12-14 0:39 ` Gustavo A. R. Silva
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YbByJSkBgLRp5S8V@unreal \
--to=leon@kernel.org \
--cc=dledford@redhat.com \
--cc=jgg@ziepe.ca \
--cc=keescook@chromium.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.