From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C9FCDC433EF for ; Wed, 8 Dec 2021 12:09:50 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id E19B426E3; Wed, 8 Dec 2021 13:08:58 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz E19B426E3 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1638965389; bh=f4V44CJpPmowhBW1vXj5tW/zhkUJ9srFbm6DGA5TSbM=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=EmUaFlMT07nHBlJc+kgqRT0nscicn4SrkVRuK7T4LFEK6u2LXdi8mlv/HJLuK3nMj EQUlhLtAiFC0woA9lVX18SWP+6/922WBi0atZx7vAFp6WI8yxWGchNpN8h6udglsfd CNlKRm3rmTwfyPkr1Dub8dxEiSaeoCQLQZOIcvuE= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 78CEFF800AB; Wed, 8 Dec 2021 13:08:58 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 6F9C4F80217; Wed, 8 Dec 2021 13:08:56 +0100 (CET) Received: from mail-wm1-x335.google.com (mail-wm1-x335.google.com [IPv6:2a00:1450:4864:20::335]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id AE19BF800AB for ; Wed, 8 Dec 2021 13:08:49 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz AE19BF800AB Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="KQcEugie" Received: by mail-wm1-x335.google.com with SMTP id c6-20020a05600c0ac600b0033c3aedd30aso1621984wmr.5 for ; Wed, 08 Dec 2021 04:08:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=R1D6vu1LwULEAHB02GfzTtDg6CGj6MOMTTzNmc1nbxo=; b=KQcEugiexb23klmZMI5tSlYPQm99/Zv4PPINCgHpDwY3fjhv8d0Zyt/TJihnvq0Ubc ulosvJ/VXLX1hsUssnt5uBohWJZavOjioliqCxG6+Fd8okWoYwHI2BVepUSR0LBr86HD skDjsgdbR4jSE6lb4q4Zlx9xgvaWcPL5d3HZlJwf7MaAII/UBpHDs5GKMn8vC3hcqSa3 j4/ExVLga/qmDqhXUjoeArZW4LSTad6LvvGw661WNvCjd6p1lh2C7KtyBv3dDjDaftSb XhUy+zdWjtjEKSsqIID9dZjM+D3L0QtRBY1Wti5aUSzDt2JGywGA79EdQUO47xDDGRwp aTAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=R1D6vu1LwULEAHB02GfzTtDg6CGj6MOMTTzNmc1nbxo=; b=Idg+zcV0AdH+JxiI8bQZTlDhATnvzvD+5U0i+lOzY+6AG99x1PBV/YRZBDNbF7EgPx Yw13A5LOOmil8koollgg7zddW1GBVvg31KIOXgMxmVrdcSONKoAIBCi+ChXrHtyFbh92 fOLnIF7K1S41lJ83GcYN+dpwnraGPpIA1Du2ZuC5ES7FcwyIuY6ywbeT7z/oGUQMntUB ICnot1FwxeW4hdWlf8pZB3UIRcOkl6Ep93I8F0ru6/aki9VHpfYPvq1fpq6/TG+/6IfZ qymBXFEh7VWkhkkI/mNi6UXcLx8E7ecdbj5RyFcTEEuo+aOrEiLlef1U31h5ei8TplBM KylA== X-Gm-Message-State: AOAM531DUP/7YtYWeHesTPwnBm0EZYzhmQ1KHyE4Am73/H5fjpcS8SGP mvX8jxLdFHeqclChEP+JtmegRw== X-Google-Smtp-Source: ABdhPJwP41Y8jw1WGUE8GAzmHo4vkR9Ff92/aNI150r9LWBWlHejIG/y9c1S8ZGyrHAs6k1jt25u+w== X-Received: by 2002:a05:600c:2252:: with SMTP id a18mr15774810wmm.133.1638965324354; Wed, 08 Dec 2021 04:08:44 -0800 (PST) Received: from google.com ([2.31.167.18]) by smtp.gmail.com with ESMTPSA id u13sm6297713wmq.14.2021.12.08.04.08.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Dec 2021 04:08:43 -0800 (PST) Date: Wed, 8 Dec 2021 12:08:41 +0000 From: Lee Jones To: Alexandre TORGUE Subject: Re: [Linux-stm32] [PATCH v2 1/4] ASoC: dt-bindings: stm32: i2s: add audio-graph-card port Message-ID: References: <20211125144053.774-1-olivier.moysan@foss.st.com> <20211125144053.774-2-olivier.moysan@foss.st.com> <1637875562.357461.2858318.nullmailer@robh.at.kernel.org> <237f56b3-0597-2526-a182-f1fbdd327338@foss.st.com> <627777a4-7458-88ed-e7c5-d11e3db847b5@foss.st.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Cc: Rob Herring , alsa-devel@alsa-project.org, Ahmad Fatoum , Maxime Coquelin , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Liam Girdwood , Mark Brown , Olivier MOYSAN , alain.volmat@foss.st.com, arnaud.pouliquen@foss.st.com, Fabrice GASNIER , linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Wed, 08 Dec 2021, Alexandre TORGUE wrote: > Hi Ahmad > > On 12/7/21 2:59 PM, Ahmad Fatoum wrote: > > Hello Alex, > > > > On 07.12.21 14:52, Alexandre TORGUE wrote: > > > Hi Rob > > > > > > On 12/1/21 11:34 PM, Rob Herring wrote: > > > > On Fri, Nov 26, 2021 at 11:25:27AM +0100, Olivier MOYSAN wrote: > > > > > Hi Rob, > > > > > > > > > > On 11/25/21 10:26 PM, Rob Herring wrote: > > > > > > On Thu, 25 Nov 2021 15:40:50 +0100, Olivier Moysan wrote: > > > > > > > The STM2 I2S DAI can be connected via the audio-graph-card. > > > > > > > Add port entry into the bindings. > > > > > > > > > > > > > > Signed-off-by: Olivier Moysan > > > > > > > --- > > > > > > >    Documentation/devicetree/bindings/sound/st,stm32-i2s.yaml | 5 +++++ > > > > > > >    1 file changed, 5 insertions(+) > > > > > > > > > > > > > > > > > > > Running 'make dtbs_check' with the schema in this patch gives the > > > > > > following warnings. Consider if they are expected or the schema is > > > > > > incorrect. These may not be new warnings. > > > > > > > > > > > > Note that it is not yet a requirement to have 0 warnings for dtbs_check. > > > > > > This will change in the future. > > > > > > > > > > > > Full log is available here: https://patchwork.ozlabs.org/patch/1559750 > > > > > > > > > > > > > > > > > > audio-controller@4000b000: 'port' does not match any of the regexes: '^port@[0-9]', 'pinctrl-[0-9]+' > > > > > >     arch/arm/boot/dts/stm32mp157a-dk1.dt.yaml > > > > > >     arch/arm/boot/dts/stm32mp157c-dk2.dt.yaml > > > > > > > > > > > > > > > > This warning is not a new one. > > > > > > > > > > The i2s2 node in stm32mp15xx-dkx.dtsi would require the following binding: > > > > > port: > > > > >     $ref: audio-graph-port.yaml# > > > > >     unevaluatedProperties: false > > > > > > > > > > However the spi binding requires to introduce a unit address: > > > > > patternProperties: > > > > >    '^port@[0-9]': > > > > >      $ref: audio-graph-port.yaml# > > > > >      unevaluatedProperties: false > > > > > > > > > > The warning can be removed by re-ordering the bindings patches in the serie, > > > > > as "additionalProperties: true" makes the check more tolerant on extra > > > > > properties. > > > > > > > > That's never right. > > > > > > > > > The patch "ASoC: dt-bindings: stm32: i2s: add audio-graph-card port" can > > > > > even be merely dropped. > > > > > So, I suggest to resend the serie without audio-graph-card patch. > > > > > > > > Only if you aren't using audio-graph-card. > > > > > > > > > > > > > > Does it sound too permissive to you ? > > > > > > > > I think perhaps you need to combine the schemas into 1. Or you need to > > > > restructure your dtsi files such that you only add spi specific > > > > properties when spi mode is enabled and only add i2s specific properties > > > > when i2s mode is enabled. Or use the /delete-property/ directive. > > > > > > Initially the aim of this series was to fix a "make W=1" warnings seen on spi and i2s nodes (duplicate unit-address). Moving both nodes in a common node + using a different compatible depending on SPI or I2S usage sounded good) but it is not enough. In this series the common node is named as following: "spi2s2: spi@4000b000". It is fine for a spi usage but if we want to use this "common node" with I2S compatible and specific bindings, the node name remains spi@... and then specific spi checks are done. For this with this series applied we got this issue reported by spi-controller.yaml: > > > > > > spi@4000b000: port@0: 'compatible' is a required property > > > > > > So, if we use two separates nodes we got W=1 warning and if we use a common node we got yaml check issue. One possibility would be to use a common node with a new node name (for example i2spi@...) but I think it is not acceptable. > > > > > > How to progress ? > > > > Atmel Flexcom can be configured to be either UART, SPI or i2c. Functions > > are child nodes of the flexcom node and the MFD driver matching against it, > > just configure the operating mode and then calls of_platform_populate. > > > > Would something along these lines fit here as well? > > Yes it could but in my mind it was not a MFD as both feature cannot be used > at the same time: it is either SPI or I2S and choice is done "statically" in > device tree depending board usage. > > Lee, what it is your feeling about that ? Will you accept to add a MFD > driver for this SPI/I2S peripheral whose prurpose is only to populate child > node (either SPI or I2S) ? >From your description, this doesn't sound like a good fit for MFD. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0FD4CC433EF for ; Wed, 8 Dec 2021 12:12:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=L0zrjB+ASgiMKP6SR9/QgX5EaGyNPJpntjpbQQB+Q40=; b=uDwrEtxMx0yiVs Y0LMMM18SH6cB+3ZVzvycbBGtEh5kzHx+zaWUca1j/eWg4inGdqDxKeaW1FXgBXWOPYXmxteBH2s2 QoSj9IjFfpJN5RGaN4Eh51LAZwHvoGmml+b8tlJlSG7iLsq42YRi+xbe1NzKntva6a79TLJB6vR2z SNKRRrvPneLy73K0O8X2yQA/F/deVWGbst8DcXKaBjD/R3E2rnF7cTyaqNbPOJr7PyDh8gwJQCpuZ 0BX2eKaUYkqntg4jqOEbMWNKznfr6O5PkQQ+n1Imwb3I6rzyMpg0OJW0orvR1iNgeCUF0h2/1lxA3 AGrmrkI7vqQt+16eSo+Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1muvmR-00CP6G-82; Wed, 08 Dec 2021 12:10:40 +0000 Received: from mail-wm1-x32e.google.com ([2a00:1450:4864:20::32e]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1muvkd-00CO1j-0k for linux-arm-kernel@lists.infradead.org; Wed, 08 Dec 2021 12:08:49 +0000 Received: by mail-wm1-x32e.google.com with SMTP id p27-20020a05600c1d9b00b0033bf8532855so1632457wms.3 for ; Wed, 08 Dec 2021 04:08:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=R1D6vu1LwULEAHB02GfzTtDg6CGj6MOMTTzNmc1nbxo=; b=KQcEugiexb23klmZMI5tSlYPQm99/Zv4PPINCgHpDwY3fjhv8d0Zyt/TJihnvq0Ubc ulosvJ/VXLX1hsUssnt5uBohWJZavOjioliqCxG6+Fd8okWoYwHI2BVepUSR0LBr86HD skDjsgdbR4jSE6lb4q4Zlx9xgvaWcPL5d3HZlJwf7MaAII/UBpHDs5GKMn8vC3hcqSa3 j4/ExVLga/qmDqhXUjoeArZW4LSTad6LvvGw661WNvCjd6p1lh2C7KtyBv3dDjDaftSb XhUy+zdWjtjEKSsqIID9dZjM+D3L0QtRBY1Wti5aUSzDt2JGywGA79EdQUO47xDDGRwp aTAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=R1D6vu1LwULEAHB02GfzTtDg6CGj6MOMTTzNmc1nbxo=; b=R7UjHDhma0MFJ1pwazjrRRn1h9LLKrzs0plijPaVpBDNrD84z3Qu77bE1EHaMm0MfL VewcgyW6R8h0i0O0Xxx9bESHqIaLBK6xS+G1E/PoiQghWnCquhdVkyCcDg4VFhqqc+J3 5lWu0nbEwOjPSCfM7vyZjoJphAdhtpD/NXk1Vqa+S3OF1Yefx9W9JETdl4m/sv9ceRRi 5qvRc9vKg6z8Vzk+JZYBXbsIyzXIFfBBjkuUlhfBt1ZczOk8jRMqqvc6iwV0Be/TS212 8SMhhfp+20xpHIzyEyrVHBG7SEYtacYng7EDd+KmXa0tKOl9MuBCasAN807AhbLN+UI0 vRfg== X-Gm-Message-State: AOAM531smSE8TW9U2DooiipAvfg4lQMKMuy/Z176Rx+T+VxoUY5yJequ nR8SKOL4OmANnYgGJ6L27uOs1g== X-Google-Smtp-Source: ABdhPJwP41Y8jw1WGUE8GAzmHo4vkR9Ff92/aNI150r9LWBWlHejIG/y9c1S8ZGyrHAs6k1jt25u+w== X-Received: by 2002:a05:600c:2252:: with SMTP id a18mr15774810wmm.133.1638965324354; Wed, 08 Dec 2021 04:08:44 -0800 (PST) Received: from google.com ([2.31.167.18]) by smtp.gmail.com with ESMTPSA id u13sm6297713wmq.14.2021.12.08.04.08.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Dec 2021 04:08:43 -0800 (PST) Date: Wed, 8 Dec 2021 12:08:41 +0000 From: Lee Jones To: Alexandre TORGUE Cc: Ahmad Fatoum , Rob Herring , Olivier MOYSAN , Fabrice GASNIER , devicetree@vger.kernel.org, alsa-devel@alsa-project.org, Mark Brown , linux-kernel@vger.kernel.org, Liam Girdwood , Maxime Coquelin , alain.volmat@foss.st.com, arnaud.pouliquen@foss.st.com, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org Subject: Re: [Linux-stm32] [PATCH v2 1/4] ASoC: dt-bindings: stm32: i2s: add audio-graph-card port Message-ID: References: <20211125144053.774-1-olivier.moysan@foss.st.com> <20211125144053.774-2-olivier.moysan@foss.st.com> <1637875562.357461.2858318.nullmailer@robh.at.kernel.org> <237f56b3-0597-2526-a182-f1fbdd327338@foss.st.com> <627777a4-7458-88ed-e7c5-d11e3db847b5@foss.st.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211208_040847_152160_863B0A07 X-CRM114-Status: GOOD ( 44.46 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gV2VkLCAwOCBEZWMgMjAyMSwgQWxleGFuZHJlIFRPUkdVRSB3cm90ZToKCj4gSGkgQWhtYWQK PiAKPiBPbiAxMi83LzIxIDI6NTkgUE0sIEFobWFkIEZhdG91bSB3cm90ZToKPiA+IEhlbGxvIEFs ZXgsCj4gPiAKPiA+IE9uIDA3LjEyLjIxIDE0OjUyLCBBbGV4YW5kcmUgVE9SR1VFIHdyb3RlOgo+ ID4gPiBIaSBSb2IKPiA+ID4gCj4gPiA+IE9uIDEyLzEvMjEgMTE6MzQgUE0sIFJvYiBIZXJyaW5n IHdyb3RlOgo+ID4gPiA+IE9uIEZyaSwgTm92IDI2LCAyMDIxIGF0IDExOjI1OjI3QU0gKzAxMDAs IE9saXZpZXIgTU9ZU0FOIHdyb3RlOgo+ID4gPiA+ID4gSGkgUm9iLAo+ID4gPiA+ID4gCj4gPiA+ ID4gPiBPbiAxMS8yNS8yMSAxMDoyNiBQTSwgUm9iIEhlcnJpbmcgd3JvdGU6Cj4gPiA+ID4gPiA+ IE9uIFRodSwgMjUgTm92IDIwMjEgMTU6NDA6NTAgKzAxMDAsIE9saXZpZXIgTW95c2FuIHdyb3Rl Ogo+ID4gPiA+ID4gPiA+IFRoZSBTVE0yIEkyUyBEQUkgY2FuIGJlIGNvbm5lY3RlZCB2aWEgdGhl IGF1ZGlvLWdyYXBoLWNhcmQuCj4gPiA+ID4gPiA+ID4gQWRkIHBvcnQgZW50cnkgaW50byB0aGUg YmluZGluZ3MuCj4gPiA+ID4gPiA+ID4gCj4gPiA+ID4gPiA+ID4gU2lnbmVkLW9mZi1ieTogT2xp dmllciBNb3lzYW4gPG9saXZpZXIubW95c2FuQGZvc3Muc3QuY29tPgo+ID4gPiA+ID4gPiA+IC0t LQo+ID4gPiA+ID4gPiA+ICDCoMKgIERvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9z b3VuZC9zdCxzdG0zMi1pMnMueWFtbCB8IDUgKysrKysKPiA+ID4gPiA+ID4gPiAgwqDCoCAxIGZp bGUgY2hhbmdlZCwgNSBpbnNlcnRpb25zKCspCj4gPiA+ID4gPiA+ID4gCj4gPiA+ID4gPiA+IAo+ ID4gPiA+ID4gPiBSdW5uaW5nICdtYWtlIGR0YnNfY2hlY2snIHdpdGggdGhlIHNjaGVtYSBpbiB0 aGlzIHBhdGNoIGdpdmVzIHRoZQo+ID4gPiA+ID4gPiBmb2xsb3dpbmcgd2FybmluZ3MuIENvbnNp ZGVyIGlmIHRoZXkgYXJlIGV4cGVjdGVkIG9yIHRoZSBzY2hlbWEgaXMKPiA+ID4gPiA+ID4gaW5j b3JyZWN0LiBUaGVzZSBtYXkgbm90IGJlIG5ldyB3YXJuaW5ncy4KPiA+ID4gPiA+ID4gCj4gPiA+ ID4gPiA+IE5vdGUgdGhhdCBpdCBpcyBub3QgeWV0IGEgcmVxdWlyZW1lbnQgdG8gaGF2ZSAwIHdh cm5pbmdzIGZvciBkdGJzX2NoZWNrLgo+ID4gPiA+ID4gPiBUaGlzIHdpbGwgY2hhbmdlIGluIHRo ZSBmdXR1cmUuCj4gPiA+ID4gPiA+IAo+ID4gPiA+ID4gPiBGdWxsIGxvZyBpcyBhdmFpbGFibGUg aGVyZTogaHR0cHM6Ly9wYXRjaHdvcmsub3psYWJzLm9yZy9wYXRjaC8xNTU5NzUwCj4gPiA+ID4g PiA+IAo+ID4gPiA+ID4gPiAKPiA+ID4gPiA+ID4gYXVkaW8tY29udHJvbGxlckA0MDAwYjAwMDog J3BvcnQnIGRvZXMgbm90IG1hdGNoIGFueSBvZiB0aGUgcmVnZXhlczogJ15wb3J0QFswLTldJywg J3BpbmN0cmwtWzAtOV0rJwo+ID4gPiA+ID4gPiAgwqDCoMKgwqBhcmNoL2FybS9ib290L2R0cy9z dG0zMm1wMTU3YS1kazEuZHQueWFtbAo+ID4gPiA+ID4gPiAgwqDCoMKgwqBhcmNoL2FybS9ib290 L2R0cy9zdG0zMm1wMTU3Yy1kazIuZHQueWFtbAo+ID4gPiA+ID4gPiAKPiA+ID4gPiA+IAo+ID4g PiA+ID4gVGhpcyB3YXJuaW5nIGlzIG5vdCBhIG5ldyBvbmUuCj4gPiA+ID4gPiAKPiA+ID4gPiA+ IFRoZSBpMnMyIG5vZGUgaW4gc3RtMzJtcDE1eHgtZGt4LmR0c2kgd291bGQgcmVxdWlyZSB0aGUg Zm9sbG93aW5nIGJpbmRpbmc6Cj4gPiA+ID4gPiBwb3J0Ogo+ID4gPiA+ID4gIMKgwqDCoMKgJHJl ZjogYXVkaW8tZ3JhcGgtcG9ydC55YW1sIwo+ID4gPiA+ID4gIMKgwqDCoMKgdW5ldmFsdWF0ZWRQ cm9wZXJ0aWVzOiBmYWxzZQo+ID4gPiA+ID4gCj4gPiA+ID4gPiBIb3dldmVyIHRoZSBzcGkgYmlu ZGluZyByZXF1aXJlcyB0byBpbnRyb2R1Y2UgYSB1bml0IGFkZHJlc3M6Cj4gPiA+ID4gPiBwYXR0 ZXJuUHJvcGVydGllczoKPiA+ID4gPiA+ICDCoMKgICdecG9ydEBbMC05XSc6Cj4gPiA+ID4gPiAg wqDCoMKgwqAgJHJlZjogYXVkaW8tZ3JhcGgtcG9ydC55YW1sIwo+ID4gPiA+ID4gIMKgwqDCoMKg IHVuZXZhbHVhdGVkUHJvcGVydGllczogZmFsc2UKPiA+ID4gPiA+IAo+ID4gPiA+ID4gVGhlIHdh cm5pbmcgY2FuIGJlIHJlbW92ZWQgYnkgcmUtb3JkZXJpbmcgdGhlIGJpbmRpbmdzIHBhdGNoZXMg aW4gdGhlIHNlcmllLAo+ID4gPiA+ID4gYXMgImFkZGl0aW9uYWxQcm9wZXJ0aWVzOiB0cnVlIiBt YWtlcyB0aGUgY2hlY2sgbW9yZSB0b2xlcmFudCBvbiBleHRyYQo+ID4gPiA+ID4gcHJvcGVydGll cy4KPiA+ID4gPiAKPiA+ID4gPiBUaGF0J3MgbmV2ZXIgcmlnaHQuCj4gPiA+ID4gCj4gPiA+ID4g PiBUaGUgcGF0Y2ggIkFTb0M6IGR0LWJpbmRpbmdzOiBzdG0zMjogaTJzOiBhZGQgYXVkaW8tZ3Jh cGgtY2FyZCBwb3J0IiBjYW4KPiA+ID4gPiA+IGV2ZW4gYmUgbWVyZWx5IGRyb3BwZWQuCj4gPiA+ ID4gPiBTbywgSSBzdWdnZXN0IHRvIHJlc2VuZCB0aGUgc2VyaWUgd2l0aG91dCBhdWRpby1ncmFw aC1jYXJkIHBhdGNoLgo+ID4gPiA+IAo+ID4gPiA+IE9ubHkgaWYgeW91IGFyZW4ndCB1c2luZyBh dWRpby1ncmFwaC1jYXJkLgo+ID4gPiA+IAo+ID4gPiA+ID4gCj4gPiA+ID4gPiBEb2VzIGl0IHNv dW5kIHRvbyBwZXJtaXNzaXZlIHRvIHlvdSA/Cj4gPiA+ID4gCj4gPiA+ID4gSSB0aGluayBwZXJo YXBzIHlvdSBuZWVkIHRvIGNvbWJpbmUgdGhlIHNjaGVtYXMgaW50byAxLiBPciB5b3UgbmVlZCB0 bwo+ID4gPiA+IHJlc3RydWN0dXJlIHlvdXIgZHRzaSBmaWxlcyBzdWNoIHRoYXQgeW91IG9ubHkg YWRkIHNwaSBzcGVjaWZpYwo+ID4gPiA+IHByb3BlcnRpZXMgd2hlbiBzcGkgbW9kZSBpcyBlbmFi bGVkIGFuZCBvbmx5IGFkZCBpMnMgc3BlY2lmaWMgcHJvcGVydGllcwo+ID4gPiA+IHdoZW4gaTJz IG1vZGUgaXMgZW5hYmxlZC4gT3IgdXNlIHRoZSAvZGVsZXRlLXByb3BlcnR5LyBkaXJlY3RpdmUu Cj4gPiA+IAo+ID4gPiBJbml0aWFsbHkgdGhlIGFpbSBvZiB0aGlzIHNlcmllcyB3YXMgdG8gZml4 IGEgIm1ha2UgVz0xIiB3YXJuaW5ncyBzZWVuIG9uIHNwaSBhbmQgaTJzIG5vZGVzIChkdXBsaWNh dGUgdW5pdC1hZGRyZXNzKS4gTW92aW5nIGJvdGggbm9kZXMgaW4gYSBjb21tb24gbm9kZSArIHVz aW5nIGEgZGlmZmVyZW50IGNvbXBhdGlibGUgZGVwZW5kaW5nIG9uIFNQSSBvciBJMlMgdXNhZ2Ug c291bmRlZCBnb29kKSBidXQgaXQgaXMgbm90IGVub3VnaC4gSW4gdGhpcyBzZXJpZXMgdGhlIGNv bW1vbiBub2RlIGlzIG5hbWVkIGFzIGZvbGxvd2luZzogInNwaTJzMjogc3BpQDQwMDBiMDAwIi4g SXQgaXMgZmluZSBmb3IgYSBzcGkgdXNhZ2UgYnV0IGlmIHdlIHdhbnQgdG8gdXNlIHRoaXMgImNv bW1vbiBub2RlIiB3aXRoIEkyUyBjb21wYXRpYmxlIGFuZCBzcGVjaWZpYyBiaW5kaW5ncywgdGhl IG5vZGUgbmFtZSByZW1haW5zIHNwaUAuLi4gYW5kIHRoZW4gc3BlY2lmaWMgc3BpIGNoZWNrcyBh cmUgZG9uZS4gRm9yIHRoaXMgd2l0aCB0aGlzIHNlcmllcyBhcHBsaWVkIHdlIGdvdCB0aGlzIGlz c3VlIHJlcG9ydGVkIGJ5IHNwaS1jb250cm9sbGVyLnlhbWw6Cj4gPiA+IAo+ID4gPiBzcGlANDAw MGIwMDA6IHBvcnRAMDogJ2NvbXBhdGlibGUnIGlzIGEgcmVxdWlyZWQgcHJvcGVydHkKPiA+ID4g Cj4gPiA+IFNvLCBpZiB3ZSB1c2UgdHdvIHNlcGFyYXRlcyBub2RlcyB3ZSBnb3QgVz0xIHdhcm5p bmcgYW5kIGlmIHdlIHVzZSBhIGNvbW1vbiBub2RlIHdlIGdvdCB5YW1sIGNoZWNrIGlzc3VlLiBP bmUgcG9zc2liaWxpdHkgd291bGQgYmUgdG8gdXNlIGEgY29tbW9uIG5vZGUgd2l0aCBhIG5ldyBu b2RlIG5hbWUgKGZvciBleGFtcGxlIGkyc3BpQC4uLikgYnV0IEkgdGhpbmsgaXQgaXMgbm90IGFj Y2VwdGFibGUuCj4gPiA+IAo+ID4gPiBIb3cgdG8gcHJvZ3Jlc3MgPwo+ID4gCj4gPiBBdG1lbCBG bGV4Y29tIGNhbiBiZSBjb25maWd1cmVkIHRvIGJlIGVpdGhlciBVQVJULCBTUEkgb3IgaTJjLiBG dW5jdGlvbnMKPiA+IGFyZSBjaGlsZCBub2RlcyBvZiB0aGUgZmxleGNvbSBub2RlIGFuZCB0aGUg TUZEIGRyaXZlciBtYXRjaGluZyBhZ2FpbnN0IGl0LAo+ID4ganVzdCBjb25maWd1cmUgdGhlIG9w ZXJhdGluZyBtb2RlIGFuZCB0aGVuIGNhbGxzIG9mX3BsYXRmb3JtX3BvcHVsYXRlLgo+ID4gCj4g PiBXb3VsZCBzb21ldGhpbmcgYWxvbmcgdGhlc2UgbGluZXMgZml0IGhlcmUgYXMgd2VsbD8KPiAK PiBZZXMgaXQgY291bGQgYnV0IGluIG15IG1pbmQgaXQgd2FzIG5vdCBhIE1GRCBhcyBib3RoIGZl YXR1cmUgY2Fubm90IGJlIHVzZWQKPiBhdCB0aGUgc2FtZSB0aW1lOiBpdCBpcyBlaXRoZXIgU1BJ IG9yIEkyUyBhbmQgY2hvaWNlIGlzIGRvbmUgInN0YXRpY2FsbHkiIGluCj4gZGV2aWNlIHRyZWUg ZGVwZW5kaW5nIGJvYXJkIHVzYWdlLgo+IAo+IExlZSwgd2hhdCBpdCBpcyB5b3VyIGZlZWxpbmcg YWJvdXQgdGhhdCA/IFdpbGwgeW91IGFjY2VwdCB0byBhZGQgYSBNRkQKPiBkcml2ZXIgZm9yIHRo aXMgU1BJL0kyUyBwZXJpcGhlcmFsIHdob3NlIHBydXJwb3NlIGlzIG9ubHkgdG8gcG9wdWxhdGUg Y2hpbGQKPiBub2RlIChlaXRoZXIgU1BJIG9yIEkyUykgPwoKRnJvbSB5b3VyIGRlc2NyaXB0aW9u LCB0aGlzIGRvZXNuJ3Qgc291bmQgbGlrZSBhIGdvb2QgZml0IGZvciBNRkQuCgotLSAKTGVlIEpv bmVzIFvmnY7nkLzmlq9dClNlbmlvciBUZWNobmljYWwgTGVhZCAtIERldmVsb3BlciBTZXJ2aWNl cwpMaW5hcm8ub3JnIOKUgiBPcGVuIHNvdXJjZSBzb2Z0d2FyZSBmb3IgQXJtIFNvQ3MKRm9sbG93 IExpbmFybzogRmFjZWJvb2sgfCBUd2l0dGVyIHwgQmxvZwoKX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QK bGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRl YWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5CBB9C433EF for ; Wed, 8 Dec 2021 12:08:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231583AbhLHMMS (ORCPT ); Wed, 8 Dec 2021 07:12:18 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36484 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233064AbhLHMMR (ORCPT ); Wed, 8 Dec 2021 07:12:17 -0500 Received: from mail-wm1-x32a.google.com (mail-wm1-x32a.google.com [IPv6:2a00:1450:4864:20::32a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DBE6DC061746 for ; Wed, 8 Dec 2021 04:08:45 -0800 (PST) Received: by mail-wm1-x32a.google.com with SMTP id az34-20020a05600c602200b0033bf8662572so1671275wmb.0 for ; Wed, 08 Dec 2021 04:08:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=R1D6vu1LwULEAHB02GfzTtDg6CGj6MOMTTzNmc1nbxo=; b=KQcEugiexb23klmZMI5tSlYPQm99/Zv4PPINCgHpDwY3fjhv8d0Zyt/TJihnvq0Ubc ulosvJ/VXLX1hsUssnt5uBohWJZavOjioliqCxG6+Fd8okWoYwHI2BVepUSR0LBr86HD skDjsgdbR4jSE6lb4q4Zlx9xgvaWcPL5d3HZlJwf7MaAII/UBpHDs5GKMn8vC3hcqSa3 j4/ExVLga/qmDqhXUjoeArZW4LSTad6LvvGw661WNvCjd6p1lh2C7KtyBv3dDjDaftSb XhUy+zdWjtjEKSsqIID9dZjM+D3L0QtRBY1Wti5aUSzDt2JGywGA79EdQUO47xDDGRwp aTAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=R1D6vu1LwULEAHB02GfzTtDg6CGj6MOMTTzNmc1nbxo=; b=1djNn6UYpmg3x1EARe15i8JcZPcumiaYBslTcTqmaxPYBpDkjswOUA0R71F0YgaJkg L5tv3Vk6wu09RTfBj7zH/R5a0g4w/+wBcwTzMWSgPcnTCn9fowPy6E66y6FG/gAEKAOy 4M71cdOZ6YyozAsPDa6RYudYWMz8FAxVoTyS1gunJTSRmoSRV1oFCV7lLGXVIvWmAy9i w+3hVfZGX11NOw4CWfxerdD3eFZHVu+Ir2tJFsA1gZuk2iioDy2foffGD2eFQYdquFQw Mbjbv4C0WVkDOS9pxczFgWO41APzFpAh2OOvphNX6X28A/cXHYgmFXjBDV+tRfptoUOa PKhA== X-Gm-Message-State: AOAM532+BYh4ZCag+DpM5oRTYaEQa1Wqfs3mEpOVBZDp0yj5ZlBgFled CEcT9PQuqc7n8KWaaSG/LsM62w== X-Google-Smtp-Source: ABdhPJwP41Y8jw1WGUE8GAzmHo4vkR9Ff92/aNI150r9LWBWlHejIG/y9c1S8ZGyrHAs6k1jt25u+w== X-Received: by 2002:a05:600c:2252:: with SMTP id a18mr15774810wmm.133.1638965324354; Wed, 08 Dec 2021 04:08:44 -0800 (PST) Received: from google.com ([2.31.167.18]) by smtp.gmail.com with ESMTPSA id u13sm6297713wmq.14.2021.12.08.04.08.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Dec 2021 04:08:43 -0800 (PST) Date: Wed, 8 Dec 2021 12:08:41 +0000 From: Lee Jones To: Alexandre TORGUE Cc: Ahmad Fatoum , Rob Herring , Olivier MOYSAN , Fabrice GASNIER , devicetree@vger.kernel.org, alsa-devel@alsa-project.org, Mark Brown , linux-kernel@vger.kernel.org, Liam Girdwood , Maxime Coquelin , alain.volmat@foss.st.com, arnaud.pouliquen@foss.st.com, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org Subject: Re: [Linux-stm32] [PATCH v2 1/4] ASoC: dt-bindings: stm32: i2s: add audio-graph-card port Message-ID: References: <20211125144053.774-1-olivier.moysan@foss.st.com> <20211125144053.774-2-olivier.moysan@foss.st.com> <1637875562.357461.2858318.nullmailer@robh.at.kernel.org> <237f56b3-0597-2526-a182-f1fbdd327338@foss.st.com> <627777a4-7458-88ed-e7c5-d11e3db847b5@foss.st.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Wed, 08 Dec 2021, Alexandre TORGUE wrote: > Hi Ahmad > > On 12/7/21 2:59 PM, Ahmad Fatoum wrote: > > Hello Alex, > > > > On 07.12.21 14:52, Alexandre TORGUE wrote: > > > Hi Rob > > > > > > On 12/1/21 11:34 PM, Rob Herring wrote: > > > > On Fri, Nov 26, 2021 at 11:25:27AM +0100, Olivier MOYSAN wrote: > > > > > Hi Rob, > > > > > > > > > > On 11/25/21 10:26 PM, Rob Herring wrote: > > > > > > On Thu, 25 Nov 2021 15:40:50 +0100, Olivier Moysan wrote: > > > > > > > The STM2 I2S DAI can be connected via the audio-graph-card. > > > > > > > Add port entry into the bindings. > > > > > > > > > > > > > > Signed-off-by: Olivier Moysan > > > > > > > --- > > > > > > >    Documentation/devicetree/bindings/sound/st,stm32-i2s.yaml | 5 +++++ > > > > > > >    1 file changed, 5 insertions(+) > > > > > > > > > > > > > > > > > > > Running 'make dtbs_check' with the schema in this patch gives the > > > > > > following warnings. Consider if they are expected or the schema is > > > > > > incorrect. These may not be new warnings. > > > > > > > > > > > > Note that it is not yet a requirement to have 0 warnings for dtbs_check. > > > > > > This will change in the future. > > > > > > > > > > > > Full log is available here: https://patchwork.ozlabs.org/patch/1559750 > > > > > > > > > > > > > > > > > > audio-controller@4000b000: 'port' does not match any of the regexes: '^port@[0-9]', 'pinctrl-[0-9]+' > > > > > >     arch/arm/boot/dts/stm32mp157a-dk1.dt.yaml > > > > > >     arch/arm/boot/dts/stm32mp157c-dk2.dt.yaml > > > > > > > > > > > > > > > > This warning is not a new one. > > > > > > > > > > The i2s2 node in stm32mp15xx-dkx.dtsi would require the following binding: > > > > > port: > > > > >     $ref: audio-graph-port.yaml# > > > > >     unevaluatedProperties: false > > > > > > > > > > However the spi binding requires to introduce a unit address: > > > > > patternProperties: > > > > >    '^port@[0-9]': > > > > >      $ref: audio-graph-port.yaml# > > > > >      unevaluatedProperties: false > > > > > > > > > > The warning can be removed by re-ordering the bindings patches in the serie, > > > > > as "additionalProperties: true" makes the check more tolerant on extra > > > > > properties. > > > > > > > > That's never right. > > > > > > > > > The patch "ASoC: dt-bindings: stm32: i2s: add audio-graph-card port" can > > > > > even be merely dropped. > > > > > So, I suggest to resend the serie without audio-graph-card patch. > > > > > > > > Only if you aren't using audio-graph-card. > > > > > > > > > > > > > > Does it sound too permissive to you ? > > > > > > > > I think perhaps you need to combine the schemas into 1. Or you need to > > > > restructure your dtsi files such that you only add spi specific > > > > properties when spi mode is enabled and only add i2s specific properties > > > > when i2s mode is enabled. Or use the /delete-property/ directive. > > > > > > Initially the aim of this series was to fix a "make W=1" warnings seen on spi and i2s nodes (duplicate unit-address). Moving both nodes in a common node + using a different compatible depending on SPI or I2S usage sounded good) but it is not enough. In this series the common node is named as following: "spi2s2: spi@4000b000". It is fine for a spi usage but if we want to use this "common node" with I2S compatible and specific bindings, the node name remains spi@... and then specific spi checks are done. For this with this series applied we got this issue reported by spi-controller.yaml: > > > > > > spi@4000b000: port@0: 'compatible' is a required property > > > > > > So, if we use two separates nodes we got W=1 warning and if we use a common node we got yaml check issue. One possibility would be to use a common node with a new node name (for example i2spi@...) but I think it is not acceptable. > > > > > > How to progress ? > > > > Atmel Flexcom can be configured to be either UART, SPI or i2c. Functions > > are child nodes of the flexcom node and the MFD driver matching against it, > > just configure the operating mode and then calls of_platform_populate. > > > > Would something along these lines fit here as well? > > Yes it could but in my mind it was not a MFD as both feature cannot be used > at the same time: it is either SPI or I2S and choice is done "statically" in > device tree depending board usage. > > Lee, what it is your feeling about that ? Will you accept to add a MFD > driver for this SPI/I2S peripheral whose prurpose is only to populate child > node (either SPI or I2S) ? >From your description, this doesn't sound like a good fit for MFD. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog