From: Andi Shyti <andi.shyti@linux.intel.com>
To: Ramalingam C <ramalingam.c@intel.com>
Cc: intel-gfx <intel-gfx@lists.freedesktop.org>,
Matthew Auld <matthew.auld@intel.com>,
dri-devel <dri-devel@lists.freedesktop.org>,
Chris Wilson <chris@chris-wilson.co.uk>
Subject: Re: [Intel-gfx] [PATCH 2/3] drm/i915: Sanitycheck device iomem on probe
Date: Wed, 8 Dec 2021 17:23:26 +0200 [thread overview]
Message-ID: <YbDN7pb6WUIWselA@intel.intel> (raw)
In-Reply-To: <20211208145800.27246-3-ramalingam.c@intel.com>
Hi Ram,
> +static int intel_memory_region_memtest(struct intel_memory_region *mem,
> + void *caller)
> +{
> + struct drm_i915_private *i915 = mem->i915;
> + int err = 0;
> +
> + if (!mem->io_start)
> + return 0;
> +
> + if (IS_ENABLED(CONFIG_DRM_I915_DEBUG_GEM))
> + err = iomemtest(mem, caller);
I don't understand the debugging part of the iomemtest, if memory
is failing we wouldn't relise if DEBUG_GEM is not enabled.
In any case,
Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com>
Andi
next prev parent reply other threads:[~2021-12-08 15:23 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-08 14:57 [Intel-gfx] [PATCH 0/3] drm/i915: Sanity Check for device memory region Ramalingam C
2021-12-08 14:57 ` Ramalingam C
2021-12-08 14:57 ` [Intel-gfx] [PATCH 1/3] drm/i915: Exclude reserved stolen from driver use Ramalingam C
2021-12-08 14:57 ` Ramalingam C
2021-12-08 15:18 ` [Intel-gfx] " Andi Shyti
2021-12-08 15:20 ` Andi Shyti
2021-12-08 14:57 ` [Intel-gfx] [PATCH 2/3] drm/i915: Sanitycheck device iomem on probe Ramalingam C
2021-12-08 14:57 ` Ramalingam C
2021-12-08 15:23 ` Andi Shyti [this message]
2021-12-08 15:39 ` [Intel-gfx] " Ramalingam C
2021-12-08 14:58 ` [Intel-gfx] [PATCH 3/3] drm/i915: Test all device memory on probing Ramalingam C
2021-12-08 14:58 ` Ramalingam C
2021-12-08 15:26 ` [Intel-gfx] " Andi Shyti
-- strict thread matches above, loose matches on Subject: below --
2021-12-08 15:34 [Intel-gfx] [PATCH 0/3] drm/i915: Sanity Check for device memory region Ramalingam C
2021-12-08 15:34 ` [Intel-gfx] [PATCH 2/3] drm/i915: Sanitycheck device iomem on probe Ramalingam C
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YbDN7pb6WUIWselA@intel.intel \
--to=andi.shyti@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=matthew.auld@intel.com \
--cc=ramalingam.c@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.