From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 814C7C433EF for ; Wed, 8 Dec 2021 16:12:22 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9D7DF738DF; Wed, 8 Dec 2021 16:12:20 +0000 (UTC) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2E705738C7; Wed, 8 Dec 2021 16:12:19 +0000 (UTC) X-IronPort-AV: E=McAfee;i="6200,9189,10192"; a="237666630" X-IronPort-AV: E=Sophos;i="5.88,189,1635231600"; d="scan'208";a="237666630" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Dec 2021 08:12:18 -0800 X-IronPort-AV: E=Sophos;i="5.88,190,1635231600"; d="scan'208";a="503100017" Received: from faerberc-mobl2.ger.corp.intel.com (HELO intel.com) ([10.251.209.148]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Dec 2021 08:12:09 -0800 Date: Wed, 8 Dec 2021 18:12:06 +0200 From: Andi Shyti To: Ramalingam C Message-ID: References: <20211208141613.7251-1-ramalingam.c@intel.com> <20211208141613.7251-5-ramalingam.c@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20211208141613.7251-5-ramalingam.c@intel.com> Subject: Re: [Intel-gfx] [PATCH 4/4] drm/i915: enforce min page size for scratch X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas =?iso-8859-15?Q?Hellstr=F6m?= , intel-gfx , Hellstrom Thomas , Matthew Auld , dri-devel Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Hi Matt and Ram, On Wed, Dec 08, 2021 at 07:46:13PM +0530, Ramalingam C wrote: > From: Matthew Auld > > If the device needs 64K minimum GTT pages for device local-memory, > like on XEHPSDV, then we need to fail the allocation if we can't > meet it, instead of falling back to 4K pages, otherwise we can't > safely support the insertion of device local-memory pages for > this vm, since the HW expects the correct physical alignment and > size for every PTE, if we mark the page-table as 64K GTT mode. > > v2: s/userpsace/userspace [Thomas] > > Signed-off-by: Matthew Auld > Signed-off-by: Ramalingam C > Reviewed-by: Thomas Hellström Reviewed-by: Andi Shyti Andi