All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
Cc: David Miller <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>,
	Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
	David Ahern <dsahern@kernel.org>,
	James Prestwood <prestwoj@gmail.com>,
	Justin Iurman <justin.iurman@uliege.be>,
	Praveen Chaudhary <praveen5582@gmail.com>,
	"Jason A . Donenfeld" <Jason@zx2c4.com>,
	Eric Dumazet <edumazet@google.com>,
	netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next v4 3/3] udp6: Use Segment Routing Header for dest address if present
Date: Wed, 8 Dec 2021 23:34:54 +0100	[thread overview]
Message-ID: <YbEzDrDR1uTCT4Xo@lunn.ch> (raw)
In-Reply-To: <CA+FuTScYqNfFmuYXJZHi24gs-Vyx8AJW8tPuehW75wdO4arPgw@mail.gmail.com>

> > +/* If the packet which invoked an ICMP error contains an SRH return
> > + * the true destination address from within the SRH, otherwise use the
> > + * destination address in the IP header.
> > + */
> 
> nit: the above describes the behavior of the caller, not the function.
> The function returns NULL if no SRH is found.

Yes, i will fix that.

Thanks
	Andrew

      reply	other threads:[~2021-12-08 22:35 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-08 17:38 [PATCH net-next v4 0/3] Fix traceroute in the presence of SRv6 Andrew Lunn
2021-12-08 17:38 ` [PATCH net-next v4 1/3] seg6: export get_srh() for ICMP handling Andrew Lunn
2021-12-08 17:38 ` Andrew Lunn
2021-12-08 21:24   ` Willem de Bruijn
2021-12-08 22:37     ` Andrew Lunn
2021-12-08 17:38 ` [PATCH net-next v4 3/3] udp6: Use Segment Routing Header for dest address if present Andrew Lunn
2021-12-08 21:26   ` Willem de Bruijn
2021-12-08 22:34     ` Andrew Lunn [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YbEzDrDR1uTCT4Xo@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=Jason@zx2c4.com \
    --cc=davem@davemloft.net \
    --cc=dsahern@kernel.org \
    --cc=edumazet@google.com \
    --cc=justin.iurman@uliege.be \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=praveen5582@gmail.com \
    --cc=prestwoj@gmail.com \
    --cc=willemdebruijn.kernel@gmail.com \
    --cc=yoshfuji@linux-ipv6.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.