From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Jani Nikula <jani.nikula@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH 1/3] drm/i915: Nuke {pipe, plane}_to_crtc_mapping[]
Date: Thu, 9 Dec 2021 15:24:13 +0200 [thread overview]
Message-ID: <YbIDffl2Uy7oHXUF@intel.com> (raw)
In-Reply-To: <87zgp93ooj.fsf@intel.com>
On Thu, Dec 09, 2021 at 03:14:52PM +0200, Jani Nikula wrote:
> On Fri, 03 Dec 2021, Ville Syrjala <ville.syrjala@linux.intel.com> wrote:
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >
> > These plane/pipe->crtc mapping arrays are rather pointless.
> > Get rid of them and just iterate the lists instead.
>
> Nice follow-up to my cleanups. On the series,
>
> Reviewed-by: Jani Nikula <jani.nikula@intel.com>
>
> intel_crtc_first() might have been nice for the prefix, but does it
> sound too awkward? *shrug*
Yeah, sounds a bit wonky to my ear.
I'd probably have of those "wtf does that do?" moments if I saw
a intel_crtc_first() call in the code.
--
Ville Syrjälä
Intel
prev parent reply other threads:[~2021-12-09 17:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-03 11:20 [Intel-gfx] [PATCH 1/3] drm/i915: Nuke {pipe, plane}_to_crtc_mapping[] Ville Syrjala
2021-12-03 11:20 ` [Intel-gfx] [PATCH 2/3] drm/i915: Relocate intel_crtc_for_plane() Ville Syrjala
2021-12-03 11:20 ` [Intel-gfx] [PATCH 3/3] drm/i915: s/intel_get_first_crtc/intel_first_crtc/ Ville Syrjala
2021-12-03 13:48 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/3] drm/i915: Nuke {pipe, plane}_to_crtc_mapping[] Patchwork
2021-12-03 14:14 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2021-12-03 19:54 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2021-12-09 13:14 ` [Intel-gfx] [PATCH 1/3] " Jani Nikula
2021-12-09 13:24 ` Ville Syrjälä [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YbIDffl2Uy7oHXUF@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.