From: Nathan Chancellor <nathan@kernel.org>
To: Tiezhu Yang <yangtiezhu@loongson.cn>
Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
Jason Self <jason@bluehome.net>,
Masahiro Yamada <masahiroy@kernel.org>,
Ryutaroh Matsumoto <ryutaroh@ict.e.titech.ac.jp>,
linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] MIPS: Makefile: Remove "ifdef need-compiler" for Kbuild.platforms
Date: Fri, 10 Dec 2021 09:22:40 -0700 [thread overview]
Message-ID: <YbN+0NrHmsFKfNWP@archlinux-ax161> (raw)
In-Reply-To: <1639109105-1545-1-git-send-email-yangtiezhu@loongson.cn>
On Fri, Dec 10, 2021 at 12:05:05PM +0800, Tiezhu Yang wrote:
> After commit 13ceb48bc19c ("MIPS: Loongson2ef: Remove unnecessary
> {as,cc}-option calls"), no need to use "ifdef need-compiler" for
> Kbuild.platforms, because the cause of the build issue mentioned
> in commit 0706f74f719e ("MIPS: fix *-pkg builds for loongson2ef
> platform") has been disappeared, so just remove it.
>
> Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
Reviewed-by: Nathan Chancellor <nathan@kernel.org>
> ---
>
> v2: fix the typo "casue" --> "cause" in the commit message,
> sorry for that.
>
> arch/mips/Makefile | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/arch/mips/Makefile b/arch/mips/Makefile
> index ace7f03..e036fc0 100644
> --- a/arch/mips/Makefile
> +++ b/arch/mips/Makefile
> @@ -253,9 +253,7 @@ endif
> #
> # Board-dependent options and extra files
> #
> -ifdef need-compiler
> include $(srctree)/arch/mips/Kbuild.platforms
> -endif
>
> ifdef CONFIG_PHYSICAL_START
> load-y = $(CONFIG_PHYSICAL_START)
> --
> 2.1.0
>
next prev parent reply other threads:[~2021-12-10 16:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-10 4:05 [PATCH v2] MIPS: Makefile: Remove "ifdef need-compiler" for Kbuild.platforms Tiezhu Yang
2021-12-10 16:22 ` Nathan Chancellor [this message]
2021-12-10 16:39 ` Masahiro Yamada
2021-12-13 0:35 ` Ryutaroh Matsumoto
2021-12-13 2:09 ` Nathan Chancellor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YbN+0NrHmsFKfNWP@archlinux-ax161 \
--to=nathan@kernel.org \
--cc=jason@bluehome.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=ryutaroh@ict.e.titech.ac.jp \
--cc=tsbogend@alpha.franken.de \
--cc=yangtiezhu@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.