All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cyril Hrubis <chrubis@suse.cz>
To: Andrea Cervesato <andrea.cervesato@suse.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v5] Refactoring dio_sparse.c using LTP API
Date: Fri, 10 Dec 2021 15:41:24 +0100	[thread overview]
Message-ID: <YbNnFDDT14rbKmCf@yuki> (raw)
In-Reply-To: <20211210135543.21568-1-andrea.cervesato@suse.com>

Hi!
Pushed with two minor changes, thanks.

> +static struct tst_option options[] = {
> +	{"n:", &str_numchildren, "Number of threads (default 1000)"},
> +	{"w:", &str_writesize, "Size of writing blocks (default 1K)"},
> +	{"s:", &str_filesize, "Size of file (default 100M)"},
> +	{"o:", &str_offset, "File offset (default 0)"},
> +	{}
> +};

I've moved this structure to be inline in tst_test initialization, since
otherwise our parser cannot pick it up.

I guess that we should fix that in the API documentation as well.


+ added a paragraph to the test commit message why the -a parameter has
  been removed

-- 
Cyril Hrubis
chrubis@suse.cz

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

      reply	other threads:[~2021-12-10 14:40 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-10 13:55 [LTP] [PATCH v5] Refactoring dio_sparse.c using LTP API Andrea Cervesato via ltp
2021-12-10 14:41 ` Cyril Hrubis [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YbNnFDDT14rbKmCf@yuki \
    --to=chrubis@suse.cz \
    --cc=andrea.cervesato@suse.com \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.