From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BFEA0C433EF for ; Sat, 11 Dec 2021 07:07:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229797AbhLKHHp (ORCPT ); Sat, 11 Dec 2021 02:07:45 -0500 Received: from muru.com ([72.249.23.125]:37134 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229455AbhLKHHp (ORCPT ); Sat, 11 Dec 2021 02:07:45 -0500 Received: from localhost (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 63829809F; Sat, 11 Dec 2021 07:08:26 +0000 (UTC) Date: Sat, 11 Dec 2021 09:07:42 +0200 From: Tony Lindgren To: =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= Cc: Linus Walleij , Rob Herring , Andy Shevchenko , linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Florian Fainelli , bcm-kernel-feedback-list@broadcom.com, =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= Subject: Re: [PATCH V3 2/2] dt-bindings: pinctrl: brcm,ns-pinmux: describe pins, groups & functions Message-ID: References: <20211210114222.26581-1-zajec5@gmail.com> <20211210114222.26581-3-zajec5@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20211210114222.26581-3-zajec5@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org * Rafał Miłecki [211210 11:43]: > @@ -83,6 +97,28 @@ examples: > reg = <0x1800c1c0 0x24>; > reg-names = "cru_gpio_control"; > > + pins { > + i2c_scl: i2c_scl { > + number = <4>; > + }; > + > + i2c_sda: i2c_sda { > + number = <5>; > + }; > + }; Please don't add custom properties for something that can be done with standard register based addressing using a hardware offset based reg property. Your driver can easily translate it. Also, please don't use custom node names, instead do: pins { i2c_scl: pin@0x1234 { /* Any generic standard properties or numbers here please :)d */ }; ... }; I think I've already commented on the register addressing twice before.. Regards, Tony From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B16DCC433F5 for ; Sat, 11 Dec 2021 07:09:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=bbpv4Rhlm++M4cvZHwKbUlR/DJpd7qOAnJKhYlFynDg=; b=JRFTJIYlgjSuWe F7ErO3Wp7Yu5N9iaOXjtBbq24G/UT4R1uzb/r5iNrIOIbLDki43o0jVI2p9xm4GC/cf3nihEj3bue 5zxrFlEaieMxe/5KBKfMCdlZzXovLNkVhn0n9NA5An/mKKDOWe8AqHkzG/ut0uI2tzAEOTxItL5zH /zo4oqseht2ERTVtg8wxZ6e99HhiB6GDxoZyZgy+NwArbI6uUziEaYHEFHEHWxnjnl0+P3hJ2hfi7 bNFst4AcKyTvKzxQb0HCJWU9+jcKAl3JwEGGrGyTsPvIt+1RqlhwcBMP18G1DZx19HYrifucZ5Lcl vR5SZlZLh8n9jz9ZyQSA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mvwU3-004fci-HD; Sat, 11 Dec 2021 07:07:51 +0000 Received: from muru.com ([72.249.23.125]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mvwTz-004fc4-DY for linux-arm-kernel@lists.infradead.org; Sat, 11 Dec 2021 07:07:48 +0000 Received: from localhost (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 63829809F; Sat, 11 Dec 2021 07:08:26 +0000 (UTC) Date: Sat, 11 Dec 2021 09:07:42 +0200 From: Tony Lindgren To: =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= Cc: Linus Walleij , Rob Herring , Andy Shevchenko , linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Florian Fainelli , bcm-kernel-feedback-list@broadcom.com, =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= Subject: Re: [PATCH V3 2/2] dt-bindings: pinctrl: brcm,ns-pinmux: describe pins, groups & functions Message-ID: References: <20211210114222.26581-1-zajec5@gmail.com> <20211210114222.26581-3-zajec5@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20211210114222.26581-3-zajec5@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211210_230747_548804_30ED2EAD X-CRM114-Status: UNSURE ( 7.97 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org KiBSYWZhxYIgTWnFgmVja2kgPHphamVjNUBnbWFpbC5jb20+IFsyMTEyMTAgMTE6NDNdOgo+IEBA IC04Myw2ICs5NywyOCBAQCBleGFtcGxlczoKPiAgICAgICAgICByZWcgPSA8MHgxODAwYzFjMCAw eDI0PjsKPiAgICAgICAgICByZWctbmFtZXMgPSAiY3J1X2dwaW9fY29udHJvbCI7Cj4gIAo+ICsg ICAgICAgIHBpbnMgewo+ICsgICAgICAgICAgICBpMmNfc2NsOiBpMmNfc2NsIHsKPiArICAgICAg ICAgICAgICAgIG51bWJlciA9IDw0PjsKPiArICAgICAgICAgICAgfTsKPiArCj4gKyAgICAgICAg ICAgIGkyY19zZGE6IGkyY19zZGEgewo+ICsgICAgICAgICAgICAgICAgbnVtYmVyID0gPDU+Owo+ ICsgICAgICAgICAgICB9Owo+ICsgICAgICAgIH07CgpQbGVhc2UgZG9uJ3QgYWRkIGN1c3RvbSBw cm9wZXJ0aWVzIGZvciBzb21ldGhpbmcgdGhhdCBjYW4gYmUgZG9uZSB3aXRoCnN0YW5kYXJkIHJl Z2lzdGVyIGJhc2VkIGFkZHJlc3NpbmcgdXNpbmcgYSBoYXJkd2FyZSBvZmZzZXQgYmFzZWQgcmVn CnByb3BlcnR5LiBZb3VyIGRyaXZlciBjYW4gZWFzaWx5IHRyYW5zbGF0ZSBpdC4gQWxzbywgcGxl YXNlIGRvbid0IHVzZQpjdXN0b20gbm9kZSBuYW1lcywgaW5zdGVhZCBkbzoKCnBpbnMgewoJaTJj X3NjbDogcGluQDB4MTIzNCB7CgkJLyogQW55IGdlbmVyaWMgc3RhbmRhcmQgcHJvcGVydGllcyBv ciBudW1iZXJzIGhlcmUgcGxlYXNlIDopZCAqLwoJfTsKCS4uLgp9OwoKSSB0aGluayBJJ3ZlIGFs cmVhZHkgY29tbWVudGVkIG9uIHRoZSByZWdpc3RlciBhZGRyZXNzaW5nIHR3aWNlIGJlZm9yZS4u CgpSZWdhcmRzLAoKVG9ueQoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBs aXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlz dGluZm8vbGludXgtYXJtLWtlcm5lbAo=