From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA4E7C433EF for ; Mon, 13 Dec 2021 05:57:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230357AbhLMF5v (ORCPT ); Mon, 13 Dec 2021 00:57:51 -0500 Received: from muru.com ([72.249.23.125]:37912 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230324AbhLMF5u (ORCPT ); Mon, 13 Dec 2021 00:57:50 -0500 Received: from localhost (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 2B179809F; Mon, 13 Dec 2021 05:58:32 +0000 (UTC) Date: Mon, 13 Dec 2021 07:57:48 +0200 From: Tony Lindgren To: Merlijn Wajer Cc: Ivaylo Dimitrov , Dev Null , Sebastian Reichel , linux-omap@vger.kernel.org, Kevin Hilman , Russell King , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH 1/2] pmic-cpcap: add motorola,droid3 compatible Message-ID: References: <20211212230459.13579-1-merlijn@wizzup.org> <20211212230459.13579-2-merlijn@wizzup.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211212230459.13579-2-merlijn@wizzup.org> Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org * Merlijn Wajer [211212 23:00]: > The Droid 3 and the Bionic appear to share the same hardware, so add > the compatible for the Droid 3 as well. > > Signed-off-by: Merlijn Wajer > --- > arch/arm/mach-omap2/pmic-cpcap.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/arch/arm/mach-omap2/pmic-cpcap.c b/arch/arm/mach-omap2/pmic-cpcap.c > index 668dc84fd31e..b9188dde13b9 100644 > --- a/arch/arm/mach-omap2/pmic-cpcap.c > +++ b/arch/arm/mach-omap2/pmic-cpcap.c > @@ -245,7 +245,8 @@ int __init omap4_cpcap_init(void) > voltdm = voltdm_lookup("mpu"); > omap_voltage_register_pmic(voltdm, &omap443x_max8952_mpu); > > - if (of_machine_is_compatible("motorola,droid-bionic")) { > + if (of_machine_is_compatible("motorola,droid-bionic") || > + of_machine_is_compatible("motorola,droid3")) { > voltdm = voltdm_lookup("core"); > omap_voltage_register_pmic(voltdm, &omap_cpcap_core); > Looks OK to me, however we should also add all the mapphones to the Documentation/devicetree/bindings/arm/omap/omap.txt so we can avoid dtb check warnings. Care to also do a patch for that? Looks like the others are missing too. Regards, Tony From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7F062C433EF for ; Mon, 13 Dec 2021 05:59:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=cnI/ScQ0wg9P6uShcMvX239n0U59IYpoHYw8w5BGVdg=; b=Nhlzr5P3njy4Zk w49MIP8aYtMpNNb5bGd23C/MhmQWHePDH78pDcuxFRcthuVXNq8aII2I7417LCBKmgfLAscHwyLiE vEem9/CFmWHPvExkVgH3Y5GQ9wUmlB3vodGJlgQC2Ilk/h36J/CDFs6P2J9+3V9yY+H7IJ5z8aVWT ZfbwOxPGhUuIbWBVwpqlqAPO+2mRQn23fi1QiytWVuYDWzixF8mJE2UEOQ7pEjRdoUc+3hRj8Xoqe x3iaLaxvzfZywt1pwbaCcjXUrZ6rkUgl1qzQMns4VN2qpaAlOVksLeDYtIe3JezWiSVDVYs3mRkwF 79tQ3k7F4IVkF73YJ2Iw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mweLR-007tkv-UM; Mon, 13 Dec 2021 05:57:54 +0000 Received: from muru.com ([72.249.23.125]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mweLO-007tkX-Qz for linux-arm-kernel@lists.infradead.org; Mon, 13 Dec 2021 05:57:52 +0000 Received: from localhost (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 2B179809F; Mon, 13 Dec 2021 05:58:32 +0000 (UTC) Date: Mon, 13 Dec 2021 07:57:48 +0200 From: Tony Lindgren To: Merlijn Wajer Cc: Ivaylo Dimitrov , Dev Null , Sebastian Reichel , linux-omap@vger.kernel.org, Kevin Hilman , Russell King , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH 1/2] pmic-cpcap: add motorola,droid3 compatible Message-ID: References: <20211212230459.13579-1-merlijn@wizzup.org> <20211212230459.13579-2-merlijn@wizzup.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20211212230459.13579-2-merlijn@wizzup.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211212_215750_941855_2C723BB8 X-CRM114-Status: GOOD ( 16.11 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org * Merlijn Wajer [211212 23:00]: > The Droid 3 and the Bionic appear to share the same hardware, so add > the compatible for the Droid 3 as well. > > Signed-off-by: Merlijn Wajer > --- > arch/arm/mach-omap2/pmic-cpcap.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/arch/arm/mach-omap2/pmic-cpcap.c b/arch/arm/mach-omap2/pmic-cpcap.c > index 668dc84fd31e..b9188dde13b9 100644 > --- a/arch/arm/mach-omap2/pmic-cpcap.c > +++ b/arch/arm/mach-omap2/pmic-cpcap.c > @@ -245,7 +245,8 @@ int __init omap4_cpcap_init(void) > voltdm = voltdm_lookup("mpu"); > omap_voltage_register_pmic(voltdm, &omap443x_max8952_mpu); > > - if (of_machine_is_compatible("motorola,droid-bionic")) { > + if (of_machine_is_compatible("motorola,droid-bionic") || > + of_machine_is_compatible("motorola,droid3")) { > voltdm = voltdm_lookup("core"); > omap_voltage_register_pmic(voltdm, &omap_cpcap_core); > Looks OK to me, however we should also add all the mapphones to the Documentation/devicetree/bindings/arm/omap/omap.txt so we can avoid dtb check warnings. Care to also do a patch for that? Looks like the others are missing too. Regards, Tony _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel